Browse Source

refactor: review comments and lint

Signed-off-by: Pranav C <pranavxc@gmail.com>
pull/9176/head
Pranav C 4 months ago
parent
commit
f8b8bcd02b
  1. 4
      packages/nc-gui/components/general/Gift.vue
  2. 2
      packages/nc-gui/utils/iconUtils.ts
  3. 2
      packages/nocodb/src/controllers/integrations.controller.ts
  4. 2
      packages/nocodb/src/models/Integration.ts
  5. 4
      packages/nocodb/src/services/integrations.service.ts

4
packages/nc-gui/components/general/Gift.vue

@ -84,10 +84,8 @@ const closeModal = () => {
width="100%"
style="height: max(600px, 90vh)"
:src="appInfo.giftUrl"
title="YouTube video player"
title="Gifts Unlocked!"
frameborder="0"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
allowfullscreen
></iframe>
</div>
</NcModal>

2
packages/nc-gui/utils/iconUtils.ts

@ -776,7 +776,7 @@ export const iconMap = {
quickbooks: NcQuickbooks,
intercom: NcIntercom,
dropbox: NcDropbox,
gift: NcIconsGift
gift: NcIconsGift,
}
export const getMdiIcon = (type: string): any => {

2
packages/nocodb/src/controllers/integrations.controller.ts

@ -125,7 +125,7 @@ export class IntegrationsController {
// if limit/offset is not provided, then return all integrations
limit: limit && (+limit || 25),
offset: offset && (+offset || 0),
query
query,
});
if (!includeDatabaseInfo) {

2
packages/nocodb/src/models/Integration.ts

@ -175,7 +175,7 @@ export default class Integration implements IntegrationType {
limit?: number;
offset?: number;
includeSourceCount?: boolean;
query?: string
query?: string;
},
ncMeta = Noco.ncMeta,
): Promise<PagedResponseImpl<Integration>> {

4
packages/nocodb/src/services/integrations.service.ts

@ -80,7 +80,7 @@ export class IntegrationsService {
type?: IntegrationsType;
limit?: number;
offset?: number;
query?: string
query?: string;
}) {
const integrations = await Integration.list({
userId: param.req.user?.id,
@ -89,7 +89,7 @@ export class IntegrationsService {
limit: param.limit,
offset: param.offset,
includeSourceCount: true,
query: param.query
query: param.query,
});
return integrations;

Loading…
Cancel
Save