From f8b8bcd02b9e7a7ecdcdb5f0c715cae6079cf66c Mon Sep 17 00:00:00 2001 From: Pranav C Date: Thu, 8 Aug 2024 11:14:01 +0530 Subject: [PATCH] refactor: review comments and lint Signed-off-by: Pranav C --- packages/nc-gui/components/general/Gift.vue | 4 +--- packages/nc-gui/utils/iconUtils.ts | 2 +- packages/nocodb/src/controllers/integrations.controller.ts | 2 +- packages/nocodb/src/models/Integration.ts | 2 +- packages/nocodb/src/services/integrations.service.ts | 4 ++-- 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/nc-gui/components/general/Gift.vue b/packages/nc-gui/components/general/Gift.vue index cc83ffb6d3..7ffb0a0abf 100644 --- a/packages/nc-gui/components/general/Gift.vue +++ b/packages/nc-gui/components/general/Gift.vue @@ -84,10 +84,8 @@ const closeModal = () => { width="100%" style="height: max(600px, 90vh)" :src="appInfo.giftUrl" - title="YouTube video player" + title="Gifts Unlocked!" frameborder="0" - allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" - allowfullscreen > diff --git a/packages/nc-gui/utils/iconUtils.ts b/packages/nc-gui/utils/iconUtils.ts index 4c1660348d..acc7b43404 100644 --- a/packages/nc-gui/utils/iconUtils.ts +++ b/packages/nc-gui/utils/iconUtils.ts @@ -776,7 +776,7 @@ export const iconMap = { quickbooks: NcQuickbooks, intercom: NcIntercom, dropbox: NcDropbox, - gift: NcIconsGift + gift: NcIconsGift, } export const getMdiIcon = (type: string): any => { diff --git a/packages/nocodb/src/controllers/integrations.controller.ts b/packages/nocodb/src/controllers/integrations.controller.ts index 1b8820156e..cb2c61dfbe 100644 --- a/packages/nocodb/src/controllers/integrations.controller.ts +++ b/packages/nocodb/src/controllers/integrations.controller.ts @@ -125,7 +125,7 @@ export class IntegrationsController { // if limit/offset is not provided, then return all integrations limit: limit && (+limit || 25), offset: offset && (+offset || 0), - query + query, }); if (!includeDatabaseInfo) { diff --git a/packages/nocodb/src/models/Integration.ts b/packages/nocodb/src/models/Integration.ts index dec84e6dae..dca0f3f148 100644 --- a/packages/nocodb/src/models/Integration.ts +++ b/packages/nocodb/src/models/Integration.ts @@ -175,7 +175,7 @@ export default class Integration implements IntegrationType { limit?: number; offset?: number; includeSourceCount?: boolean; - query?: string + query?: string; }, ncMeta = Noco.ncMeta, ): Promise> { diff --git a/packages/nocodb/src/services/integrations.service.ts b/packages/nocodb/src/services/integrations.service.ts index 03355cf64d..7a19259e06 100644 --- a/packages/nocodb/src/services/integrations.service.ts +++ b/packages/nocodb/src/services/integrations.service.ts @@ -80,7 +80,7 @@ export class IntegrationsService { type?: IntegrationsType; limit?: number; offset?: number; - query?: string + query?: string; }) { const integrations = await Integration.list({ userId: param.req.user?.id, @@ -89,7 +89,7 @@ export class IntegrationsService { limit: param.limit, offset: param.offset, includeSourceCount: true, - query: param.query + query: param.query, }); return integrations;