Browse Source

chore: style changes from review comments

pull/8629/head
rohittp 6 months ago
parent
commit
caaf696ec3
  1. 6
      packages/nc-gui/components/smartsheet/expanded-form/index.vue
  2. 12
      packages/nc-gui/components/smartsheet/header/Menu.vue

6
packages/nc-gui/components/smartsheet/expanded-form/index.vue

@ -647,10 +647,10 @@ export default {
<div <div
v-e="['c:row-expand:copy-url']" v-e="['c:row-expand:copy-url']"
data-testid="nc-expanded-form-copy-url" data-testid="nc-expanded-form-copy-url"
class="flex gap-2 items-center text-small" class="flex items-center"
> >
<component :is="iconMap.check" v-if="isRecordLinkCopied" class="cursor-pointer nc-duplicate-row" /> <component :is="iconMap.check" v-if="isRecordLinkCopied" class="cursor-pointer nc-duplicate-row h-4 w-4" />
<component :is="iconMap.copy" v-else class="cursor-pointer nc-duplicate-row" /> <component :is="iconMap.copy" v-else class="cursor-pointer nc-duplicate-row h-4 w-4" />
</div> </div>
</NcButton> </NcButton>
</NcTooltip> </NcTooltip>

12
packages/nc-gui/components/smartsheet/header/Menu.vue

@ -389,24 +389,28 @@ const filterOrGroupByThisField = (event: SmartsheetStoreEvents) => {
<a-divider v-if="!column?.pv" class="!my-0" /> <a-divider v-if="!column?.pv" class="!my-0" />
<NcMenuItem v-if="!column?.pv" @click="hideOrShowField"> <NcMenuItem v-if="!column?.pv" @click="hideOrShowField">
<div v-e="['a:field:hide']" class="nc-column-insert-before nc-header-menu-item"> <div v-e="['a:field:hide']" class="nc-column-insert-before nc-header-menu-item">
<component :is="isHiddenCol ? iconMap.eye : iconMap.eyeSlash" class="text-gray-700 !w-3.75 !h-3.75" /> <component
:is="isHiddenCol ? iconMap.eye : iconMap.eyeSlash"
v-show="isLoading !== 'hideOrShow'"
class="text-gray-700 !w-3.75 !h-3.75"
/>
<GeneralLoader v-show="isLoading === 'hideOrShow'" size="large" class="!w-3.75 !h-3.75" />
<!-- Hide Field --> <!-- Hide Field -->
{{ isHiddenCol ? $t('general.showField') : $t('general.hideField') }} {{ isHiddenCol ? $t('general.showField') : $t('general.hideField') }}
</div> </div>
<GeneralLoader v-show="isLoading === 'hideOrShow'" size="large" class="ml-2" />
</NcMenuItem> </NcMenuItem>
<NcMenuItem <NcMenuItem
v-if="(!virtual || column?.uidt === UITypes.Formula) && !column?.pv && !isHiddenCol" v-if="(!virtual || column?.uidt === UITypes.Formula) && !column?.pv && !isHiddenCol"
@click="setAsDisplayValue" @click="setAsDisplayValue"
> >
<div class="nc-column-set-primary nc-header-menu-item item"> <div class="nc-column-set-primary nc-header-menu-item item">
<GeneralIcon icon="star" class="text-gray-700 !w-4.25 !h-4.25" /> <GeneralIcon v-show="isLoading !== 'setDisplay'" icon="star" class="text-gray-700 !w-4.25 !h-4.25" />
<GeneralLoader v-show="isLoading === 'setDisplay'" size="large" class="!w-4.25 !h-4.25" />
<!-- todo : tooltip --> <!-- todo : tooltip -->
<!-- Set as Display value --> <!-- Set as Display value -->
{{ $t('activity.setDisplay') }} {{ $t('activity.setDisplay') }}
</div> </div>
<GeneralLoader v-show="isLoading === 'setDisplay'" size="large" class="ml-2" />
</NcMenuItem> </NcMenuItem>
<template v-if="!isExpandedForm"> <template v-if="!isExpandedForm">

Loading…
Cancel
Save