From caaf696ec39bbb86f51f31775850993c17efe9ae Mon Sep 17 00:00:00 2001
From: rohittp <tprohit9@gmail.com>
Date: Mon, 3 Jun 2024 11:34:40 +0000
Subject: [PATCH] chore: style changes from review comments

---
 .../components/smartsheet/expanded-form/index.vue    |  6 +++---
 .../nc-gui/components/smartsheet/header/Menu.vue     | 12 ++++++++----
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/packages/nc-gui/components/smartsheet/expanded-form/index.vue b/packages/nc-gui/components/smartsheet/expanded-form/index.vue
index e40dc2ef2d..481f839566 100644
--- a/packages/nc-gui/components/smartsheet/expanded-form/index.vue
+++ b/packages/nc-gui/components/smartsheet/expanded-form/index.vue
@@ -647,10 +647,10 @@ export default {
               <div
                 v-e="['c:row-expand:copy-url']"
                 data-testid="nc-expanded-form-copy-url"
-                class="flex gap-2 items-center text-small"
+                class="flex items-center"
               >
-                <component :is="iconMap.check" v-if="isRecordLinkCopied" class="cursor-pointer nc-duplicate-row" />
-                <component :is="iconMap.copy" v-else class="cursor-pointer nc-duplicate-row" />
+                <component :is="iconMap.check" v-if="isRecordLinkCopied" class="cursor-pointer nc-duplicate-row h-4 w-4" />
+                <component :is="iconMap.copy" v-else class="cursor-pointer nc-duplicate-row h-4 w-4" />
               </div>
             </NcButton>
           </NcTooltip>
diff --git a/packages/nc-gui/components/smartsheet/header/Menu.vue b/packages/nc-gui/components/smartsheet/header/Menu.vue
index da89546995..86188ff505 100644
--- a/packages/nc-gui/components/smartsheet/header/Menu.vue
+++ b/packages/nc-gui/components/smartsheet/header/Menu.vue
@@ -389,24 +389,28 @@ const filterOrGroupByThisField = (event: SmartsheetStoreEvents) => {
         <a-divider v-if="!column?.pv" class="!my-0" />
         <NcMenuItem v-if="!column?.pv" @click="hideOrShowField">
           <div v-e="['a:field:hide']" class="nc-column-insert-before nc-header-menu-item">
-            <component :is="isHiddenCol ? iconMap.eye : iconMap.eyeSlash" class="text-gray-700 !w-3.75 !h-3.75" />
+            <component
+              :is="isHiddenCol ? iconMap.eye : iconMap.eyeSlash"
+              v-show="isLoading !== 'hideOrShow'"
+              class="text-gray-700 !w-3.75 !h-3.75"
+            />
+            <GeneralLoader v-show="isLoading === 'hideOrShow'" size="large" class="!w-3.75 !h-3.75" />
             <!-- Hide Field -->
             {{ isHiddenCol ? $t('general.showField') : $t('general.hideField') }}
           </div>
-          <GeneralLoader v-show="isLoading === 'hideOrShow'" size="large" class="ml-2" />
         </NcMenuItem>
         <NcMenuItem
           v-if="(!virtual || column?.uidt === UITypes.Formula) && !column?.pv && !isHiddenCol"
           @click="setAsDisplayValue"
         >
           <div class="nc-column-set-primary nc-header-menu-item item">
-            <GeneralIcon icon="star" class="text-gray-700 !w-4.25 !h-4.25" />
+            <GeneralIcon v-show="isLoading !== 'setDisplay'" icon="star" class="text-gray-700 !w-4.25 !h-4.25" />
+            <GeneralLoader v-show="isLoading === 'setDisplay'" size="large" class="!w-4.25 !h-4.25" />
 
             <!--       todo : tooltip -->
             <!-- Set as Display value -->
             {{ $t('activity.setDisplay') }}
           </div>
-          <GeneralLoader v-show="isLoading === 'setDisplay'" size="large" class="ml-2" />
         </NcMenuItem>
 
         <template v-if="!isExpandedForm">