fix: permission correction

packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue

@@ -104,7 +104,7 @@ const showBaseOption = (source: SourceType) => {
   return ['airtableImport', 'csvImport', 'jsonImport', 'excelImport'].some((permission) =>
     isUIAllowed(permission, { source }),
   )
-})
+}
 
 const enableEditMode = () => {
   editMode.value = true

packages/nc-gui/components/dashboard/settings/data-sources/CreateBase.vue

@@ -56,9 +56,8 @@ const formState = ref<ProjectCreateForm>({
   },
   sslUse: SSLUsage.No,
   extraParameters: [],
-  'is_schema_readonly': true,
+  is_schema_readonly: true,
-  'is_data_readonly': false,
+  is_data_readonly: false,
-},
 })
 
 const customFormState = ref<ProjectCreateForm>({
@@ -516,8 +515,7 @@ const allowDataWrite = computed({
 
               <!-- Username -->
               <a-form-item :label="$t('labels.username')" v-bind="validateInfos['dataSource.connection.user']">
-                <a-input v-model:value="(formState.dataSource.connection as DefaultConnection).user"
+                <a-input v-model:value="(formState.dataSource.connection as DefaultConnection).user" class="nc-extdb-host-user" />
-                         class="nc-extdb-host-user"/>
               </a-form-item>
 
               <!-- Password -->
@@ -593,8 +591,7 @@ const allowDataWrite = computed({
 
               <div class="flex items-right justify-end gap-2">
                 <!--                Use Connection URL -->
-                <NcButton type="ghost" size="small" class="nc-extdb-btn-import-url !rounded-md"
+                <NcButton type="ghost" size="small" class="nc-extdb-btn-import-url !rounded-md" @click.stop="importURLDlg = true">
-                          @click.stop="importURLDlg = true">
                   {{ $t('activity.useConnectionUrl') }}
                 </NcButton>
               </div>
@@ -632,8 +629,7 @@ const allowDataWrite = computed({
                           <span>{{ $t('tooltip.clientCert') }}</span>
                         </template>
 
-                        <NcButton size="small" :disabled="!sslFilesRequired" class="shadow"
+                        <NcButton size="small" :disabled="!sslFilesRequired" class="shadow" @click="certFileInput?.click()">
-                                  @click="certFileInput?.click()">
                           {{ $t('labels.clientCert') }}
                         </NcButton>
                       </a-tooltip>
@@ -643,8 +639,7 @@ const allowDataWrite = computed({
                         <template #title>
                           <span>{{ $t('tooltip.clientKey') }}</span>
                         </template>
-                        <NcButton size="small" :disabled="!sslFilesRequired" class="shadow"
+                        <NcButton size="small" :disabled="!sslFilesRequired" class="shadow" @click="keyFileInput?.click()">
-                                  @click="keyFileInput?.click()">
                           {{ $t('labels.clientKey') }}
                         </NcButton>
                       </a-tooltip>
@@ -655,22 +650,18 @@ const allowDataWrite = computed({
                           <span>{{ $t('tooltip.clientCA') }}</span>
                         </template>
 
-                        <NcButton size="small" :disabled="!sslFilesRequired" class="shadow"
+                        <NcButton size="small" :disabled="!sslFilesRequired" class="shadow" @click="caFileInput?.click()">
-                                  @click="caFileInput?.click()">
                           {{ $t('labels.serverCA') }}
                         </NcButton>
                       </a-tooltip>
                     </div>
                   </a-form-item>
 
-                  <input ref="caFileInput" type="file" class="!hidden"
+                  <input ref="caFileInput" type="file" class="!hidden" @change="onFileSelect(CertTypes.ca, caFileInput)" />
-                         @change="onFileSelect(CertTypes.ca, caFileInput)"/>
 
-                  <input ref="certFileInput" type="file" class="!hidden"
+                  <input ref="certFileInput" type="file" class="!hidden" @change="onFileSelect(CertTypes.cert, certFileInput)" />
-                         @change="onFileSelect(CertTypes.cert, certFileInput)"/>
 
-                  <input ref="keyFileInput" type="file" class="!hidden"
+                  <input ref="keyFileInput" type="file" class="!hidden" @change="onFileSelect(CertTypes.key, keyFileInput)" />
-                         @change="onFileSelect(CertTypes.key, keyFileInput)"/>
 
                   <a-divider />
 
@@ -729,8 +720,7 @@ const allowDataWrite = computed({
                       v-model:value="formState.inflection.inflectionColumn"
                       dropdown-class-name="nc-dropdown-inflection-column-name"
                     >
-                      <a-select-option v-for="tp in inflectionTypes" :key="tp" :value="tp"
+                      <a-select-option v-for="tp in inflectionTypes" :key="tp" :value="tp">
-                      >
                         <div class="flex items-center gap-2 justify-between">
                           <div>{{ tp }}</div>
                           <component

packages/nocodb/src/utils/acl.ts

@@ -450,28 +450,34 @@ Object.values(rolePermissions).forEach((role) => {
   }
 });
 
-// excluded/restricted permissions at source level based on source restriction
+// Excluded permissions for source restrictions
 // `true` means permission is restricted and `false`/missing means permission is allowed
 export const sourceRestrictions = {
-  [SourceRestriction.DATA_READONLY]: {
-    dataInsert: true,
-    dataEdit: true,
-    dataDelete: true,
-    airtableImport: true,
-    csvImport: true,
-    jsonImport: true,
-    excelImport: true,
-  },
   [SourceRestriction.SCHEMA_READONLY]: {
     tableCreate: true,
-    tableRename: true,
     tableDelete: true,
-    tableDuplicate: true,
+    tableUpdate: true,
-    airtableImport: true,
+    // columnAdd: true,
-    csvImport: true,
+    // columnDelete: true,
-    jsonImport: true,
+    // columnUpdate: true,
-    excelImport: true,
+    columnBulk: true,
+  },
+  [SourceRestriction.DATA_READONLY]: {
+    dataUpdate: true,
+    dataDelete: true,
+    dataInsert: true,
+    bulkDataInsert: true,
+    bulkDataUpdate: true,
+    bulkDataUpdateAll: true,
+    bulkDataDelete: true,
+    bulkDataDeleteAll: true,
+    relationDataRemove: true,
+    relationDataAdd: true,
+    nestedDataListCopyPasteOrDeleteAll: true,
+    nestedDataUnlink: true,
+    nestedDataLink: true,
   },
 };
 
+
 export default rolePermissions;