Browse Source

Fix unit test

pull/205/head
Decebal Suiu 7 years ago
parent
commit
e81057f72a
  1. 13
      pf4j/src/test/java/org/pf4j/DefaultPluginManagerTest.java

13
pf4j/src/test/java/org/pf4j/DefaultPluginManagerTest.java

@ -36,7 +36,6 @@ public class DefaultPluginManagerTest {
pd1 = new DefaultPluginDescriptor(); pd1 = new DefaultPluginDescriptor();
pd1.setPluginId("myPlugin"); pd1.setPluginId("myPlugin");
pd1.setPluginVersion("1.2.3"); pd1.setPluginVersion("1.2.3");
pd1.setPluginClass("foo");
pd1.setPluginDescription("My plugin"); pd1.setPluginDescription("My plugin");
pd1.setDependencies("bar, baz"); pd1.setDependencies("bar, baz");
pd1.setProvider("Me"); pd1.setProvider("Me");
@ -62,14 +61,14 @@ public class DefaultPluginManagerTest {
pluginManager.validatePluginDescriptor(pd1); pluginManager.validatePluginDescriptor(pd1);
} }
@Test(expected = PluginException.class) @Test
public void validateFailsOnClass() throws PluginException { public void validateNoPluginClass() throws PluginException {
pd1.setPluginClass(null);
pluginManager.validatePluginDescriptor(pd1); pluginManager.validatePluginDescriptor(pd1);
assertEquals(Plugin.class.getName(), pd1.getPluginClass());
} }
@Test @Test
public void isPluginValid() throws Exception { public void isPluginValid() {
// By default accept all since system version not given // By default accept all since system version not given
assertTrue(pluginManager.isPluginValid(pw1)); assertTrue(pluginManager.isPluginValid(pw1));
@ -84,7 +83,7 @@ public class DefaultPluginManagerTest {
} }
@Test @Test
public void isPluginValidAllowExact() throws Exception { public void isPluginValidAllowExact() {
pluginManager.setExactVersionAllowed(true); pluginManager.setExactVersionAllowed(true);
// By default accept all since system version not given // By default accept all since system version not given
@ -101,7 +100,7 @@ public class DefaultPluginManagerTest {
} }
@Test @Test
public void testDefaultExactVersionAllowed() throws Exception { public void testDefaultExactVersionAllowed() {
assertEquals(false, pluginManager.isExactVersionAllowed()); assertEquals(false, pluginManager.isExactVersionAllowed());
} }

Loading…
Cancel
Save