close JarFile stream after getManifest (#197)

7 years ago · e80aae6c1f
1 changed files with 2 additions and 2 deletions
--- a/pf4j/src/main/java/org/pf4j/ManifestPluginDescriptorFinder.java
+++ b/pf4j/src/main/java/org/pf4j/ManifestPluginDescriptorFinder.java
@ -51,8 +51,8 @@ public class ManifestPluginDescriptorFinder implements PluginDescriptorFinder {
    protected Manifest readManifest(Path pluginPath) throws PluginException {
        if (FileUtils.isJarFile(pluginPath)) {
-            try {
+            try(JarFile jar = new JarFile(pluginPath.toFile())) {
-                Manifest manifest = new JarFile(pluginPath.toFile()).getManifest();
+                Manifest manifest = jar.getManifest();
                if (manifest != null) {
                    return manifest;
                }