Browse Source

Modifier "public" is redundant for interface methods

pull/94/merge
Decebal Suiu 9 years ago
parent
commit
1a00fbd0af
  1. 2
      demo/api/src/main/java/ro/fortsoft/pf4j/demo/api/Greeting.java
  2. 2
      pf4j/src/main/java/ro/fortsoft/pf4j/ExtensionFactory.java
  3. 4
      pf4j/src/main/java/ro/fortsoft/pf4j/ExtensionFinder.java
  4. 2
      pf4j/src/main/java/ro/fortsoft/pf4j/PluginDescriptorFinder.java
  5. 2
      pf4j/src/main/java/ro/fortsoft/pf4j/PluginFactory.java
  6. 52
      pf4j/src/main/java/ro/fortsoft/pf4j/PluginManager.java
  7. 4
      pf4j/src/main/java/ro/fortsoft/pf4j/PluginRepository.java
  8. 2
      pf4j/src/main/java/ro/fortsoft/pf4j/PluginStateListener.java
  9. 6
      pf4j/src/main/java/ro/fortsoft/pf4j/PluginStatusProvider.java

2
demo/api/src/main/java/ro/fortsoft/pf4j/demo/api/Greeting.java

@ -22,6 +22,6 @@ import ro.fortsoft.pf4j.ExtensionPoint;
*/ */
public interface Greeting extends ExtensionPoint { public interface Greeting extends ExtensionPoint {
public String getGreeting(); String getGreeting();
} }

2
pf4j/src/main/java/ro/fortsoft/pf4j/ExtensionFactory.java

@ -20,6 +20,6 @@ package ro.fortsoft.pf4j;
*/ */
public interface ExtensionFactory { public interface ExtensionFactory {
public Object create(Class<?> extensionClass); Object create(Class<?> extensionClass);
} }

4
pf4j/src/main/java/ro/fortsoft/pf4j/ExtensionFinder.java

@ -26,11 +26,11 @@ public interface ExtensionFinder {
/** /**
* Retrieves a list with all extensions found for an extension point. * Retrieves a list with all extensions found for an extension point.
*/ */
public <T> List<ExtensionWrapper<T>> find(Class<T> type); <T> List<ExtensionWrapper<T>> find(Class<T> type);
/** /**
* Retrieves a list with all extension class names found for a plugin. * Retrieves a list with all extension class names found for a plugin.
*/ */
public Set<String> findClassNames(String pluginId); Set<String> findClassNames(String pluginId);
} }

2
pf4j/src/main/java/ro/fortsoft/pf4j/PluginDescriptorFinder.java

@ -26,6 +26,6 @@ import java.io.File;
*/ */
public interface PluginDescriptorFinder { public interface PluginDescriptorFinder {
public PluginDescriptor find(File pluginRepository) throws PluginException; PluginDescriptor find(File pluginRepository) throws PluginException;
} }

2
pf4j/src/main/java/ro/fortsoft/pf4j/PluginFactory.java

@ -20,6 +20,6 @@ package ro.fortsoft.pf4j;
*/ */
public interface PluginFactory { public interface PluginFactory {
public Plugin create(PluginWrapper pluginWrapper); Plugin create(PluginWrapper pluginWrapper);
} }

52
pf4j/src/main/java/ro/fortsoft/pf4j/PluginManager.java

@ -31,27 +31,27 @@ public interface PluginManager {
/** /**
* Retrieves all plugins. * Retrieves all plugins.
*/ */
public List<PluginWrapper> getPlugins(); List<PluginWrapper> getPlugins();
/** /**
* Retrieves all plugins with this state. * Retrieves all plugins with this state.
*/ */
public List<PluginWrapper> getPlugins(PluginState pluginState); List<PluginWrapper> getPlugins(PluginState pluginState);
/** /**
* Retrieves all resolved plugins (with resolved dependency). * Retrieves all resolved plugins (with resolved dependency).
*/ */
public List<PluginWrapper> getResolvedPlugins(); List<PluginWrapper> getResolvedPlugins();
/** /**
* Retrieves all unresolved plugins (with unresolved dependency). * Retrieves all unresolved plugins (with unresolved dependency).
*/ */
public List<PluginWrapper> getUnresolvedPlugins(); List<PluginWrapper> getUnresolvedPlugins();
/** /**
* Retrieves all started plugins. * Retrieves all started plugins.
*/ */
public List<PluginWrapper> getStartedPlugins(); List<PluginWrapper> getStartedPlugins();
/** /**
* Retrieves the plugin with this id. * Retrieves the plugin with this id.
@ -59,12 +59,12 @@ public interface PluginManager {
* @param pluginId * @param pluginId
* @return the plugin * @return the plugin
*/ */
public PluginWrapper getPlugin(String pluginId); PluginWrapper getPlugin(String pluginId);
/** /**
* Load plugins. * Load plugins.
*/ */
public void loadPlugins(); void loadPlugins();
/** /**
* Load a plugin. * Load a plugin.
@ -72,31 +72,31 @@ public interface PluginManager {
* @param pluginArchiveFile * @param pluginArchiveFile
* @return the pluginId of the installed plugin or null * @return the pluginId of the installed plugin or null
*/ */
public String loadPlugin(File pluginArchiveFile); String loadPlugin(File pluginArchiveFile);
/** /**
* Start all active plugins. * Start all active plugins.
*/ */
public void startPlugins(); void startPlugins();
/** /**
* Start the specified plugin and it's dependencies. * Start the specified plugin and it's dependencies.
* *
* @return the plugin state * @return the plugin state
*/ */
public PluginState startPlugin(String pluginId); PluginState startPlugin(String pluginId);
/** /**
* Stop all active plugins. * Stop all active plugins.
*/ */
public void stopPlugins(); void stopPlugins();
/** /**
* Stop the specified plugin and it's dependencies. * Stop the specified plugin and it's dependencies.
* *
* @return the plugin state * @return the plugin state
*/ */
public PluginState stopPlugin(String pluginId); PluginState stopPlugin(String pluginId);
/** /**
* Unload a plugin. * Unload a plugin.
@ -104,7 +104,7 @@ public interface PluginManager {
* @param pluginId * @param pluginId
* @return true if the plugin was unloaded * @return true if the plugin was unloaded
*/ */
public boolean unloadPlugin(String pluginId); boolean unloadPlugin(String pluginId);
/** /**
* Disables a plugin from being loaded. * Disables a plugin from being loaded.
@ -112,7 +112,7 @@ public interface PluginManager {
* @param pluginId * @param pluginId
* @return true if plugin is disabled * @return true if plugin is disabled
*/ */
public boolean disablePlugin(String pluginId); boolean disablePlugin(String pluginId);
/** /**
* Enables a plugin that has previously been disabled. * Enables a plugin that has previously been disabled.
@ -120,7 +120,7 @@ public interface PluginManager {
* @param pluginId * @param pluginId
* @return true if plugin is enabled * @return true if plugin is enabled
*/ */
public boolean enablePlugin(String pluginId); boolean enablePlugin(String pluginId);
/** /**
* Deletes a plugin. * Deletes a plugin.
@ -128,29 +128,29 @@ public interface PluginManager {
* @param pluginId * @param pluginId
* @return true if the plugin was deleted * @return true if the plugin was deleted
*/ */
public boolean deletePlugin(String pluginId); boolean deletePlugin(String pluginId);
public PluginClassLoader getPluginClassLoader(String pluginId); PluginClassLoader getPluginClassLoader(String pluginId);
public <T> List<T> getExtensions(Class<T> type); <T> List<T> getExtensions(Class<T> type);
public Set<String> getExtensionClassNames(String pluginId); Set<String> getExtensionClassNames(String pluginId);
public ExtensionFactory getExtensionFactory(); ExtensionFactory getExtensionFactory();
/** /**
* The runtime mode. Must currently be either DEVELOPMENT or DEPLOYMENT. * The runtime mode. Must currently be either DEVELOPMENT or DEPLOYMENT.
*/ */
public RuntimeMode getRuntimeMode(); RuntimeMode getRuntimeMode();
/** /**
* Retrieves the {@link PluginWrapper} that loaded the given class 'clazz'. * Retrieves the {@link PluginWrapper} that loaded the given class 'clazz'.
*/ */
public PluginWrapper whichPlugin(Class<?> clazz); PluginWrapper whichPlugin(Class<?> clazz);
public void addPluginStateListener(PluginStateListener listener); void addPluginStateListener(PluginStateListener listener);
public void removePluginStateListener(PluginStateListener listener); void removePluginStateListener(PluginStateListener listener);
/** /**
* Set the system version. This is used to compare against the plugin * Set the system version. This is used to compare against the plugin
@ -160,13 +160,13 @@ public interface PluginManager {
* @default 0.0.0 * @default 0.0.0
* @param version * @param version
*/ */
public void setSystemVersion(Version version); void setSystemVersion(Version version);
/** /**
* Returns the system version. * Returns the system version.
* *
* * @return the system version * * @return the system version
*/ */
public Version getSystemVersion(); Version getSystemVersion();
} }

4
pf4j/src/main/java/ro/fortsoft/pf4j/PluginRepository.java

@ -31,7 +31,7 @@ public interface PluginRepository {
* *
* @return a list of files * @return a list of files
*/ */
public List<File> getPluginArchives(); List<File> getPluginArchives();
/** /**
* Removes a plugin from the repository. * Removes a plugin from the repository.
@ -39,6 +39,6 @@ public interface PluginRepository {
* @param pluginPath the plugin path * @param pluginPath the plugin path
* @return true if deleted * @return true if deleted
*/ */
public boolean deletePluginArchive(String pluginPath); boolean deletePluginArchive(String pluginPath);
} }

2
pf4j/src/main/java/ro/fortsoft/pf4j/PluginStateListener.java

@ -27,6 +27,6 @@ public interface PluginStateListener extends EventListener {
/** /**
* Invoked when a plugin's state (for example DISABLED, STARTED) is changed. * Invoked when a plugin's state (for example DISABLED, STARTED) is changed.
*/ */
public void pluginStateChanged(PluginStateEvent event); void pluginStateChanged(PluginStateEvent event);
} }

6
pf4j/src/main/java/ro/fortsoft/pf4j/PluginStatusProvider.java

@ -27,7 +27,7 @@ public interface PluginStatusProvider {
* @param pluginId the plugin id * @param pluginId the plugin id
* @return if the plugin is disabled or not * @return if the plugin is disabled or not
*/ */
public boolean isPluginDisabled(String pluginId); boolean isPluginDisabled(String pluginId);
/** /**
* Disables a plugin from being loaded. * Disables a plugin from being loaded.
@ -35,7 +35,7 @@ public interface PluginStatusProvider {
* @param pluginId * @param pluginId
* @return true if plugin is disabled * @return true if plugin is disabled
*/ */
public boolean disablePlugin(String pluginId); boolean disablePlugin(String pluginId);
/** /**
* Enables a plugin that has previously been disabled. * Enables a plugin that has previously been disabled.
@ -43,6 +43,6 @@ public interface PluginStatusProvider {
* @param pluginId * @param pluginId
* @return true if plugin is enabled * @return true if plugin is enabled
*/ */
public boolean enablePlugin(String pluginId); boolean enablePlugin(String pluginId);
} }

Loading…
Cancel
Save