Browse Source

chore(nc-gui): add comments about lazy load issues

pull/4031/head
braks 2 years ago
parent
commit
f914083e71
  1. 1
      packages/nc-gui/components/smartsheet/sidebar/MenuTop.vue
  2. 1
      packages/nc-gui/components/tabs/Smartsheet.vue

1
packages/nc-gui/components/smartsheet/sidebar/MenuTop.vue

@ -217,6 +217,7 @@ function openDeleteDialog(view: ViewType) {
<template> <template>
<a-menu ref="menuRef" :class="{ dragging }" class="nc-views-menu flex-1" :selected-keys="selected"> <a-menu ref="menuRef" :class="{ dragging }" class="nc-views-menu flex-1" :selected-keys="selected">
<!-- Lazy load breaks menu item active styles, i.e. styles never change even when active item changes -->
<SmartsheetSidebarRenameableMenuItem <SmartsheetSidebarRenameableMenuItem
v-for="view of views" v-for="view of views"
:id="view.id" :id="view.id"

1
packages/nc-gui/components/tabs/Smartsheet.vue

@ -79,6 +79,7 @@ provide(TabMetaInj, activeTab)
</Transition> </Transition>
</div> </div>
<!-- Lazy loading the sidebar causes issues when deleting elements, i.e. it appears as if multiple elements are removed when they are not -->
<SmartsheetSidebar v-if="meta" class="nc-right-sidebar" /> <SmartsheetSidebar v-if="meta" class="nc-right-sidebar" />
</div> </div>
</template> </template>

Loading…
Cancel
Save