From f914083e71627392ffaadc7c3f3e806bd1ae544b Mon Sep 17 00:00:00 2001
From: braks <78412429+bcakmakoglu@users.noreply.github.com>
Date: Thu, 13 Oct 2022 11:37:37 +0200
Subject: [PATCH] chore(nc-gui): add comments about lazy load issues

---
 packages/nc-gui/components/smartsheet/sidebar/MenuTop.vue | 1 +
 packages/nc-gui/components/tabs/Smartsheet.vue            | 1 +
 2 files changed, 2 insertions(+)

diff --git a/packages/nc-gui/components/smartsheet/sidebar/MenuTop.vue b/packages/nc-gui/components/smartsheet/sidebar/MenuTop.vue
index e01219308d..a9edb68a73 100644
--- a/packages/nc-gui/components/smartsheet/sidebar/MenuTop.vue
+++ b/packages/nc-gui/components/smartsheet/sidebar/MenuTop.vue
@@ -217,6 +217,7 @@ function openDeleteDialog(view: ViewType) {
 
 <template>
   <a-menu ref="menuRef" :class="{ dragging }" class="nc-views-menu flex-1" :selected-keys="selected">
+    <!-- Lazy load breaks menu item active styles, i.e. styles never change even when active item changes -->
     <SmartsheetSidebarRenameableMenuItem
       v-for="view of views"
       :id="view.id"
diff --git a/packages/nc-gui/components/tabs/Smartsheet.vue b/packages/nc-gui/components/tabs/Smartsheet.vue
index db0809d7d7..a8eb191a66 100644
--- a/packages/nc-gui/components/tabs/Smartsheet.vue
+++ b/packages/nc-gui/components/tabs/Smartsheet.vue
@@ -79,6 +79,7 @@ provide(TabMetaInj, activeTab)
       </Transition>
     </div>
 
+    <!-- Lazy loading the sidebar causes issues when deleting elements, i.e. it appears as if multiple elements are removed when they are not -->
     <SmartsheetSidebar v-if="meta" class="nc-right-sidebar" />
   </div>
 </template>