Browse Source

fix: throw err if user is already a project user

pull/2303/head
Wing-Kam Wong 3 years ago
parent
commit
f695304318
  1. 12
      packages/nocodb/src/lib/meta/api/projectUserApis.ts

12
packages/nocodb/src/lib/meta/api/projectUserApis.ts

@ -52,24 +52,32 @@ async function userInvite(req, res, next): Promise<any> {
for (const email of emails) { for (const email of emails) {
// add user to project if user already exist // add user to project if user already exist
const user = await User.getByEmail(email); const user = await User.getByEmail(email);
if (user) { if (user) {
// check if this user has been added to this project
const projectUser = await ProjectUser.get(req.params.projectId, user.id);
if (projectUser) {
NcError.badRequest(
`${user.email} has been added to this project already`
);
}
// todo : provide a different role // todo : provide a different role
await User.update(user.id, { await User.update(user.id, {
roles: 'user' roles: 'user'
}); });
if (!(await ProjectUser.get(req.params.projectId, user.id))) {
await ProjectUser.insert({ await ProjectUser.insert({
project_id: req.params.projectId, project_id: req.params.projectId,
fk_user_id: user.id, fk_user_id: user.id,
roles: req.body.roles || 'editor' roles: req.body.roles || 'editor'
}); });
}
const cachedUser = await NocoCache.get( const cachedUser = await NocoCache.get(
`${CacheScope.USER}:${email}___${req.params.projectId}`, `${CacheScope.USER}:${email}___${req.params.projectId}`,
CacheGetType.TYPE_OBJECT CacheGetType.TYPE_OBJECT
); );
if (cachedUser) { if (cachedUser) {
cachedUser.roles = req.body.roles || 'editor'; cachedUser.roles = req.body.roles || 'editor';
await NocoCache.set( await NocoCache.set(

Loading…
Cancel
Save