refactor: improvements

packages/nc-gui/components/workspace/integrations/forms/EditOrAddDatabase.vue

@@ -367,10 +367,10 @@ const testConnection = async (retry = 0, initialConfig = null) => {
   }
 }
 
-async function handleConnectionError(e: any, retry: number, initialConfig: any): Promise<void> {
+const MAX_CONNECTION_RETRIES = 3
-  const MAX_RETRIES = 3
 
-  if (retry >= MAX_RETRIES) {
+async function handleConnectionError(e: any, retry: number, initialConfig: any): Promise<void> {
+  if (retry >= MAX_CONNECTION_RETRIES) {
     testSuccess.value = false
     testConnectionError.value = await extractSdkResponseErrorMsg(e)
     // reset the connection config to initial state

packages/nc-gui/utils/baseCreateUtils.ts

@@ -223,8 +223,7 @@ enum CertTypes {
   key = 'key',
 }
 
-function generateConfigFix(e: any) {
+const errorHandlers = [
-  const errorHandlers = [
   {
     messages: ['unable to get local issuer certificate', 'self signed certificate in certificate chain'],
     codes: ['UNABLE_TO_GET_ISSUER_CERT_LOCALLY', 'SELF_SIGNED_CERT_IN_CHAIN'],
@@ -254,16 +253,17 @@ function generateConfigFix(e: any) {
       },
     },
   },
-  ]
+]
 
+function generateConfigFix(e: any) {
   for (const handler of errorHandlers) {
     const errorMessage = e?.response?.data?.msg
     const errorCode = e?.response?.data?.sql_code
 
-    if (!errorMessage || !errorCode) return
+    if (!errorMessage && !errorCode) return
 
-    const messageMatches = handler.messages.some((msg) => errorMessage?.includes?.(msg))
+    const messageMatches = errorMessage && handler.messages.some((msg) => errorMessage?.includes?.(msg))
-    const codeMatches = handler.codes.includes(errorCode)
+    const codeMatches = errorCode && handler.codes.includes(errorCode)
 
     if (messageMatches || codeMatches) {
       return handler.action