qr code: code cleanups

packages/nc-gui/components/smartsheet/Form.vue

@@ -75,7 +75,6 @@ const { syncLTARRefs, row } = useProvideSmartsheetRowStore(
   }),
 )
 
-// const columns = computed(() => meta?.value?.columns?.filter((col) => col.uidt !== UITypes.QrCode) || [])
 const columns = computed(() => meta?.value?.columns || [])
 
 const localColumns = ref<Record<string, any>[]>([])
@@ -259,7 +258,6 @@ async function checkSMTPStatus() {
 }
 
 function setFormData() {
-  // const col = formColumnData?.value?.filter((c) => c.uidt !== UITypes.QrCode) || []
   const col = formColumnData?.value || []
 
   formViewData.value = {

packages/nc-gui/components/smartsheet/column/QrCodeOptions.vue

@@ -6,6 +6,7 @@ import { useVModel } from '#imports'
 const props = defineProps<{
   modelValue: any
 }>()
+
 const emit = defineEmits(['update:modelValue'])
 
 const meta = inject(MetaInj, ref())
@@ -53,22 +54,14 @@ setAdditionalValidations({
 <template>
   <a-row>
     <a-col :span="24">
-      <div class="nc-fields-list py-1">
+      <a-form-item class="flex w-1/2 pb-2" :label="$t('labels.qrCodeValueColumn')" v-bind="validateInfos.fk_qr_value_column_id">
-        <div class="grouping-field">
+        <a-select
-          <a-form-item
+          v-model:value="vModel.fk_qr_value_column_id"
-            class="flex w-1/2 pb-2"
+          :options="columnsAllowedAsQrValue"
-            :label="$t('labels.qrCodeValueColumn')"
+          placeholder="Select a column for the QR code value"
-            v-bind="validateInfos.fk_qr_value_column_id"
+          @click.stop
-          >
+        />
-            <a-select
+      </a-form-item>
-              v-model:value="vModel.fk_qr_value_column_id"
-              :options="columnsAllowedAsQrValue"
-              placeholder="Select a column for the QR code value"
-              @click.stop
-            />
-          </a-form-item>
-        </div>
-      </div>
     </a-col>
   </a-row>
 </template>

packages/nc-gui/components/virtual-cell/QrCode.vue

@@ -4,14 +4,17 @@ import { useQRCode } from '@vueuse/integrations/useQRCode'
 const cellValue = inject(CellValueInj)
 
 const qrValue = computed(() => String(cellValue?.value))
+
 const qrCode = useQRCode(qrValue, {
   width: 150,
 })
+
 const qrCodeLarge = useQRCode(qrValue, {
   width: 600,
 })
 
 const modalVisible = ref(false)
+
 const showQrModal = (ev: MouseEvent) => {
   ev.stopPropagation()
   modalVisible.value = true