Browse Source

fix/Formatter fix and added pr suggestions

pull/2641/head
Muhammed Mustafa 2 years ago
parent
commit
e39575bbe6
  1. 27
      packages/nc-gui/components/FeedbackForm.vue
  2. 2
      packages/nocodb/src/lib/meta/api/utilApis.ts

27
packages/nc-gui/components/FeedbackForm.vue

@ -1,16 +1,8 @@
<template> <template>
<div v-if="!feedbackFormHidden" class="nc-feedback-form-wrapper"> <div v-if="!feedbackFormHidden" class="nc-feedback-form-wrapper">
<v-icon class="nc-close-icon" large @click="feedbackFormHidden = true"> <v-icon class="nc-close-icon" large @click="feedbackFormHidden = true"> mdi-close-circle-outline </v-icon>
mdi-close-circle-outline
</v-icon>
<iframe <iframe :src="feedbackFormUrl" width="100%" height="500" frameborder="0" marginheight="0" marginwidth="0"
:src="feedbackFormUrl"
width="100%"
height="500"
frameborder="0"
marginheight="0"
marginwidth="0"
>Loading >Loading
</iframe> </iframe>
</div> </div>
@ -23,18 +15,17 @@ export default {
computed: { computed: {
feedbackFormHidden: { feedbackFormHidden: {
get() { get() {
return this.$store.state.settings.feedbackForm.isShown return this.$store.state.settings.feedbackForm.isShown;
}, },
set(isShown) { set(isShown) {
this.$store.commit( this.$store.commit('settings/MutFeedbackForm', { ...this.$store.state.settings.feedbackForm, isShown });
'settings/MutFeedbackForm', { ...this.$store.state.settings.feedbackForm, isShown }) },
}
}, },
feedbackFormUrl() { feedbackFormUrl() {
return this.$store.state.settings.feedbackForm.url return this.$store.state.settings.feedbackForm.url;
} },
} },
} };
</script> </script>
<style scoped lang="scss"> <style scoped lang="scss">

2
packages/nocodb/src/lib/meta/api/utilApis.ts

@ -61,7 +61,7 @@ export async function releaseVersion(_req: Request, res: Response) {
} }
export async function getFeedbackForm(_req: Request, res: Response) { export async function getFeedbackForm(_req: Request, res: Response) {
await axios axios
.get('https://nocodb.com/api/v1/feedback_form') .get('https://nocodb.com/api/v1/feedback_form')
.then((response) => { .then((response) => {
res.json(response.data); res.json(response.data);

Loading…
Cancel
Save