Browse Source

fix(nc-gui): PR review changes #2404

pull/7729/head
Ramesh Mane 10 months ago
parent
commit
d3b70666e2
  1. 1
      packages/nc-gui/components/general/ImageCropper.vue
  2. 10
      packages/nc-gui/components/smartsheet/Form.vue
  3. 2
      packages/nc-gui/lang/en.json

1
packages/nc-gui/components/general/ImageCropper.vue

@ -110,7 +110,6 @@ watch(showCropper, () => {
} }
: {} : {}
" "
image-restriction="none"
/> />
<div v-if="previewImage.src" class="result_preview"> <div v-if="previewImage.src" class="result_preview">
<img :src="previewImage.src" alt="Preview Image" /> <img :src="previewImage.src" alt="Preview Image" />

10
packages/nc-gui/components/smartsheet/Form.vue

@ -694,9 +694,9 @@ useEventListener(
@submit="handleOnUploadImage" @submit="handleOnUploadImage"
></GeneralImageCropper> ></GeneralImageCropper>
<!-- cover image --> <!-- cover image -->
<div class="relative max-w-[max(33%,688px)] mx-auto"> <div class="group relative max-w-[max(33%,688px)] mx-auto">
<GeneralFormBanner :banner-image-url="formViewData.banner_image_url"/> <GeneralFormBanner :banner-image-url="formViewData.banner_image_url"/>
<div class="absolute bottom-0 right-0"> <div class="absolute bottom-0 right-0 hidden group-hover:block">
<div class="flex items-center space-x-1 m-2"> <div class="flex items-center space-x-1 m-2">
<NcButton <NcButton
type="secondary" type="secondary"
@ -750,8 +750,8 @@ useEventListener(
<!-- Form logo --> <!-- Form logo -->
<div class="mb-4"> <div class="mb-4">
<div <div
class="nc-form-logo-wrapper mx-6 group relative rounded-xl inline-block h-56px max-w-189px overflow-hidden" class="nc-form-logo-wrapper mx-6 group relative rounded-xl inline-block h-56px overflow-hidden"
:class="formViewData.logo_url ? 'hover:(w-full bg-gray-100)' : 'bg-gray-100'" :class="formViewData.logo_url ? 'hover:(w-full bg-gray-100) max-w-189px' : 'w-full bg-gray-100 max-w-148px'"
style="transition: all 0.3s ease-in" style="transition: all 0.3s ease-in"
> >
<LazyCellAttachmentImage <LazyCellAttachmentImage
@ -761,7 +761,7 @@ useEventListener(
/> />
<div <div
class="items-center space-x-1 flex-nowrap m-3" class="items-center space-x-1 flex-nowrap m-3"
:class="formViewData.logo_url ? 'hidden absolute top-0 left-0 group-hover:flex' : 'flex'" :class="'hidden absolute top-0 left-0 group-hover:flex'"
> >
<NcButton <NcButton
v-if="isEditable" v-if="isEditable"

2
packages/nc-gui/lang/en.json

@ -697,7 +697,7 @@
"hideNocodbBranding":"Hide NocoDB Branding", "hideNocodbBranding":"Hide NocoDB Branding",
"showOnConditions": "Show on condtions", "showOnConditions": "Show on condtions",
"showFieldOnConditionsMet":"Shows field only when conditions are met", "showFieldOnConditionsMet":"Shows field only when conditions are met",
"limitOptions": "Limit ptions", "limitOptions": "Limit options",
"limitOptionsSubtext": "Limit options visible to users by selecting available options", "limitOptionsSubtext": "Limit options visible to users by selecting available options",
"clearSelection": "Clear selection" "clearSelection": "Clear selection"
}, },

Loading…
Cancel
Save