Browse Source

fix(nocodb): incorrect switch break statement in column delete service

pull/7722/head
Ramesh Mane 9 months ago
parent
commit
d2e9df874c
  1. 4
      packages/nocodb/src/services/columns.service.ts

4
packages/nocodb/src/services/columns.service.ts

@ -2256,13 +2256,11 @@ export class ColumnsService {
break; break;
} }
case UITypes.SingleSelect: { case UITypes.SingleSelect: {
if (column.uidt === UITypes.SingleSelect) {
if (await KanbanView.IsColumnBeingUsedAsGroupingField(column.id)) { if (await KanbanView.IsColumnBeingUsedAsGroupingField(column.id)) {
NcError.badRequest( NcError.badRequest(
`The column '${column.column_name}' is being used in Kanban View. Please delete Kanban View first.`, `The column '${column.column_name}' is being used in Kanban View. Please delete Kanban View first.`,
); );
} }
}
/* falls through to default */ /* falls through to default */
} }
case UITypes.DateTime: case UITypes.DateTime:
@ -2272,7 +2270,7 @@ export class ColumnsService {
`The column '${column.column_name}' is being used in Calendar View. Please delete Calendar View first.`, `The column '${column.column_name}' is being used in Calendar View. Please delete Calendar View first.`,
); );
} }
break; /* falls through to default */
} }
// on deleting created/last modified columns, keep the column in table and delete the column from meta // on deleting created/last modified columns, keep the column in table and delete the column from meta

Loading…
Cancel
Save