Merge pull request #3444 from nocodb/enhancement/search-mismatch

enhancement: add try catch for covering search mismatch type

packages/nocodb/src/lib/meta/api/dataApis/dataAliasApis.ts

@@ -107,14 +107,20 @@ async function getDataList(model, view: View, req) {
     listArgs.sortArr = JSON.parse(listArgs.sortArrJson);
   } catch (e) {}
 
-  const data = await nocoExecute(
+  let data = [];
-    requestObj,
+  let count = 0;
-    await baseModel.list(listArgs),
+  try {
-    {},
+    data = await nocoExecute(
-    listArgs
+      requestObj,
-  );
+      await baseModel.list(listArgs),
-
+      {},
-  const count = await baseModel.count(listArgs);
+      listArgs
+    );
+    count = await baseModel.count(listArgs);
+  } catch (e) {
+    // show empty result instead of throwing error here
+    // e.g. search some text in a numeric field
+  }
 
   return new PagedResponseImpl(data, {
     ...req.query,

packages/nocodb/src/lib/meta/api/dataApis/dataApis.ts

@@ -452,14 +452,20 @@ async function getDataList(model, view: View, req) {
     listArgs.sortArr = JSON.parse(listArgs.sortArrJson);
   } catch (e) {}
 
-  const data = await nocoExecute(
+  let data = [];
-    requestObj,
+  let count = 0;
-    await baseModel.list(listArgs),
+  try {
-    {},
+    data = await nocoExecute(
-    listArgs
+      requestObj,
-  );
+      await baseModel.list(listArgs),
-
+      {},
-  const count = await baseModel.count(listArgs);
+      listArgs
+    );
+    count = await baseModel.count(listArgs);
+  } catch (e) {
+    // show empty result instead of throwing error here
+    // e.g. search some text in a numeric field
+  }
 
   return new PagedResponseImpl(data, {
     count,

packages/nocodb/src/lib/meta/api/publicApis/publicDataApis.ts

@@ -50,18 +50,25 @@ export async function dataList(req: Request, res: Response) {
       listArgs.sortArr = JSON.parse(listArgs.sortArrJson);
     } catch (e) {}
 
-    const data = await nocoExecute(
+    let data = [];
-      await getAst({
+    let count = 0;
-        query: req.query,
-        model,
-        view,
-      }),
-      await baseModel.list(listArgs),
-      {},
-      listArgs
-    );
 
-    const count = await baseModel.count(listArgs);
+    try {
+      data = await nocoExecute(
+        await getAst({
+          query: req.query,
+          model,
+          view,
+        }),
+        await baseModel.list(listArgs),
+        {},
+        listArgs
+      );
+      count = await baseModel.count(listArgs);
+    } catch (e) {
+      // show empty result instead of throwing error here
+      // e.g. search some text in a numeric field
+    }
 
     res.json({
       data: new PagedResponseImpl(data, { ...req.query, count }),
@@ -198,14 +205,20 @@ async function relDataList(req, res) {
     extractOnlyPrimaries: true,
   });
 
-  const data = await nocoExecute(
+  let data = [];
-    requestObj,
+  let count = 0;
-    await baseModel.list(req.query),
+  try {
-    {},
+    data = data = await nocoExecute(
-    req.query
+      requestObj,
-  );
+      await baseModel.list(req.query),
-
+      {},
-  const count = await baseModel.count(req.query);
+      req.query
+    );
+    count = await baseModel.count(req.query);
+  } catch (e) {
+    // show empty result instead of throwing error here
+    // e.g. search some text in a numeric field
+  }
 
   res.json(new PagedResponseImpl(data, { ...req.query, count }));
 }