Browse Source

refactor(nc-gui): remove watcher from virtual cell icon

pull/3847/head
braks 2 years ago
parent
commit
6bab6a459c
  1. 24
      packages/nc-gui/components/smartsheet/header/VirtualCellIcon.ts

24
packages/nc-gui/components/smartsheet/header/VirtualCellIcon.ts

@ -2,7 +2,7 @@ import type { PropType } from '@vue/runtime-core'
import type { ColumnType, LinkToAnotherRecordType, LookupType } from 'nocodb-sdk'
import type { Ref } from 'vue'
import { RelationTypes, UITypes } from 'nocodb-sdk'
import { ColumnInj, MetaInj, defineComponent, h, inject, isBt, isHm, isLookup, isMm, isRollup, ref, toRef, watch } from '#imports'
import { ColumnInj, MetaInj, defineComponent, h, inject, isBt, isHm, isLookup, isMm, isRollup, ref, toRef } from '#imports'
import GenericIcon from '~icons/mdi/square-rounded'
import HMIcon from '~icons/mdi/table-arrow-right'
import BTIcon from '~icons/mdi/table-arrow-left'
@ -67,21 +67,15 @@ export default defineComponent({
setup(props) {
const columnMeta = toRef(props, 'columnMeta')
const column = inject(ColumnInj, ref(columnMeta)) as Ref<ColumnType & { colOptions: LookupType }>
const column = inject(ColumnInj, columnMeta) as Ref<ColumnType & { colOptions: LookupType }>
let relationColumn: ColumnType & { colOptions: LookupType }
watch(
column,
() => {
return () => {
if (!column.value) return null
if (column && column.value) {
if (
isMm(column.value) ||
isHm(column.value) ||
isBt(column.value) ||
isLookup(column.value) ||
isRollup(column.value)
) {
if (isMm(column.value) || isHm(column.value) || isBt(column.value) || isLookup(column.value) || isRollup(column.value)) {
const meta = inject(MetaInj, ref())
relationColumn = meta.value?.columns?.find(
@ -91,12 +85,6 @@ export default defineComponent({
}
}
}
},
{ immediate: true },
)
return () => {
if (!column.value) return null
const { icon: Icon, color } = renderIcon(column.value, relationColumn)

Loading…
Cancel
Save