fix(gui): apply attachment validation in shared form view

Signed-off-by: Pranav C <pranavxc@gmail.com>

packages/nc-gui/components/cell/attachment/utils.ts

@@ -96,50 +96,13 @@ export const [useProvideAttachmentCell, useAttachmentCell] = useInjectionState(
     async function onFileSelect(selectedFiles: FileList | File[]) {
       if (!selectedFiles.length) return
 
-      if (isPublic.value && isForm.value) {
-        const newFiles = await Promise.all<AttachmentType>(
-          Array.from(selectedFiles).map(
-            (file) =>
-              new Promise<AttachmentType>((resolve) => {
-                const res: { file: File; title: string; mimetype: string; data?: any } = {
-                  ...file,
-                  file,
-                  title: file.name,
-                  mimetype: file.type,
-                }
-
-                if (isImage(file.name, (<any>file).mimetype ?? file.type)) {
-                  const reader = new FileReader()
-
-                  reader.onload = (e) => {
-                    res.data = e.target?.result
-
-                    resolve(res)
-                  }
-
-                  reader.onerror = () => {
-                    resolve(res)
-                  }
-
-                  reader.readAsDataURL(file)
-                } else {
-                  resolve(res)
-                }
-              }),
-          ),
-        )
-        attachments.value = [...attachments.value, ...newFiles]
-
-        return updateModelValue(attachments.value)
-      }
-
-      const newAttachments = []
-
       const attachmentMeta = {
         ...defaultAttachmentMeta,
         ...(typeof column.value?.meta === 'string' ? JSON.parse(column.value.meta) : column.value?.meta),
       }
 
+      const newAttachments = []
+
       const files: File[] = []
 
       for (const file of selectedFiles) {
@@ -173,6 +136,43 @@ export const [useProvideAttachmentCell, useAttachmentCell] = useInjectionState(
         files.push(file)
       }
 
+      if (isPublic.value && isForm.value) {
+        const newFiles = await Promise.all<AttachmentType>(
+          Array.from(files).map(
+            (file) =>
+              new Promise<AttachmentType>((resolve) => {
+                const res: { file: File; title: string; mimetype: string; data?: any } = {
+                  ...file,
+                  file,
+                  title: file.name,
+                  mimetype: file.type,
+                }
+
+                if (isImage(file.name, (<any>file).mimetype ?? file.type)) {
+                  const reader = new FileReader()
+
+                  reader.onload = (e) => {
+                    res.data = e.target?.result
+
+                    resolve(res)
+                  }
+
+                  reader.onerror = () => {
+                    resolve(res)
+                  }
+
+                  reader.readAsDataURL(file)
+                } else {
+                  resolve(res)
+                }
+              }),
+          ),
+        )
+        attachments.value = [...attachments.value, ...newFiles]
+
+        return updateModelValue(attachments.value)
+      }
+
       try {
         const data = await api.storage.upload(
           {

packages/nc-gui/components/smartsheet/Grid.vue

@@ -674,8 +674,7 @@ const closeAddColumnDropdown = () => {
           <thead ref="tableHead">
             <tr class="nc-grid-header border-1 bg-gray-100 sticky top[-1px]">
               <th data-testid="grid-id-column">
-              <div class="w-full h-full bg-gray-100 flex min-w-[70px] pl-5 pr-1 items-center"
-                   data-testid="nc-check-all">
+                <div class="w-full h-full bg-gray-100 flex min-w-[70px] pl-5 pr-1 items-center" data-testid="nc-check-all">
                   <template v-if="!readOnly">
                     <div class="nc-no-label text-gray-500" :class="{ hidden: selectedAllRecords }">#</div>
                     <div
@@ -897,8 +896,7 @@ const closeAddColumnDropdown = () => {
               </div>
             </a-menu-item>
 
-            <a-menu-item v-if="contextMenuTarget" data-testid="context-menu-item-copy"
-                         @click="copyValue(contextMenuTarget)">
+            <a-menu-item v-if="contextMenuTarget" data-testid="context-menu-item-copy" @click="copyValue(contextMenuTarget)">
               <div v-e="['a:row:copy']" class="nc-project-menu-item">
                 <!-- Copy -->
                 {{ $t('general.copy') }}