Browse Source

refactor: avoid unnecessary nested if condition

pull/7246/head
Pranav C 11 months ago
parent
commit
69effe3033
  1. 14
      packages/nocodb/src/helpers/webhookHelpers.ts

14
packages/nocodb/src/helpers/webhookHelpers.ts

@ -307,17 +307,16 @@ export async function invokeWebhook(
const data = newData[i]; const data = newData[i];
const prevData = prevData ? prevData[i] : null; const prevData = prevData ? prevData[i] : null;
if (prevData) {
// if condition is satisfied for prevData then return // if condition is satisfied for prevData then return
if ( if (
await validateCondition( prevData &&
(await validateCondition(
testFilters || (await hook.getFilters()), testFilters || (await hook.getFilters()),
prevData, prevData,
) ))
) { ) {
continue; continue;
} }
}
if ( if (
await validateCondition( await validateCondition(
testFilters || (await hook.getFilters()), testFilters || (await hook.getFilters()),
@ -332,17 +331,16 @@ export async function invokeWebhook(
} }
newData = filteredData; newData = filteredData;
} else { } else {
if (prevData) {
// if condition is satisfied for prevData then return // if condition is satisfied for prevData then return
if ( if (
await validateCondition( prevData &&
(await validateCondition(
testFilters || (await hook.getFilters()), testFilters || (await hook.getFilters()),
prevData, prevData,
) ))
) { ) {
return; return;
} }
}
if ( if (
!(await validateCondition( !(await validateCondition(
testFilters || (await hook.getFilters()), testFilters || (await hook.getFilters()),

Loading…
Cancel
Save