Merge branch 'develop' into fix/link

packages/nc-gui/components/dashboard/Sidebar/UserInfo.vue

@@ -26,7 +26,8 @@ const logout = async () => {
   try {
     await signOut(false)
 
-    await clearWorkspaces()
+    // No need as all stores are cleared on signout
+    // await clearWorkspaces()
 
     await navigateTo('/signin')
   } catch (e) {

packages/nc-gui/components/dashboard/TreeView/ViewsList.vue

@@ -45,7 +45,7 @@ const isDefaultBase = computed(() => {
   return _isDefaultBase(base)
 })
 
-const { viewsByTable, activeView } = storeToRefs(useViewsStore())
+const { viewsByTable, activeView, recentViews } = storeToRefs(useViewsStore())
 
 const { navigateToTable } = useTablesStore()
 
@@ -57,7 +57,7 @@ const { refreshCommandPalette } = useCommandPalette()
 
 const { addUndo, defineModelScope } = useUndoRedo()
 
-const { navigateToView, loadViews } = useViewsStore()
+const { navigateToView, loadViews, removeFromRecentViews } = useViewsStore()
 
 /** Selected view(s) for menu */
 const selected = ref<string[]>([])
@@ -244,6 +244,13 @@ async function onRename(view: ViewType, originalTitle?: string, undo = false) {
         scope: defineModelScope({ view: activeView.value }),
       })
     }
+    // update view name in recent views
+    recentViews.value = recentViews.value.map((rv) => {
+      if (rv.viewId === view.id && rv.tableID === view.fk_model_id) {
+        rv.viewName = view.title
+      }
+      return rv
+    })
 
     // View renamed successfully
     // message.success(t('msg.success.viewRenamed'))
@@ -265,6 +272,7 @@ function openDeleteDialog(view: ViewType) {
 
       emits('deleted')
 
+      removeFromRecentViews({ viewId: view.id, tableId: view.fk_model_id, projectId: project.value.id })
       refreshCommandPalette()
       if (activeView.value?.id === view.id) {
         navigateToTable({

packages/nc-gui/components/dlg/ProjectDelete.vue

@@ -14,6 +14,8 @@ const projectsStore = useProjects()
 const { deleteProject, navigateToFirstProjectOrHome } = projectsStore
 const { projects } = storeToRefs(projectsStore)
 
+const { removeFromRecentViews } = useViewsStore()
+
 const { refreshCommandPalette } = useCommandPalette()
 
 const project = computed(() => projects.value.get(props.projectId))
@@ -41,6 +43,7 @@ const onDelete = async () => {
     message.error(await extractSdkResponseErrorMsg(e))
   } finally {
     isLoading.value = false
+    removeFromRecentViews({ projectId: toBeDeletedProject.id! })
   }
 }
 </script>

packages/nc-gui/components/dlg/TableDelete.vue

@@ -20,6 +20,7 @@ const { getMeta, removeMeta } = useMetas()
 const { loadTables, projectUrl, isXcdbBase } = useProject()
 const { refreshCommandPalette } = useCommandPalette()
 
+const { removeFromRecentViews } = useViewsStore()
 const { projectTables, activeTable } = storeToRefs(useTablesStore())
 const { openTable } = useTablesStore()
 
@@ -69,6 +70,9 @@ const onDelete = async () => {
 
     await loadTables()
 
+    // Remove from recent views
+    removeFromRecentViews({ projectId: props.projectId, tableId: toBeDeletedTable.id as string })
+
     removeMeta(toBeDeletedTable.id as string)
     refreshCommandPalette()
     // Deleted table successfully

packages/nc-gui/components/smartsheet/Cell.vue

@@ -22,6 +22,7 @@ import {
   isDate,
   isDateTime,
   isDecimal,
+  isDrawerExist,
   isDuration,
   isEmail,
   isFloat,
@@ -207,7 +208,7 @@ onUnmounted(() => {
         'h-10': isForm && !isSurveyForm && !isAttachment(column) && !props.virtual,
         'nc-grid-numeric-cell-left': (isForm && isNumericField && isExpandedFormOpen) || isEditColumnMenu,
         '!min-h-30 resize-y': isTextArea(column) && (isForm || isSurveyForm),
-        '!border-2 !border-brand-500': props.editEnabled && (isSurveyForm || isForm),
+        '!border-2 !border-brand-500': props.editEnabled && (isSurveyForm || isForm) && !isDrawerExist(),
       },
     ]"
     @keydown.enter.exact="navigate(NavigateDir.NEXT, $event)"

packages/nc-gui/components/smartsheet/column/EditOrAdd.vue

@@ -228,7 +228,7 @@ if (props.fromTableExplorer) {
       <div class="flex flex-col gap-2">
         <a-form-item v-if="isFieldsTab" v-bind="validateInfos.title" class="flex flex-grow">
           <div
-            class="flex flex-grow px-2 py-1 items-center rounded-lg bg-white hover:bg-gray-100 focus:bg-gray-100 outline-none"
+            class="flex flex-grow px-2 py-1 items-center rounded-lg bg-gray-100 focus:bg-gray-100 outline-none"
             style="outline-style: solid; outline-width: thin"
           >
             <input

packages/nc-gui/components/smartsheet/details/Fields.vue

@@ -88,7 +88,7 @@ const getFieldOrder = (field?: TableExplorerColumn) => {
 
 const fields = computed<TableExplorerColumn[]>({
   get: () => {
-    const x = (meta.value?.columns as ColumnType[])
+    const x = ((meta.value?.columns as ColumnType[]) ?? [])
       .filter((field) => !field.fk_column_id && !isSystemColumn(field))
       .concat(newFields.value)
       .sort((a, b) => {
@@ -252,13 +252,30 @@ const duplicateField = async (field: TableExplorerColumn) => {
 const onFieldUpdate = (state: TableExplorerColumn) => {
   const col = fields.value.find((col) => compareCols(col, state))
   if (!col) return
-
   const diffs = diff(col, state)
   if (Object.keys(diffs).length === 0 || (Object.keys(diffs).length === 1 && 'altered' in diffs)) {
     ops.value = ops.value.filter((op) => op.op === 'add' || !compareCols(op.column, state))
   } else {
     const field = ops.value.find((op) => compareCols(op.column, state))
-    if (field) {
+    const moveField = moveOps.value.find((op) => compareCols(op.column, state))
+    const isNewField = newFields.value.find((nField) => compareCols(nField, state))
+
+    if (isNewField) {
+      newFields.value = newFields.value.map((op) => {
+        if (compareCols(op, state)) {
+          ops.value = ops.value.filter((op) => op.op === 'add' && !compareCols(op.column, state))
+          ops.value.push({
+            op: 'add',
+            column: state,
+          })
+          return state
+        }
+        return op
+      })
+      return
+    }
+
+    if (field && !moveField) {
       field.column = state
     } else {
       ops.value.push({
@@ -326,11 +343,22 @@ const onFieldAdd = (state: TableExplorerColumn) => {
 }
 
 const onMove = (_event: { moved: { newIndex: number; oldIndex: number } }) => {
-  const order = calculateOrderForIndex(_event.moved.newIndex, _event.moved.newIndex < _event.moved.oldIndex)
-
   const field = fields.value[_event.moved.oldIndex]
+  const order = calculateOrderForIndex(_event.moved.newIndex, _event.moved.newIndex < _event.moved.oldIndex)
 
   const op = ops.value.find((op) => compareCols(op.column, field))
+  if (op?.op === 'update') {
+    const diffs = diff(op.column, field)
+    if (!(Object.keys(diffs).length === 1 && 'column_order' in diffs)) {
+      message.warning('You cannot move field that is being edited. Either save or discard changes first')
+      return
+    }
+  }
+
+  if (op?.op === 'delete') {
+    message.warning('You cannot move field that is deleted. Either save or discard changes first')
+    return
+  }
 
   if (op) {
     onFieldUpdate({
@@ -364,6 +392,36 @@ const onMove = (_event: { moved: { newIndex: number; oldIndex: number } }) => {
   }
 }
 
+const isColumnValid = (column: TableExplorerColumn) => {
+  const isDeleteOp = ops.value.find((op) => compareCols(column, op.column) && op.op === 'delete')
+  const isNew = ops.value.find((op) => compareCols(column, op.column) && op.op === 'add')
+  if (isDeleteOp) return true
+  if (!column.title) {
+    return false
+  }
+  if ((column.uidt === UITypes.Links || column.uidt === UITypes.LinkToAnotherRecord) && isNew) {
+    if (!column.childColumn || !column.childTable || !column.childId) {
+      return false
+    }
+  }
+  if (column.uidt === UITypes.Lookup && isNew) {
+    if (!column.fk_relation_column_id || !column.fk_lookup_column_id) {
+      return false
+    }
+  }
+  if (column.uidt === UITypes.Rollup && isNew) {
+    if (!column.fk_relation_column_id || !column.fk_rollup_column_id || !column.rollup_function) {
+      return false
+    }
+  }
+  if (column.uidt === UITypes.Formula && isNew) {
+    if (!column.formula_raw) {
+      return false
+    }
+  }
+  return true
+}
+
 const recoverField = (state: TableExplorerColumn) => {
   const field = ops.value.find((op) => compareCols(op.column, state))
   if (field) {
@@ -371,6 +429,7 @@ const recoverField = (state: TableExplorerColumn) => {
       ops.value = ops.value.filter((op) => !compareCols(op.column, state))
     } else if (field.op === 'update') {
       ops.value = ops.value.filter((op) => !compareCols(op.column, state))
+      moveOps.value = moveOps.value.filter((op) => !compareCols(op.column, state))
     }
     activeField.value = null
     changeField(fields.value.filter((fiel) => fiel.id === state.id)[0])
@@ -447,17 +506,18 @@ const saveChanges = async () => {
       }
     }
 
-    const res = await $api.dbTableColumn.bulk(meta.value?.id, {
-      hash: columnsHash.value,
-      ops: ops.value,
-    })
-
     for (const op of visibilityOps.value) {
       await toggleFieldVisibility(op.visible, {
         ...op.column,
         show: op.visible,
       })
     }
+
+    const res = await $api.dbTableColumn.bulk(meta.value?.id, {
+      hash: columnsHash.value,
+      ops: ops.value,
+    })
+
     await loadViewColumns()
 
     if (res) {
@@ -502,6 +562,8 @@ const toggleVisibility = async (checked: boolean, field: Field) => {
   })
 }
 
+const isColumnsValid = computed(() => fields.value.every((f) => isColumnValid(f)))
+
 onMounted(async () => {
   if (!meta.value?.id) return
   columnsHash.value = (await $api.dbTableColumn.hash(meta.value?.id)).hash
@@ -509,25 +571,29 @@ onMounted(async () => {
 </script>
 
 <template>
-  <div class="flex flex-col items-center w-full p-4" style="height: calc(100vh - (var(--topbar-height) * 2))">
+  <div class="w-full p-4">
-    <div class="h-full max-w-250 w-full">
+    <div class="max-w-250 h-full w-full mx-auto">
-      <div class="flex flex-col h-full">
       <div class="flex w-full justify-between py-2">
-          <div class="flex flex-1 items-center gap-2">
+        <a-input v-model:value="searchQuery" class="!h-8 !px-1 !rounded-lg !w-72" placeholder="Search field">
-            <h1 class="font-bold text-base">Fields</h1>
+          <template #prefix>
-            <div class="flex bg-gray-100 items-center mb-1.5 rounded-lg px-2">
+            <GeneralIcon icon="search" class="mx-1 h-3.5 w-3.5 text-gray-500 group-hover:text-black" />
-              <LazyGeneralEmojiPicker :emoji="selectedView?.meta?.icon" readonly size="xsmall">
-                <template #default>
-                  <GeneralViewIcon :meta="{ type: selectedView?.type }" class="min-w-4.5 text-lg flex" />
           </template>
-              </LazyGeneralEmojiPicker>
+          <template #suffix>
-
+            <GeneralIcon
-              <span class="text-sm pl-1.25 text-gray-700">
+              v-if="searchQuery.length > 0"
-                {{ selectedView?.title }}
+              icon="close"
-              </span>
+              class="mx-1 h-3.5 w-3.5 text-gray-500 group-hover:text-black"
-            </div>
+              @click="searchQuery = ''"
-          </div>
+            />
+          </template>
+        </a-input>
         <div class="flex gap-2">
+          <NcButton type="secondary" size="small" class="mr-1" :disabled="loading" @click="addField()">
+            <div class="flex items-center gap-2">
+              <GeneralIcon icon="plus" class="h-3.5 mb-1 w-3.5" />
+              New field
+            </div>
+          </NcButton>
           <NcButton
             type="secondary"
             size="small"
@@ -540,42 +606,20 @@ onMounted(async () => {
             type="primary"
             size="small"
             :loading="loading"
-              :disabled="!loading && ops.length < 1 && moveOps.length < 1 && visibilityOps.length < 1"
+            :disabled="isColumnsValid ? !loading && ops.length < 1 && moveOps.length < 1 && visibilityOps.length < 1 : true"
             @click="saveChanges()"
           >
             Save changes
           </NcButton>
         </div>
       </div>
-
+      <div class="flex flex-row rounded-lg border-1 border-gray-200">
-        <div class="flex gap-x-4 overflow-y-auto">
+        <div class="nc-scrollbar-md !overflow-auto w-full flex-grow-1 nc-fields-height">
-          <div class="flex flex-col flex-1 nc-scrollbar-md">
-            <div class="flex w-full justify-between pb-2 pr-1">
-              <a-input v-model:value="searchQuery" class="!h-8 !px-1 !rounded-lg !w-3/6" placeholder="Search field">
-                <template #prefix>
-                  <GeneralIcon icon="search" class="mx-1 h-3.5 w-3.5 text-gray-500 group-hover:text-black" />
-                </template>
-                <template #suffix>
-                  <GeneralIcon
-                    v-if="searchQuery.length > 0"
-                    icon="close"
-                    class="mx-1 h-3.5 w-3.5 text-gray-500 group-hover:text-black"
-                    @click="searchQuery = ''"
-                  />
-                </template>
-              </a-input>
-              <NcButton type="secondary" size="small" :disabled="loading" @click="addField()">
-                <div class="flex items-center gap-2">
-                  <GeneralIcon icon="plus" class="h-3.5 mb-1 w-3.5" />
-                  New field
-                </div>
-              </NcButton>
-            </div>
           <Draggable v-model="fields" item-key="id" @change="onMove($event)">
             <template #item="{ element: field }">
               <div
-                  v-if="field.title && field.title.toLowerCase().includes(searchQuery.toLowerCase()) && !field.pv"
+                v-if="field.title.toLowerCase().includes(searchQuery.toLowerCase()) && !field.pv"
-                  class="flex px-2 mr-1 border-x-1 bg-white border-t-1 hover:bg-gray-100 first:rounded-t-lg last:border-b-1 last:rounded-b-lg pl-5 group"
+                class="flex px-2 hover:bg-gray-100 first:rounded-t-lg border-b-1 last:rounded-b-none border-gray-200 pl-5 group"
                 :class="` ${compareCols(field, activeField) ? 'selected' : ''}`"
                 @click="changeField(field, $event)"
               >
@@ -631,6 +675,14 @@ onMounted(async () => {
                     >
                       Updated field
                     </NcBadge>
+                    <NcBadge
+                      v-if="!isColumnValid(field)"
+                      color="yellow"
+                      :border="false"
+                      class="ml-1 bg-yellow-50 text-yellow-700"
+                    >
+                      Incomplete configuration
+                    </NcBadge>
                   </div>
                   <NcButton
                     v-if="fieldStatus(field) === 'delete' || fieldStatus(field) === 'update'"
@@ -645,38 +697,32 @@ onMounted(async () => {
                       Restore
                     </div>
                   </NcButton>
-                    <a-dropdown v-else :trigger="['click']" overlay-class-name="nc-dropdown-table-explorer" @click.stop>
+                  <NcDropdown v-else :trigger="['click']" overlay-class-name="nc-dropdown-table-explorer" @click.stop>
                     <GeneralIcon icon="threeDotVertical" class="no-action opacity-0 group-hover:(opacity-100) text-gray-500" />
 
                     <template #overlay>
-                        <a-menu>
+                      <NcMenu>
-                          <a-menu-item key="table-explorer-duplicate" @click="duplicateField(field)">
+                        <NcMenuItem key="table-explorer-duplicate" @click="duplicateField(field)">
-                            <div class="nc-project-menu-item">
                           <Icon class="iconify text-gray-800" icon="lucide:copy" /><span>Duplicate</span>
-                            </div>
+                        </NcMenuItem>
-                          </a-menu-item>
+                        <NcMenuItem v-if="!field.pv" key="table-explorer-insert-above" @click="addField(field, true)">
-                          <a-menu-item v-if="!field.pv" key="table-explorer-insert-above" @click="addField(field, true)">
-                            <div class="nc-project-menu-item">
                           <Icon class="iconify text-gray-800" icon="lucide:arrow-up" /><span>Insert above</span>
-                            </div>
+                        </NcMenuItem>
-                          </a-menu-item>
+                        <NcMenuItem key="table-explorer-insert-below" @click="addField(field)">
-                          <a-menu-item key="table-explorer-insert-below" @click="addField(field)">
-                            <div class="nc-project-menu-item">
                           <Icon class="iconify text-gray-800" icon="lucide:arrow-down" /><span>Insert below</span>
-                            </div>
+                        </NcMenuItem>
-                          </a-menu-item>
 
-                          <a-menu-divider class="my-0" />
+                        <a-menu-divider class="my-1" />
 
-                          <a-menu-item key="table-explorer-delete" @click="onFieldDelete(field)">
+                        <NcMenuItem key="table-explorer-delete" @click="onFieldDelete(field)">
-                            <div class="nc-project-menu-item group text-red-500">
+                          <div class="text-red-500">
                             <GeneralIcon icon="delete" class="group-hover:text-accent" />
                             Delete
                           </div>
-                          </a-menu-item>
+                        </NcMenuItem>
-                        </a-menu>
+                      </NcMenu>
                     </template>
-                    </a-dropdown>
+                  </NcDropdown>
                   <MdiChevronRight
                     class="text-brand-500 opacity-0"
                     :class="{
@@ -688,7 +734,7 @@ onMounted(async () => {
             </template>
             <template v-if="displayColumn && displayColumn.title.toLowerCase().includes(searchQuery.toLowerCase())" #header>
               <div
-                  class="flex px-2 mr-1 border-x-1 bg-white border-t-1 hover:bg-gray-100 first:rounded-t-lg last:border-b-1 last:rounded-b-lg pl-5 group"
+                class="flex px-2 bg-white hover:bg-gray-100 border-b-1 border-gray-200 first:rounded-tl-lg last:border-b-1 pl-5 group"
                 :class="` ${compareCols(displayColumn, activeField) ? 'selected' : ''}`"
                 @click="changeField(displayColumn, $event)"
               >
@@ -743,38 +789,6 @@ onMounted(async () => {
                       Restore
                     </div>
                   </NcButton>
-                    <a-dropdown v-else :trigger="['click']" overlay-class-name="nc-dropdown-table-explorer" @click.stop>
-                      <GeneralIcon icon="threeDotVertical" class="no-action opacity-0 group-hover:(opacity-100) text-gray-500" />
-
-                      <template #overlay>
-                        <a-menu>
-                          <a-menu-item key="table-explorer-duplicate" @click="duplicateField(displayColumn)">
-                            <div class="nc-project-menu-item">
-                              <Icon class="iconify text-gray-800" icon="lucide:copy" /><span>Duplicate</span>
-                            </div>
-                          </a-menu-item>
-                          <a-menu-item v-if="!field.pv" key="table-explorer-insert-above" @click="addField(displayColumn, true)">
-                            <div class="nc-project-menu-item">
-                              <Icon class="iconify text-gray-800" icon="lucide:arrow-up" /><span>Insert above</span>
-                            </div>
-                          </a-menu-item>
-                          <a-menu-item key="table-explorer-insert-below" @click="addField(displayColumn)">
-                            <div class="nc-project-menu-item">
-                              <Icon class="iconify text-gray-800" icon="lucide:arrow-down" /><span>Insert below</span>
-                            </div>
-                          </a-menu-item>
-
-                          <a-menu-divider class="my-0" />
-
-                          <a-menu-item key="table-explorer-delete" @click="onFieldDelete(displayColumn)">
-                            <div class="nc-project-menu-item group text-red-500">
-                              <GeneralIcon icon="delete" class="group-hover:text-accent" />
-                              Delete
-                            </div>
-                          </a-menu-item>
-                        </a-menu>
-                      </template>
-                    </a-dropdown>
                   <MdiChevronRight
                     class="text-brand-500 opacity-0"
                     :class="{
@@ -787,10 +801,10 @@ onMounted(async () => {
           </Draggable>
         </div>
         <Transition v-if="!changingField" name="slide-fade">
-            <div class="flex p-4 h-fit w-1/3 border-gray-200 border-1 rounded-xl">
+          <div class="border-gray-200 border-l-1 rounded-r-xl h-[calc(100vh-(var(--topbar-height)*3.85))]">
             <SmartsheetColumnEditOrAddProvider
               v-if="activeField"
-                class="w-full"
+              class="p-4 w-[25rem]"
               :column="activeField"
               :preload="fieldState(activeField)"
               :table-explorer-columns="fields"
@@ -799,10 +813,10 @@ onMounted(async () => {
               @update="onFieldUpdate"
               @add="onFieldAdd"
             />
-              <div v-else class="flex flex-col gap-6 w-full items-center">
+            <div v-else class="w-[25rem] flex flex-col justify-center p-4 items-center">
               <img src="~assets/img/fieldPlaceholder.svg" class="!w-[18rem]" />
-                <div class="text-2xl text-gray-600 font-bold text-center">Select a field</div>
+              <div class="text-2xl text-gray-600 font-bold text-center pt-6">Select a field</div>
-                <div class="text-center text-sm px-2 text-gray-500">
+              <div class="text-center text-sm px-2 text-gray-500 pt-6">
                 Make changes to field properties by selecting a field from the list
               </div>
             </div>
@@ -811,7 +825,6 @@ onMounted(async () => {
       </div>
     </div>
   </div>
-  </div>
 </template>
 
 <style lang="scss" scoped>
@@ -849,4 +862,8 @@ onMounted(async () => {
 .slide-fade-leave-to {
   opacity: 0;
 }
+
+.nc-fields-height {
+  height: calc(100vh - (var(--topbar-height) * 3.6));
+}
 </style>

packages/nc-gui/store/views.ts

@@ -1,4 +1,4 @@
-import { type ViewType } from 'nocodb-sdk'
+import type { ViewType } from 'nocodb-sdk'
 import { acceptHMRUpdate, defineStore } from 'pinia'
 import type { ViewPageType } from '~/lib'
 
@@ -6,6 +6,7 @@ export const useViewsStore = defineStore('viewsStore', () => {
   const { $api } = useNuxtApp()
 
   const router = useRouter()
+  const recentViews = ref<any>([])
   const route = router.currentRoute
 
   const tablesStore = useTablesStore()
@@ -20,6 +21,7 @@ export const useViewsStore = defineStore('viewsStore', () => {
       viewsByTable.value.set(tablesStore.activeTableId, value)
     },
   })
+
   const isViewsLoading = ref(true)
   const isViewDataLoading = ref(true)
   const isPublic = computed(() => route.value.meta?.public)
@@ -118,6 +120,10 @@ export const useViewsStore = defineStore('viewsStore', () => {
     })
   }
 
+  const changeView = async (..._args: any) => {}
+
+  const removeFromRecentViews = (..._args: any) => {}
+
   watch(
     () => tablesStore.activeTableId,
     async (newId, oldId) => {
@@ -203,6 +209,7 @@ export const useViewsStore = defineStore('viewsStore', () => {
     isViewDataLoading,
     isPaginationLoading,
     loadViews,
+    recentViews,
     views,
     activeView,
     openedViewsTab,
@@ -211,6 +218,8 @@ export const useViewsStore = defineStore('viewsStore', () => {
     viewsByTable,
     activeViewTitleOrId,
     navigateToView,
+    changeView,
+    removeFromRecentViews,
   }
 })
 

packages/nc-gui/windi.config.ts

@@ -174,6 +174,19 @@ export default defineConfig({
           800: '#164C66',
           900: '#0B2633',
         },
+        yellow: {
+          50: '#fffbf2',
+          100: '#fff0d1',
+          200: '#fee5b0',
+          300: '#fdd889',
+          400: '#fdcb61',
+          500: '#fcbe3a',
+          600: '#ca982e',
+          700: '#977223',
+          800: '#654c17',
+          900: '#32260c',
+        },
+
         primary: 'rgba(var(--color-primary), var(--tw-bg-opacity))',
         accent: 'rgba(var(--color-accent), var(--tw-bg-opacity))',
         dark: colors.dark,

tests/playwright/pages/Dashboard/Command/CmdJPage.ts

@@ -0,0 +1,39 @@
+import BasePage from '../../Base';
+import { DashboardPage } from '..';
+
+export class CmdJ extends BasePage {
+  readonly dashboardPage: DashboardPage;
+
+  constructor(dashboard: DashboardPage) {
+    super(dashboard.rootPage);
+    this.dashboardPage = dashboard;
+  }
+
+  get() {
+    return this.dashboardPage.get().locator('.DocSearch');
+  }
+
+  async openCmdJ() {
+    await this.dashboardPage.rootPage.keyboard.press(this.isMacOs() ? 'Meta+J' : 'Control+J');
+    // await this.dashboardPage.rootPage.waitForSelector('.DocSearch-Input');
+  }
+
+  async searchText(text: string) {
+    await this.dashboardPage.rootPage.fill('.DocSearch-Input', text);
+  }
+
+  async isCmdJVisible() {
+    const isVisible = this.get();
+    return await isVisible.count();
+  }
+
+  async isCmdJNotVisible() {
+    const isNotVisible = this.get();
+    return await isNotVisible.count();
+  }
+
+  async getPlaceholderText() {
+    const placeholderText = this.get().locator('.DocSearch-Input');
+    return await placeholderText.innerText();
+  }
+}

tests/playwright/pages/Dashboard/Command/CmdKPage.ts

@@ -0,0 +1,35 @@
+import BasePage from '../../Base';
+import { DashboardPage } from '..';
+
+export class CmdK extends BasePage {
+  readonly dashboardPage: DashboardPage;
+
+  constructor(dashboard: DashboardPage) {
+    super(dashboard.rootPage);
+    this.dashboardPage = dashboard;
+  }
+
+  get() {
+    return this.dashboardPage.get().locator('.cmdk-modal.cmdk-modal-active');
+  }
+
+  async openCmdK() {
+    await this.dashboardPage.rootPage.keyboard.press(this.isMacOs() ? 'Meta+K' : 'Control+K');
+    // await this.dashboardPage.rootPage.waitForSelector('.DocSearch-Input');
+  }
+
+  async searchText(text: string) {
+    await this.dashboardPage.rootPage.fill('.cmdk-input', text);
+    await this.rootPage.keyboard.press('Enter');
+  }
+
+  async isCmdKVisible() {
+    const isVisible = this.get();
+    return await isVisible.count();
+  }
+
+  async isCmdKNotVisible() {
+    const isNotVisible = this.get();
+    return await isNotVisible.count();
+  }
+}

tests/playwright/pages/Dashboard/Command/CmdLPage.ts

@@ -0,0 +1,49 @@
+import BasePage from '../../Base';
+import { DashboardPage } from '..';
+
+export class CmdL extends BasePage {
+  readonly dashboardPage: DashboardPage;
+
+  constructor(dashboard: DashboardPage) {
+    super(dashboard.rootPage);
+    this.dashboardPage = dashboard;
+  }
+
+  get() {
+    return this.dashboardPage.get().locator('.cmdl-modal.cmdl-modal-active');
+  }
+
+  async openCmdL() {
+    await this.dashboardPage.rootPage.keyboard.press(this.isMacOs() ? 'Meta+L' : 'Control+L');
+  }
+
+  async isCmdLVisible() {
+    const isVisible = this.get();
+    return await isVisible.count();
+  }
+
+  async isCmdLNotVisible() {
+    const isNotVisible = this.get();
+    return await isNotVisible.count();
+  }
+
+  async moveDown() {
+    await this.dashboardPage.rootPage.keyboard.press('ArrowDown');
+  }
+
+  async moveUp() {
+    await this.dashboardPage.rootPage.keyboard.press('ArrowUp');
+  }
+
+  async openRecent() {
+    await this.dashboardPage.rootPage.keyboard.press('Enter');
+  }
+
+  async getActiveViewTitle() {
+    return await this.dashboardPage.get().locator('.nc-active-view-title').innerText();
+  }
+
+  async getActiveTableTitle() {
+    return await this.dashboardPage.get().locator('.nc-active-table-title').innerText();
+  }
+}

tests/playwright/pages/Dashboard/index.ts

@@ -25,6 +25,9 @@ import { ProjectTypes } from 'nocodb-sdk';
 import { WorkspacePage } from '../WorkspacePage';
 import { DetailsPage } from './Details';
 import { WorkspaceSettingsObject } from './WorkspaceSettings';
+import { CmdJ } from './Command/CmdJPage';
+import { CmdK } from './Command/CmdKPage';
+import { CmdL } from './Command/CmdLPage';
 
 export class DashboardPage extends BasePage {
   readonly project: any;
@@ -55,6 +58,9 @@ export class DashboardPage extends BasePage {
   readonly shareProjectButton: ShareProjectButtonPage;
   readonly details: DetailsPage;
   readonly workspaceSettings: WorkspaceSettingsObject;
+  readonly cmdJ: CmdJ;
+  readonly cmdK: CmdK;
+  readonly cmdL: CmdL;
 
   constructor(rootPage: Page, project: any) {
     super(rootPage);
@@ -88,6 +94,9 @@ export class DashboardPage extends BasePage {
     this.shareProjectButton = new ShareProjectButtonPage(this);
     this.details = new DetailsPage(this);
     this.workspaceSettings = new WorkspaceSettingsObject(this);
+    this.cmdJ = new CmdJ(this);
+    this.cmdK = new CmdK(this);
+    this.cmdL = new CmdL(this);
   }
 
   get() {