Browse Source

fix(nc-gui): resolve PR comments

pull/4482/head
Wing-Kam Wong 2 years ago
parent
commit
2af5e7d224
  1. 3
      packages/nc-gui/components/cell/attachment/Modal.vue
  2. 6
      packages/nc-gui/components/virtual-cell/Formula.vue
  3. 6
      packages/nc-gui/components/virtual-cell/Rollup.vue

3
packages/nc-gui/components/cell/attachment/Modal.vue

@ -60,7 +60,8 @@ function onClick(item: Record<string, any>) {
<template>
<a-modal
v-model:visible="modalVisible"
:class="`nc-attachment-modal ${modalVisible ? 'active' : ''}`"
class="nc-attachment-modal"
:class="{ active: modalVisible }"
width="80%"
:footer="null"
wrap-class-name="nc-modal-attachment-expand-cell"

6
packages/nc-gui/components/virtual-cell/Formula.vue

@ -21,13 +21,7 @@ const showEditFormulaWarning = refAutoReset(false, timeout)
const showClearFormulaWarning = refAutoReset(false, timeout)
useSelectedCellKeyupListener(inject(ActiveCellInj, ref(false)), (e: KeyboardEvent) => {
switch (e.key) {
case 'Enter':
showEditFormulaWarning.value = true
break
default:
showClearFormulaWarning.value = true
}
})
</script>

6
packages/nc-gui/components/virtual-cell/Rollup.vue

@ -10,13 +10,7 @@ const showEditWarning = refAutoReset(false, timeout)
const showClearWarning = refAutoReset(false, timeout)
useSelectedCellKeyupListener(inject(ActiveCellInj, ref(false)), (e: KeyboardEvent) => {
switch (e.key) {
case 'Enter':
showEditWarning.value = true
break
default:
showClearWarning.value = true
}
})
</script>

Loading…
Cancel
Save