Browse Source

refactor(gui-v2): pressing delete should only delete selected cell content if not in editable mode

Signed-off-by: Pranav C <pranavxc@gmail.com>
pull/3339/head
Pranav C 2 years ago
parent
commit
266de121ee
  1. 10
      packages/nc-gui-v2/components/smartsheet/Grid.vue

10
packages/nc-gui-v2/components/smartsheet/Grid.vue

@ -219,7 +219,7 @@ const onKeyDown = async (e: KeyboardEvent) => {
/** on delete key press clear cell */ /** on delete key press clear cell */
case 'Delete': case 'Delete':
e.preventDefault() e.preventDefault()
await clearCell(selected as { row: number; col: number }) if (!editEnabled) await clearCell(selected as { row: number; col: number })
break break
/** on arrow key press navigate through cells */ /** on arrow key press navigate through cells */
case 'ArrowRight': case 'ArrowRight':
@ -467,9 +467,9 @@ const onNavigate = (dir: NavigateDir) => {
</SmartsheetRow> </SmartsheetRow>
<!-- <!--
TODO: add relationType !== 'bt' ? TODO: add relationType !== 'bt' ?
v1: <tr v-if="!isView && !isLocked && !isPublicView && isEditable && relationType !== 'bt'"> v1: <tr v-if="!isView && !isLocked && !isPublicView && isEditable && relationType !== 'bt'">
--> -->
<tr v-if="!isView && !isLocked && !isPublicView && isUIAllowed('xcDatatableEditable')"> <tr v-if="!isView && !isLocked && !isPublicView && isUIAllowed('xcDatatableEditable')">
<td <td
v-t="['c:row:add:grid-bottom']" v-t="['c:row:add:grid-bottom']"
@ -596,10 +596,12 @@ const onNavigate = (dir: NavigateDir) => {
.nc-row-expand-and-checkbox { .nc-row-expand-and-checkbox {
@apply w-full items-center justify-between; @apply w-full items-center justify-between;
} }
.nc-expand { .nc-expand {
&:not(.nc-comment) { &:not(.nc-comment) {
@apply hidden; @apply hidden;
} }
&.nc-comment { &.nc-comment {
display: flex; display: flex;
} }

Loading…
Cancel
Save