Browse Source

fix: add try-catch block to upgrader

pull/7373/head
mertmit 9 months ago
parent
commit
1494384c29
  1. 24
      packages/nocodb/src/version-upgrader/ncXcdbCreatedAndUpdatedSystemFieldsUpgrader.ts

24
packages/nocodb/src/version-upgrader/ncXcdbCreatedAndUpdatedSystemFieldsUpgrader.ts

@ -15,8 +15,6 @@ import NcConnectionMgrv2 from '~/utils/common/NcConnectionMgrv2';
import getColumnUiType from '~/helpers/getColumnUiType';
import RequestQueue from '~/utils/RequestQueue';
// Example Usage:
// An upgrader for upgrading created_at and updated_at columns
// to system column and convert to new uidt CreatedTime and LastModifiedTime
@ -26,6 +24,11 @@ const logger = {
`[ncXcdbCreatedAndUpdatedSystemFieldsUpgrader ${Date.now()}] ` + message,
);
},
error: (message: string) => {
console.error(
`[ncXcdbCreatedAndUpdatedSystemFieldsUpgrader ${Date.now()}] ` + message,
);
},
};
/* Enable if planning to remove trigger
@ -70,7 +73,7 @@ async function upgradeModels({
await Promise.all(
models.map(async (model: any) => {
if (model.mm) return;
try {
logger.log(
`Upgrading model '${model.title}'(${model.id}) from base '${base.title}'(${base.id}})`,
);
@ -103,7 +106,9 @@ async function upgradeModels({
continue;
}
if ([UITypes.CreatedBy, UITypes.LastModifiedBy].includes(column.uidt)) {
if (
[UITypes.CreatedBy, UITypes.LastModifiedBy].includes(column.uidt)
) {
continue;
}
@ -135,7 +140,8 @@ async function upgradeModels({
if (source.type === 'pg') {
// delete pg trigger if exists
await deletePgTrigger({ column, ncMeta, model });
}*/
}
*/
}
if (column.column_name === 'updated_at') {
isLastModifiedTimeExists = true;
@ -323,6 +329,12 @@ async function upgradeModels({
logger.log(
`Upgraded model '${model.title}'(${model.id}) from base '${base.title}'(${base.id}})`,
);
} catch (e) {
logger.error(
`Upgrading model '${model.title}'(${model.id}) from base '${base.title}'(${base.id}}) failed`,
);
throw e;
}
}),
);
}
@ -373,7 +385,7 @@ export default async function ({ ncMeta }: NcUpgraderCtx) {
})`,
);
return upgradeModels({ ncMeta, source, base }).then(() => {
await upgradeModels({ ncMeta, source, base }).then(() => {
logger.log(
`Upgraded base '${base.title}'(${base.id},${source.id}) (${i + 1}/${
sources.length

Loading…
Cancel
Save