Browse Source

Remove pointless boolean during native push

The boolean field sentCommand is always true at this point, as it
was assigned just 5 lines above.  So we always set the status of
the update command object to AWAITING_REPORT.

Simplify the logic by dropping the ?: operator.  I assume this is
older code from an attempt to manage dry-run push support within
the native connection, but in fact dry-run support is done higher
up inside of PushProcess.

Change-Id: I450d491bbbb5afecdbf5444ab7169222e856a3bb
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
stable-0.7
Shawn O. Pearce 15 years ago
parent
commit
efdcb16be3
  1. 2
      org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java

2
org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java

@ -178,7 +178,7 @@ class BasePackPushConnection extends BasePackConnection implements
} }
pckOut.writeString(sb.toString()); pckOut.writeString(sb.toString());
rru.setStatus(sentCommand ? Status.AWAITING_REPORT : Status.OK); rru.setStatus(Status.AWAITING_REPORT);
if (!rru.isDelete()) if (!rru.isDelete())
writePack = true; writePack = true;
} }

Loading…
Cancel
Save