Browse Source

Get rid of warnings about empty statments

In HtttpAuthMethod there were comments, but not in a style
that Eclipse recognizes.

Change-Id: I64f55b27143f8badcefbb419d3951f2a26b87d5f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
stable-2.0
Robin Rosenberg 13 years ago committed by Matthias Sohn
parent
commit
e251355897
  1. 6
      org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/TestRepository.java
  2. 1
      org.eclipse.jgit/src/org/eclipse/jgit/lib/RefDatabase.java
  3. 12
      org.eclipse.jgit/src/org/eclipse/jgit/transport/HttpAuthMethod.java

6
org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/TestRepository.java

@ -459,9 +459,13 @@ public class TestRepository<R extends Repository> {
*/ */
public <T extends AnyObjectId> T update(String ref, T obj) throws Exception { public <T extends AnyObjectId> T update(String ref, T obj) throws Exception {
if (Constants.HEAD.equals(ref)) { if (Constants.HEAD.equals(ref)) {
// nothing
} else if ("FETCH_HEAD".equals(ref)) { } else if ("FETCH_HEAD".equals(ref)) {
// nothing
} else if ("MERGE_HEAD".equals(ref)) { } else if ("MERGE_HEAD".equals(ref)) {
// nothing
} else if (ref.startsWith(Constants.R_REFS)) { } else if (ref.startsWith(Constants.R_REFS)) {
// nothing
} else } else
ref = Constants.R_HEADS + ref; ref = Constants.R_HEADS + ref;
@ -537,7 +541,9 @@ public class TestRepository<R extends Repository> {
*/ */
public BranchBuilder branch(String ref) { public BranchBuilder branch(String ref) {
if (Constants.HEAD.equals(ref)) { if (Constants.HEAD.equals(ref)) {
// nothing
} else if (ref.startsWith(Constants.R_REFS)) { } else if (ref.startsWith(Constants.R_REFS)) {
// nothing
} else } else
ref = Constants.R_HEADS + ref; ref = Constants.R_HEADS + ref;
return new BranchBuilder(ref); return new BranchBuilder(ref);

1
org.eclipse.jgit/src/org/eclipse/jgit/lib/RefDatabase.java

@ -219,5 +219,6 @@ public abstract class RefDatabase {
* Implementors should overwrite this method if they use any kind of caches. * Implementors should overwrite this method if they use any kind of caches.
*/ */
public void refresh() { public void refresh() {
// nothing
} }
} }

12
org.eclipse.jgit/src/org/eclipse/jgit/transport/HttpAuthMethod.java

@ -277,12 +277,14 @@ abstract class HttpAuthMethod {
r.append("://"); r.append("://");
r.append(u.getHost()); r.append(u.getHost());
if (0 < u.getPort()) { if (0 < u.getPort()) {
if (u.getPort() == 80 && "http".equals(u.getProtocol())) if (u.getPort() == 80 && "http".equals(u.getProtocol())) {
/* nothing */; /* nothing */
else if (u.getPort() == 443 && "https".equals(u.getProtocol())) } else if (u.getPort() == 443
/* nothing */; && "https".equals(u.getProtocol())) {
else /* nothing */
} else {
r.append(':').append(u.getPort()); r.append(':').append(u.getPort());
}
} }
r.append(u.getPath()); r.append(u.getPath());
if (u.getQuery() != null) if (u.getQuery() != null)

Loading…
Cancel
Save