Browse Source

Let LockFile.unlock use FileUtils.delete()

We sometimes face the problem that the file .git/index.lock
can't deleted causing JGit operations to fail. Problem is
that LockFile.unlock() simply deletes the lockfile and ignores the
return value of File.delete(). Instead use
FileUtils.delete() with retry option. This method will retry the
deletion of the file at most 10 times with sleeps inbetween.

Bug: 335959
Change-Id: I9598edea9f2304fe12e6f470301211b503434848
Signed-off-by: Christian Halstrick <christian.halstrick@sap.com>
stable-0.12
Christian Halstrick 14 years ago
parent
commit
d8bcc84154
  1. 6
      org.eclipse.jgit/src/org/eclipse/jgit/storage/file/LockFile.java

6
org.eclipse.jgit/src/org/eclipse/jgit/storage/file/LockFile.java

@ -488,7 +488,11 @@ public class LockFile {
if (haveLck) { if (haveLck) {
haveLck = false; haveLck = false;
lck.delete(); try {
FileUtils.delete(lck, FileUtils.RETRY);
} catch (IOException e) {
// couldn't delete the file even after retry.
}
} }
} }

Loading…
Cancel
Save