Browse Source

RefUpdateTest: Don't call createBareRepository in try-with-resource

createBareRepository adds the created repo to the list of repos to be
closed in the superclass's teardown. Wrapping it in try-with-resource
causes it to be closed too many times, resulting in a corrupt use
count.

Change-Id: I4c70630bf6008544324dda453deb141f4f89472c
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
stable-4.7
David Pursehouse 8 years ago committed by Matthias Sohn
parent
commit
ac6353e9e5
  1. 16
      org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/RefUpdateTest.java

16
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/RefUpdateTest.java

@ -239,14 +239,14 @@ public class RefUpdateTest extends SampleDataRepositoryTestCase {
@Test @Test
public void testDeleteHeadInBareRepo() throws IOException { public void testDeleteHeadInBareRepo() throws IOException {
try (Repository bareRepo = createBareRepository()) { Repository bareRepo = createBareRepository();
RefUpdate ref = bareRepo.updateRef(Constants.HEAD); RefUpdate ref = bareRepo.updateRef(Constants.HEAD);
ref.setNewObjectId(ObjectId.fromString("0123456789012345678901234567890123456789")); ref.setNewObjectId(ObjectId
// Create the HEAD ref so we can delete it. .fromString("0123456789012345678901234567890123456789"));
assertEquals(Result.NEW, ref.update()); // Create the HEAD ref so we can delete it.
ref = bareRepo.updateRef(Constants.HEAD); assertEquals(Result.NEW, ref.update());
delete(bareRepo, ref, Result.NO_CHANGE, true, true); ref = bareRepo.updateRef(Constants.HEAD);
} delete(bareRepo, ref, Result.NO_CHANGE, true, true);
} }
/** /**
* Delete a loose ref and make sure the directory in refs is deleted too, * Delete a loose ref and make sure the directory in refs is deleted too,

Loading…
Cancel
Save