From ac6353e9e5fbcf0c1a298990505674077ff09a22 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Fri, 27 Jan 2017 19:33:20 +0900 Subject: [PATCH] RefUpdateTest: Don't call createBareRepository in try-with-resource createBareRepository adds the created repo to the list of repos to be closed in the superclass's teardown. Wrapping it in try-with-resource causes it to be closed too many times, resulting in a corrupt use count. Change-Id: I4c70630bf6008544324dda453deb141f4f89472c Signed-off-by: David Pursehouse --- .../internal/storage/file/RefUpdateTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/RefUpdateTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/RefUpdateTest.java index 4be1d6d37..daef91d53 100644 --- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/RefUpdateTest.java +++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/RefUpdateTest.java @@ -239,14 +239,14 @@ public class RefUpdateTest extends SampleDataRepositoryTestCase { @Test public void testDeleteHeadInBareRepo() throws IOException { - try (Repository bareRepo = createBareRepository()) { - RefUpdate ref = bareRepo.updateRef(Constants.HEAD); - ref.setNewObjectId(ObjectId.fromString("0123456789012345678901234567890123456789")); - // Create the HEAD ref so we can delete it. - assertEquals(Result.NEW, ref.update()); - ref = bareRepo.updateRef(Constants.HEAD); - delete(bareRepo, ref, Result.NO_CHANGE, true, true); - } + Repository bareRepo = createBareRepository(); + RefUpdate ref = bareRepo.updateRef(Constants.HEAD); + ref.setNewObjectId(ObjectId + .fromString("0123456789012345678901234567890123456789")); + // Create the HEAD ref so we can delete it. + assertEquals(Result.NEW, ref.update()); + ref = bareRepo.updateRef(Constants.HEAD); + delete(bareRepo, ref, Result.NO_CHANGE, true, true); } /** * Delete a loose ref and make sure the directory in refs is deleted too,