Browse Source

Merge changes Ic555e6e0,Id4cb9a23

* changes:
  Replace use of deprecated release() method in BlameResult
  Use try-with-resource to close BlameGenerator
stable-4.1
Shawn Pearce 10 years ago committed by Gerrit Code Review @ Eclipse.org
parent
commit
9b9087d47d
  1. 5
      org.eclipse.jgit/src/org/eclipse/jgit/api/BlameCommand.java
  2. 8
      org.eclipse.jgit/src/org/eclipse/jgit/blame/BlameResult.java

5
org.eclipse.jgit/src/org/eclipse/jgit/api/BlameCommand.java

@ -200,8 +200,7 @@ public class BlameCommand extends GitCommand<BlameResult> {
*/ */
public BlameResult call() throws GitAPIException { public BlameResult call() throws GitAPIException {
checkCallable(); checkCallable();
BlameGenerator gen = new BlameGenerator(repo, path); try (BlameGenerator gen = new BlameGenerator(repo, path)) {
try {
if (diffAlgorithm != null) if (diffAlgorithm != null)
gen.setDiffAlgorithm(diffAlgorithm); gen.setDiffAlgorithm(diffAlgorithm);
if (textComparator != null) if (textComparator != null)
@ -231,8 +230,6 @@ public class BlameCommand extends GitCommand<BlameResult> {
return gen.computeBlameResult(); return gen.computeBlameResult();
} catch (IOException e) { } catch (IOException e) {
throw new JGitInternalException(e.getMessage(), e); throw new JGitInternalException(e.getMessage(), e);
} finally {
gen.release();
} }
} }

8
org.eclipse.jgit/src/org/eclipse/jgit/blame/BlameResult.java

@ -85,7 +85,7 @@ public class BlameResult {
String path = gen.getResultPath(); String path = gen.getResultPath();
RawText contents = gen.getResultContents(); RawText contents = gen.getResultContents();
if (contents == null) { if (contents == null) {
gen.release(); gen.close();
return null; return null;
} }
return new BlameResult(gen, path, contents); return new BlameResult(gen, path, contents);
@ -239,7 +239,7 @@ public class BlameResult {
while (gen.next()) while (gen.next())
loadFrom(gen); loadFrom(gen);
} finally { } finally {
gen.release(); gen.close();
generator = null; generator = null;
} }
} }
@ -265,7 +265,7 @@ public class BlameResult {
lastLength = gen.getRegionLength(); lastLength = gen.getRegionLength();
return gen.getResultStart(); return gen.getResultStart();
} else { } else {
gen.release(); gen.close();
generator = null; generator = null;
return -1; return -1;
} }
@ -300,7 +300,7 @@ public class BlameResult {
return; return;
if (!gen.next()) { if (!gen.next()) {
gen.release(); gen.close();
generator = null; generator = null;
return; return;
} }

Loading…
Cancel
Save