Browse Source

ConcurrentRepackTest: Open RevWalk in try-with-resource

Change-Id: Idc7b7bbdc1df05372b873cbe4c495474f3ffd64b
Signed-off-by: David Pursehouse <david.pursehouse@sonymobile.com>
stable-4.2
David Pursehouse 9 years ago
parent
commit
8bbd9077e4
  1. 7
      org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/ConcurrentRepackTest.java

7
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/ConcurrentRepackTest.java

@ -211,7 +211,9 @@ public class ConcurrentRepackTest extends RepositoryTestCase {
private RevObject parse(final AnyObjectId id) private RevObject parse(final AnyObjectId id)
throws MissingObjectException, IOException { throws MissingObjectException, IOException {
return new RevWalk(db).parseAny(id); try (RevWalk rw = new RevWalk(db)) {
return rw.parseAny(id);
}
} }
private File[] pack(final Repository src, final RevObject... list) private File[] pack(final Repository src, final RevObject... list)
@ -280,7 +282,6 @@ public class ConcurrentRepackTest extends RepositoryTestCase {
private RevObject writeBlob(final Repository repo, final String data) private RevObject writeBlob(final Repository repo, final String data)
throws IOException { throws IOException {
final RevWalk revWalk = new RevWalk(repo);
final byte[] bytes = Constants.encode(data); final byte[] bytes = Constants.encode(data);
final ObjectId id; final ObjectId id;
try (ObjectInserter inserter = repo.newObjectInserter()) { try (ObjectInserter inserter = repo.newObjectInserter()) {
@ -293,6 +294,8 @@ public class ConcurrentRepackTest extends RepositoryTestCase {
} catch (MissingObjectException e) { } catch (MissingObjectException e) {
// Ok // Ok
} }
try (RevWalk revWalk = new RevWalk(repo)) {
return revWalk.lookupBlob(id); return revWalk.lookupBlob(id);
} }
}
} }

Loading…
Cancel
Save