Browse Source
After packaging references, the folders containing these references are not deleted. In a busy repository, this causes operations to slow down as traversing the references tree becomes longer. Delete empty reference folders after the loose references have been packed. To avoid deleting a folder that was just created by another concurrent operation, only delete folders that were not modified in the last 30 seconds. Signed-off-by: Hector Oswaldo Caballero <hector.caballero@ericsson.com> Change-Id: Ie79447d6121271cf5e25171be377ea396c7028e0 Signed-off-by: Luca Milanesio <luca.milanesio@gmail.com> Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>stable-4.7
Hector Caballero
7 years ago
committed by
David Pursehouse
2 changed files with 164 additions and 0 deletions
@ -0,0 +1,118 @@
|
||||
/* |
||||
* Copyright (C) 2018 Ericsson |
||||
* and other copyright owners as documented in the project's IP log. |
||||
* |
||||
* This program and the accompanying materials are made available |
||||
* under the terms of the Eclipse Distribution License v1.0 which |
||||
* accompanies this distribution, is reproduced below, and is |
||||
* available at http://www.eclipse.org/org/documents/edl-v10.php
|
||||
* |
||||
* All rights reserved. |
||||
* |
||||
* Redistribution and use in source and binary forms, with or |
||||
* without modification, are permitted provided that the following |
||||
* conditions are met: |
||||
* |
||||
* - Redistributions of source code must retain the above copyright |
||||
* notice, this list of conditions and the following disclaimer. |
||||
* |
||||
* - Redistributions in binary form must reproduce the above |
||||
* copyright notice, this list of conditions and the following |
||||
* disclaimer in the documentation and/or other materials provided |
||||
* with the distribution. |
||||
* |
||||
* - Neither the name of the Eclipse Foundation, Inc. nor the |
||||
* names of its contributors may be used to endorse or promote |
||||
* products derived from this software without specific prior |
||||
* written permission. |
||||
* |
||||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND |
||||
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, |
||||
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES |
||||
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE |
||||
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR |
||||
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
||||
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT |
||||
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; |
||||
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER |
||||
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, |
||||
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) |
||||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF |
||||
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
||||
*/ |
||||
|
||||
package org.eclipse.jgit.internal.storage.file; |
||||
|
||||
import static org.junit.Assert.assertFalse; |
||||
import static org.junit.Assert.assertTrue; |
||||
|
||||
import java.nio.file.Files; |
||||
import java.nio.file.Path; |
||||
import java.nio.file.Paths; |
||||
import java.nio.file.attribute.FileTime; |
||||
import java.time.Instant; |
||||
|
||||
import org.junit.Before; |
||||
import org.junit.Test; |
||||
|
||||
public class GcDeleteEmptyRefsFoldersTest extends GcTestCase { |
||||
private static final String REF_FOLDER_01 = "01"; |
||||
private static final String REF_FOLDER_02 = "02"; |
||||
|
||||
private Path refsDir; |
||||
private Path heads; |
||||
|
||||
@Override |
||||
@Before |
||||
public void setUp() throws Exception { |
||||
super.setUp(); |
||||
refsDir = Paths.get(repo.getDirectory().getAbsolutePath()) |
||||
.resolve("refs"); |
||||
heads = refsDir.resolve("heads"); |
||||
} |
||||
|
||||
@Test |
||||
public void emptyRefFoldersAreDeleted() throws Exception { |
||||
FileTime fileTime = FileTime.from(Instant.now().minusSeconds(31)); |
||||
Path refDir01 = Files.createDirectory(heads.resolve(REF_FOLDER_01)); |
||||
Path refDir02 = Files.createDirectory(heads.resolve(REF_FOLDER_02)); |
||||
Files.setLastModifiedTime(refDir01, fileTime); |
||||
Files.setLastModifiedTime(refDir02, fileTime); |
||||
assertTrue(refDir01.toFile().exists()); |
||||
assertTrue(refDir02.toFile().exists()); |
||||
gc.gc(); |
||||
|
||||
assertFalse(refDir01.toFile().exists()); |
||||
assertFalse(refDir02.toFile().exists()); |
||||
} |
||||
|
||||
@Test |
||||
public void emptyRefFoldersAreKeptIfTheyAreTooRecent() |
||||
throws Exception { |
||||
Path refDir01 = Files.createDirectory(heads.resolve(REF_FOLDER_01)); |
||||
Path refDir02 = Files.createDirectory(heads.resolve(REF_FOLDER_02)); |
||||
assertTrue(refDir01.toFile().exists()); |
||||
assertTrue(refDir02.toFile().exists()); |
||||
gc.gc(); |
||||
|
||||
assertTrue(refDir01.toFile().exists()); |
||||
assertTrue(refDir02.toFile().exists()); |
||||
} |
||||
|
||||
@Test |
||||
public void nonEmptyRefsFoldersAreKept() throws Exception { |
||||
Path refDir01 = Files.createDirectory(heads.resolve(REF_FOLDER_01)); |
||||
Path refDir02 = Files.createDirectory(heads.resolve(REF_FOLDER_02)); |
||||
Path ref01 = Files.createFile(refDir01.resolve("ref01")); |
||||
Path ref02 = Files.createFile(refDir01.resolve("ref02")); |
||||
assertTrue(refDir01.toFile().exists()); |
||||
assertTrue(refDir02.toFile().exists()); |
||||
assertTrue(ref01.toFile().exists()); |
||||
assertTrue(ref02.toFile().exists()); |
||||
gc.gc(); |
||||
assertTrue(refDir01.toFile().exists()); |
||||
assertTrue(refDir02.toFile().exists()); |
||||
assertTrue(ref01.toFile().exists()); |
||||
assertTrue(ref02.toFile().exists()); |
||||
} |
||||
} |
Loading…
Reference in new issue