ResolveMerger: push result file creation into updateIndex()

The only caller of writeMergedFile is updateIndex, and the only
user of this path object is the code within the method. This is
a no-op change that opens the door to refactoring the way temp
files are handled for inCore merges.

Change-Id: I863a303194689a806b667e55eb958e1decf046c1

org.eclipse.jgit/src/org/eclipse/jgit/merge/ResolveMerger.java

@@ -635,8 +635,7 @@ public class ResolveMerger extends ThreeWayMerger {
 			MergeResult<RawText> result = contentMerge(base, ours, theirs);
 			if (ignoreConflicts)
 				result.setContainsConflicts(false);
-			File of = writeMergedFile(result);
+			updateIndex(base, ours, theirs, result);
-			updateIndex(base, ours, theirs, result, of);
 			if (result.containsConflicts() && !ignoreConflicts)
 				unmergedPaths.add(tw.getPathString());
 			modifiedFiles.add(tw.getPathString());
@@ -750,14 +749,14 @@ public class ResolveMerger extends ThreeWayMerger {
 	 * @param ours
 	 * @param theirs
 	 * @param result
-	 * @param of
 	 * @throws FileNotFoundException
 	 * @throws IOException
 	 */
 	private void updateIndex(CanonicalTreeParser base,
 			CanonicalTreeParser ours, CanonicalTreeParser theirs,
-			MergeResult<RawText> result, File of) throws FileNotFoundException,
+			MergeResult<RawText> result) throws FileNotFoundException,
 			IOException {
+		File of = writeMergedFile(result);
 		if (result.containsConflicts()) {
 			// a conflict occurred, the file will contain conflict markers
 			// the index will be populated with the three stages and only the