github
/
jgit
mirror of https://gitee.com/github-mirror-repo/jgit.git
1
0
Fork 0
Code Issues Releases Wiki Activity
Browse Source

Bazel: Increase severity of most error-prone checks to ERROR 

Most of the checks can be increased to ERROR because there is no
code in the project that triggers them.

There are still several that are triggered, and these are left
at the WARN severity:

  https://errorprone.info/bugpattern/AmbiguousMethodReference
  https://errorprone.info/bugpattern/BadComparable
  https://errorprone.info/bugpattern/ClassNewInstance
  https://errorprone.info/bugpattern/Finally
  https://errorprone.info/bugpattern/FutureReturnValueIgnored
  https://errorprone.info/bugpattern/ImmutableEnumChecker
  https://errorprone.info/bugpattern/NarrowingCompoundAssignment
  https://errorprone.info/bugpattern/NonOverridingEquals
  https://errorprone.info/bugpattern/OperatorPrecedence
  https://errorprone.info/bugpattern/ReferenceEquality
  https://errorprone.info/bugpattern/ShortCircuitBoolean
  https://errorprone.info/bugpattern/StringEquality
  https://errorprone.info/bugpattern/TypeParameterUnusedInFormals

These can be cleaned up and increased to ERROR in follow-up
commits.

Change-Id: Icfc3b3163e129e504f10b3fc856aef262f723f99
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
stable-5.3
David Pursehouse 5 years ago
parent
4c33f70d5a
commit
245c2c09a0
1 changed files with 39 additions and 39 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 78
      tools/BUILD

78
tools/BUILD
Unescape View File

@ -25,61 +25,61 @@ java_package_configuration(
"-Xep:MissingCasesInEnumSwitch:ERROR", "-Xep:MissingCasesInEnumSwitch:ERROR",
"-Xep:ReferenceEquality:WARN", "-Xep:ReferenceEquality:WARN",
"-Xep:StringEquality:WARN", "-Xep:StringEquality:WARN",
"-Xep:WildcardImport:WARN", "-Xep:WildcardImport:ERROR",
"-Xep:AmbiguousMethodReference:WARN", "-Xep:AmbiguousMethodReference:WARN",
"-Xep:BadAnnotationImplementation:WARN", "-Xep:BadAnnotationImplementation:ERROR",
"-Xep:BadComparable:WARN", "-Xep:BadComparable:WARN",
"-Xep:BoxedPrimitiveConstructor:ERROR", "-Xep:BoxedPrimitiveConstructor:ERROR",
"-Xep:CannotMockFinalClass:WARN", "-Xep:CannotMockFinalClass:ERROR",
"-Xep:ClassCanBeStatic:ERROR", "-Xep:ClassCanBeStatic:ERROR",
"-Xep:ClassNewInstance:WARN", "-Xep:ClassNewInstance:WARN",
"-Xep:DefaultCharset:ERROR", "-Xep:DefaultCharset:ERROR",
"-Xep:DoubleCheckedLocking:WARN", "-Xep:DoubleCheckedLocking:ERROR",
"-Xep:ElementsCountedInLoop:WARN", "-Xep:ElementsCountedInLoop:ERROR",
"-Xep:EqualsHashCode:WARN", "-Xep:EqualsHashCode:ERROR",
"-Xep:EqualsIncompatibleType:WARN", "-Xep:EqualsIncompatibleType:ERROR",
"-Xep:ExpectedExceptionChecker:ERROR", "-Xep:ExpectedExceptionChecker:ERROR",
"-Xep:Finally:WARN", "-Xep:Finally:WARN",
"-Xep:FloatingPointLiteralPrecision:WARN", "-Xep:FloatingPointLiteralPrecision:ERROR",
"-Xep:FragmentInjection:WARN", "-Xep:FragmentInjection:ERROR",
"-Xep:FragmentNotInstantiable:WARN", "-Xep:FragmentNotInstantiable:ERROR",
"-Xep:FunctionalInterfaceClash:WARN", "-Xep:FunctionalInterfaceClash:ERROR",
"-Xep:FutureReturnValueIgnored:WARN", "-Xep:FutureReturnValueIgnored:WARN",
"-Xep:GetClassOnEnum:WARN", "-Xep:GetClassOnEnum:ERROR",
"-Xep:ImmutableAnnotationChecker:WARN", "-Xep:ImmutableAnnotationChecker:ERROR",
"-Xep:ImmutableEnumChecker:WARN", "-Xep:ImmutableEnumChecker:WARN",
"-Xep:IncompatibleModifiers:WARN", "-Xep:IncompatibleModifiers:ERROR",
"-Xep:InjectOnConstructorOfAbstractClass:WARN", "-Xep:InjectOnConstructorOfAbstractClass:ERROR",
"-Xep:InputStreamSlowMultibyteRead:WARN", "-Xep:InputStreamSlowMultibyteRead:ERROR",
"-Xep:IterableAndIterator:WARN", "-Xep:IterableAndIterator:ERROR",
"-Xep:JUnit3FloatingPointComparisonWithoutDelta:WARN", "-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR",
"-Xep:JUnitAmbiguousTestClass:WARN", "-Xep:JUnitAmbiguousTestClass:ERROR",
"-Xep:LiteralClassName:WARN", "-Xep:LiteralClassName:ERROR",
"-Xep:MissingFail:ERROR", "-Xep:MissingFail:ERROR",
"-Xep:MissingOverride:WARN", "-Xep:MissingOverride:ERROR",
"-Xep:MutableConstantField:WARN", "-Xep:MutableConstantField:ERROR",
"-Xep:NarrowingCompoundAssignment:WARN", "-Xep:NarrowingCompoundAssignment:WARN",
"-Xep:NonAtomicVolatileUpdate:WARN", "-Xep:NonAtomicVolatileUpdate:ERROR",
"-Xep:NonOverridingEquals:WARN", "-Xep:NonOverridingEquals:WARN",
"-Xep:NullableConstructor:WARN", "-Xep:NullableConstructor:ERROR",
"-Xep:NullablePrimitive:WARN", "-Xep:NullablePrimitive:ERROR",
"-Xep:NullableVoid:WARN", "-Xep:NullableVoid:ERROR",
"-Xep:OperatorPrecedence:WARN", "-Xep:OperatorPrecedence:WARN",
"-Xep:OverridesGuiceInjectableMethod:WARN", "-Xep:OverridesGuiceInjectableMethod:ERROR",
"-Xep:PreconditionsInvalidPlaceholder:WARN", "-Xep:PreconditionsInvalidPlaceholder:ERROR",
"-Xep:ProtoFieldPreconditionsCheckNotNull:WARN", "-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR",
"-Xep:ProtocolBufferOrdinal:WARN", "-Xep:ProtocolBufferOrdinal:ERROR",
"-Xep:RequiredModifiers:WARN", "-Xep:RequiredModifiers:ERROR",
"-Xep:ShortCircuitBoolean:WARN", "-Xep:ShortCircuitBoolean:WARN",
"-Xep:SimpleDateFormatConstant:WARN", "-Xep:SimpleDateFormatConstant:ERROR",
"-Xep:StaticGuardedByInstance:WARN", "-Xep:StaticGuardedByInstance:ERROR",
"-Xep:SynchronizeOnNonFinalField:WARN", "-Xep:SynchronizeOnNonFinalField:ERROR",
"-Xep:TruthConstantAsserts:WARN", "-Xep:TruthConstantAsserts:ERROR",
"-Xep:TypeParameterShadowing:WARN", "-Xep:TypeParameterShadowing:ERROR",
"-Xep:TypeParameterUnusedInFormals:WARN", "-Xep:TypeParameterUnusedInFormals:WARN",
"-Xep:URLEqualsHashCode:WARN", "-Xep:URLEqualsHashCode:ERROR",
"-Xep:UnsynchronizedOverridesSynchronized:WARN", "-Xep:UnsynchronizedOverridesSynchronized:ERROR",
"-Xep:WaitNotInLoop:WARN", "-Xep:WaitNotInLoop:ERROR",
], ],
packages = ["error_prone_packages"], packages = ["error_prone_packages"],
) )

Write Preview
Loading…
Cancel
Save