Merge branch 'stable-5.1'

* stable-5.1:
  SubmoduleValidator: Remove unused import of ConfigConstants
  SubmoduleValidator: Permit missing path or url

Change-Id: Ie0e35231c81a0c53c2051c4c123a5210b5a1c6d3
Signed-off-by: Jonathan Nieder <jrn@google.com>

org.eclipse.jgit/src/org/eclipse/jgit/internal/submodule/SubmoduleValidator.java

@@ -42,13 +42,16 @@
  */
 package org.eclipse.jgit.internal.submodule;
 
+import static org.eclipse.jgit.lib.ConfigConstants.CONFIG_KEY_PATH;
+import static org.eclipse.jgit.lib.ConfigConstants.CONFIG_KEY_URL;
+import static org.eclipse.jgit.lib.ConfigConstants.CONFIG_SUBMODULE_SECTION;
+
 import java.io.IOException;
 import java.text.MessageFormat;
 
 import org.eclipse.jgit.errors.ConfigInvalidException;
 import org.eclipse.jgit.internal.JGitText;
 import org.eclipse.jgit.lib.Config;
-import org.eclipse.jgit.lib.ConfigConstants;
 
 /**
  * Validations for the git submodule fields (name, path, uri).
@@ -134,7 +137,6 @@ public class SubmoduleValidator {
 	 */
 	public static void assertValidSubmodulePath(String path)
 			throws SubmoduleValidationException {
-
 		if (path.startsWith("-")) { //$NON-NLS-1$
 			throw new SubmoduleValidationException(
 					MessageFormat.format(
@@ -154,20 +156,22 @@ public class SubmoduleValidator {
 		Config c = new Config();
 		try {
 			c.fromText(gitModulesContents);
-			for (String subsection : c.getSubsections(
+			for (String subsection :
-					ConfigConstants.CONFIG_SUBMODULE_SECTION)) {
+					c.getSubsections(CONFIG_SUBMODULE_SECTION)) {
+				assertValidSubmoduleName(subsection);
+
 				String url = c.getString(
-						ConfigConstants.CONFIG_SUBMODULE_SECTION,
+						CONFIG_SUBMODULE_SECTION, subsection, CONFIG_KEY_URL);
-						subsection, ConfigConstants.CONFIG_KEY_URL);
+				if (url != null) {
 					assertValidSubmoduleUri(url);
-
+				}
-				assertValidSubmoduleName(subsection);
 
 				String path = c.getString(
-						ConfigConstants.CONFIG_SUBMODULE_SECTION, subsection,
+						CONFIG_SUBMODULE_SECTION, subsection, CONFIG_KEY_PATH);
-						ConfigConstants.CONFIG_KEY_PATH);
+				if (path != null) {
 					assertValidSubmodulePath(path);
 				}
+			}
 		} catch (ConfigInvalidException e) {
 			throw new IOException(
 					MessageFormat.format(