Browse Source

Prefix an abnormal CLI command termination with 'fatal:'

Change-Id: I3d257666c6fbed7b238c575808f73ec518e811b9
Signed-off-by: Chris Aniszczyk <zx@twitter.com>
stable-2.2
Tomasz Zarna 12 years ago committed by Chris Aniszczyk
parent
commit
074f9194dc
  1. 4
      org.eclipse.jgit.pgm.test/src/org/eclipse/jgit/pgm/CLIGitCommand.java
  2. 2
      org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/BranchTest.java
  3. 4
      org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/CheckoutTest.java
  4. 1
      org.eclipse.jgit.pgm/resources/org/eclipse/jgit/pgm/CLIText.properties
  5. 1
      org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/CLIText.java

4
org.eclipse.jgit.pgm.test/src/org/eclipse/jgit/pgm/CLIGitCommand.java

@ -43,6 +43,7 @@
package org.eclipse.jgit.pgm; package org.eclipse.jgit.pgm;
import java.io.ByteArrayOutputStream; import java.io.ByteArrayOutputStream;
import java.text.MessageFormat;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@ -91,7 +92,8 @@ public class CLIGitCommand {
cmd.execute(bean.getArguments().toArray( cmd.execute(bean.getArguments().toArray(
new String[bean.getArguments().size()])); new String[bean.getArguments().size()]));
} catch (Die e) { } catch (Die e) {
return IO.readLines(e.getMessage()); return IO.readLines(MessageFormat.format(CLIText.get().fatalError,
e.getMessage()));
} finally { } finally {
if (cmd.outw != null) if (cmd.outw != null)
cmd.outw.flush(); cmd.outw.flush();

2
org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/BranchTest.java

@ -65,7 +65,7 @@ public class BranchTest extends CLIRepositoryTestCase {
@Test @Test
public void testExistingBranch() throws Exception { public void testExistingBranch() throws Exception {
assertEquals("A branch named 'master' already exists.", assertEquals("fatal: A branch named 'master' already exists.",
execute("git branch master")[0]); execute("git branch master")[0]);
} }
} }

4
org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/CheckoutTest.java

@ -83,13 +83,13 @@ public class CheckoutTest extends CLIRepositoryTestCase {
public void testCheckoutNewBranchThatAlreadyExists() throws Exception { public void testCheckoutNewBranchThatAlreadyExists() throws Exception {
new Git(db).commit().setMessage("initial commit").call(); new Git(db).commit().setMessage("initial commit").call();
assertEquals("A branch named 'master' already exists.", assertEquals("fatal: A branch named 'master' already exists.",
execute("git checkout -b master")); execute("git checkout -b master"));
} }
@Test @Test
public void testCheckoutNewBranchOnBranchToBeBorn() throws Exception { public void testCheckoutNewBranchOnBranchToBeBorn() throws Exception {
assertEquals("You are on a branch yet to be born", assertEquals("fatal: You are on a branch yet to be born",
execute("git checkout -b side")); execute("git checkout -b side"));
} }

1
org.eclipse.jgit.pgm/resources/org/eclipse/jgit/pgm/CLIText.properties

@ -53,7 +53,6 @@ failedToCommitIndex=failed to commit index
failedToLockIndex=failed to lock index failedToLockIndex=failed to lock index
failedToLockTag=Failed to lock tag {0}: {1} failedToLockTag=Failed to lock tag {0}: {1}
fatalError=fatal: {0} fatalError=fatal: {0}
fatalErrorTagExists=fatal: tag '{0}' exists
fatalThisProgramWillDestroyTheRepository=fatal: This program will destroy the repository\nfatal:\nfatal:\nfatal: {0}\nfatal:\nfatal: To continue, add {1} to the command line\nfatal: fatalThisProgramWillDestroyTheRepository=fatal: This program will destroy the repository\nfatal:\nfatal:\nfatal: {0}\nfatal:\nfatal: To continue, add {1} to the command line\nfatal:
fileIsRequired=argument file is required fileIsRequired=argument file is required
forcedUpdate=forced update forcedUpdate=forced update

1
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/CLIText.java

@ -120,7 +120,6 @@ public class CLIText extends TranslationBundle {
/***/ public String failedToLockIndex; /***/ public String failedToLockIndex;
/***/ public String failedToLockTag; /***/ public String failedToLockTag;
/***/ public String fatalError; /***/ public String fatalError;
/***/ public String fatalErrorTagExists;
/***/ public String fatalThisProgramWillDestroyTheRepository; /***/ public String fatalThisProgramWillDestroyTheRepository;
/***/ public String fileIsRequired; /***/ public String fileIsRequired;
/***/ public String forcedUpdate; /***/ public String forcedUpdate;

Loading…
Cancel
Save