Browse Source

Refactor: optimize println!()

Clippy 1.58.0 complains about `format!()` inside `println!()` being
inefficient
pull/1782/head
RageKnify 3 years ago
parent
commit
7f18d7a851
No known key found for this signature in database
GPG Key ID: 85888AA0534EEE81
  1. 29
      boa_tester/src/results.rs

29
boa_tester/src/results.rs

@ -253,24 +253,21 @@ pub(crate) fn compare_results(base: &Path, new: &Path, markdown: bool) {
diff_format(panic_diff), diff_format(panic_diff),
); );
println!( println!(
"| Conformance | {:.2}% | {:.2}% | {} |", "| Conformance | {:.2}% | {:.2}% | {}{}{:.2}%{} |",
base_conformance, base_conformance,
new_conformance, new_conformance,
format!( if conformance_diff.abs() > f64::EPSILON {
"{}{}{:.2}%{}", "**"
if conformance_diff.abs() > f64::EPSILON { } else {
"**" ""
} else { },
"" if conformance_diff > 0_f64 { "+" } else { "" },
}, conformance_diff,
if conformance_diff > 0_f64 { "+" } else { "" }, if conformance_diff.abs() > f64::EPSILON {
conformance_diff, "**"
if conformance_diff.abs() > f64::EPSILON { } else {
"**" ""
} else { },
""
},
),
); );
if !test_diff.fixed.is_empty() { if !test_diff.fixed.is_empty() {

Loading…
Cancel
Save