@ -35,21 +35,85 @@ pub(crate) fn array_exotic_define_own_property(
PropertyKey ::String ( ref s ) if s = = "length" = > {
// a. Return ? ArraySetLength(A, Desc).
// Abstract operation `ArraySetLength ( A, Desc )`
//
// https://tc39.es/ecma262/#sec-arraysetlength
array_set_length ( obj , desc , context )
}
// 3. Else if P is an array index, then
PropertyKey ::Index ( index ) if index < u32 ::MAX = > {
// a. Let oldLenDesc be OrdinaryGetOwnProperty(A, "length").
let old_len_desc = super ::ordinary_get_own_property ( obj , & "length" . into ( ) , context ) ?
. expect ( "the property descriptor must exist" ) ;
// b. Assert: ! IsDataDescriptor(oldLenDesc) is true.
debug_assert! ( old_len_desc . is_data_descriptor ( ) ) ;
// c. Assert: oldLenDesc.[[Configurable]] is false.
debug_assert! ( ! old_len_desc . expect_configurable ( ) ) ;
// d. Let oldLen be oldLenDesc.[[Value]].
// e. Assert: oldLen is a non-negative integral Number.
// f. Let index be ! ToUint32(P).
let old_len = old_len_desc
. expect_value ( )
. to_u32 ( context )
. expect ( "this ToUint32 call must not fail" ) ;
// g. If index ≥ oldLen and oldLenDesc.[[Writable]] is false, return false.
if index > = old_len & & ! old_len_desc . expect_writable ( ) {
return Ok ( false ) ;
}
// h. Let succeeded be ! OrdinaryDefineOwnProperty(A, P, Desc).
if super ::ordinary_define_own_property ( obj , key , desc , context ) ? {
// j. If index ≥ oldLen, then
if index > = old_len {
// i. Set oldLenDesc.[[Value]] to index + 1𝔽.
let old_len_desc = PropertyDescriptor ::builder ( )
. value ( index + 1 )
. maybe_writable ( old_len_desc . writable ( ) )
. maybe_enumerable ( old_len_desc . enumerable ( ) )
. maybe_configurable ( old_len_desc . configurable ( ) ) ;
// ii. Set succeeded to OrdinaryDefineOwnProperty(A, "length", oldLenDesc).
let succeeded = super ::ordinary_define_own_property (
obj ,
"length" . into ( ) ,
old_len_desc . into ( ) ,
context ,
) ? ;
// iii. Assert: succeeded is true.
debug_assert! ( succeeded ) ;
}
// k. Return true.
Ok ( true )
} else {
// i. If succeeded is false, return false.
Ok ( false )
}
}
// 4. Return OrdinaryDefineOwnProperty(A, P, Desc).
_ = > super ::ordinary_define_own_property ( obj , key , desc , context ) ,
}
}
/// Abstract operation `ArraySetLength ( A, Desc )`
///
/// More information:
/// - [ECMAScript reference][spec]
///
/// [spec]: https://tc39.es/ecma262/#sec-arraysetlength
fn array_set_length (
obj : & JsObject ,
desc : PropertyDescriptor ,
context : & mut Context ,
) -> JsResult < bool > {
// 1. If Desc.[[Value]] is absent, then
let new_len_val = match desc . value ( ) {
Some ( value ) = > value ,
_ = > {
// a. Return OrdinaryDefineOwnProperty(A, "length", Desc).
return super ::ordinary_define_own_property (
obj ,
"length" . into ( ) ,
desc ,
context ,
) ;
return super ::ordinary_define_own_property ( obj , "length" . into ( ) , desc , context ) ;
}
} ;
@ -74,8 +138,8 @@ pub(crate) fn array_exotic_define_own_property(
. maybe_configurable ( desc . configurable ( ) ) ;
// 7. Let oldLenDesc be OrdinaryGetOwnProperty(A, "length").
let old_len_desc =
super ::ordinary_get_own_property ( obj , & "length" . into ( ) , context ) ? . unwrap ( ) ;
let old_len_desc = super ::ordinary_get_own_property ( obj , & "length" . into ( ) , context ) ?
. expect ( "the property descriptor must exist" ) ;
// 8. Assert: ! IsDataDescriptor(oldLenDesc) is true.
debug_assert! ( old_len_desc . is_data_descriptor ( ) ) ;
@ -125,7 +189,7 @@ pub(crate) fn array_exotic_define_own_property(
new_len_desc . clone ( ) . build ( ) ,
context ,
)
. unwrap ( )
. expect ( "this OrdinaryDefineOwnProperty call must not fail" )
{
return Ok ( false ) ;
}
@ -163,7 +227,7 @@ pub(crate) fn array_exotic_define_own_property(
new_len_desc . build ( ) ,
context ,
)
. unwrap ( ) ;
. expect ( "this OrdinaryDefineOwnProperty call must not fail" ) ;
// iv. Return false.
return Ok ( false ) ;
@ -179,7 +243,8 @@ pub(crate) fn array_exotic_define_own_property(
"length" . into ( ) ,
PropertyDescriptor ::builder ( ) . writable ( false ) . build ( ) ,
context ,
) ? ;
)
. expect ( "this OrdinaryDefineOwnProperty call must not fail" ) ;
// b. Assert: succeeded is true.
debug_assert! ( succeeded ) ;
@ -187,62 +252,4 @@ pub(crate) fn array_exotic_define_own_property(
// 19. Return true.
Ok ( true )
}
// 3. Else if P is an array index, then
PropertyKey ::Index ( index ) if index < u32 ::MAX = > {
// a. Let oldLenDesc be OrdinaryGetOwnProperty(A, "length").
let old_len_desc =
super ::ordinary_get_own_property ( obj , & "length" . into ( ) , context ) ? . unwrap ( ) ;
// b. Assert: ! IsDataDescriptor(oldLenDesc) is true.
debug_assert! ( old_len_desc . is_data_descriptor ( ) ) ;
// c. Assert: oldLenDesc.[[Configurable]] is false.
debug_assert! ( ! old_len_desc . expect_configurable ( ) ) ;
// d. Let oldLen be oldLenDesc.[[Value]].
// e. Assert: oldLen is a non-negative integral Number.
// f. Let index be ! ToUint32(P).
let old_len = old_len_desc . expect_value ( ) . to_u32 ( context ) . unwrap ( ) ;
// g. If index ≥ oldLen and oldLenDesc.[[Writable]] is false, return false.
if index > = old_len & & ! old_len_desc . expect_writable ( ) {
return Ok ( false ) ;
}
// h. Let succeeded be ! OrdinaryDefineOwnProperty(A, P, Desc).
if super ::ordinary_define_own_property ( obj , key , desc , context ) ? {
// j. If index ≥ oldLen, then
if index > = old_len {
// i. Set oldLenDesc.[[Value]] to index + 1𝔽.
let old_len_desc = PropertyDescriptor ::builder ( )
. value ( index + 1 )
. maybe_writable ( old_len_desc . writable ( ) )
. maybe_enumerable ( old_len_desc . enumerable ( ) )
. maybe_configurable ( old_len_desc . configurable ( ) ) ;
// ii. Set succeeded to OrdinaryDefineOwnProperty(A, "length", oldLenDesc).
let succeeded = super ::ordinary_define_own_property (
obj ,
"length" . into ( ) ,
old_len_desc . into ( ) ,
context ,
)
. unwrap ( ) ;
// iii. Assert: succeeded is true.
debug_assert! ( succeeded ) ;
}
// k. Return true.
Ok ( true )
} else {
// i. If succeeded is false, return false.
Ok ( false )
}
}
// 4. Return OrdinaryDefineOwnProperty(A, P, Desc).
_ = > super ::ordinary_define_own_property ( obj , key , desc , context ) ,
}
}
Iban Eguia
3 years ago