github
/
boa
mirror of https://github.com/boa-dev/boa.git
1
0
Fork 0
Code Issues Releases Wiki Activity
Browse Source

Create `Date` standard constructor (#2079) 

Apparently we didn't have a `Date` intrinsic constructor, we were setting the prototype of all `Date` objects to the `Object` prototype.
pull/2078/head
jedel1043 2 years ago
parent
fcf456e5de
commit
29330225ef
2 changed files with 74 additions and 63 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 130
      boa_engine/src/builtins/date/mod.rs
  2. 7
      boa_engine/src/context/intrinsics.rs

130
boa_engine/src/builtins/date/mod.rs
Unescape View File

@ -91,68 +91,72 @@ impl BuiltIn for Date {
fn init(context: &mut Context) -> Option<JsValue> { fn init(context: &mut Context) -> Option<JsValue> {
let _timer = Profiler::global().start_event(Self::NAME, "init"); let _timer = Profiler::global().start_event(Self::NAME, "init");
ConstructorBuilder::new(context, Self::constructor) ConstructorBuilder::with_standard_constructor(
.name(Self::NAME) context,
.length(Self::LENGTH) Self::constructor,
.method(getter_method!(get_date), "getDate", 0) context.intrinsics().constructors().date().clone(),
.method(getter_method!(get_day), "getDay", 0) )
.method(getter_method!(get_full_year), "getFullYear", 0) .name(Self::NAME)
.method(getter_method!(get_hours), "getHours", 0) .length(Self::LENGTH)
.method(getter_method!(get_milliseconds), "getMilliseconds", 0) .method(getter_method!(get_date), "getDate", 0)
.method(getter_method!(get_minutes), "getMinutes", 0) .method(getter_method!(get_day), "getDay", 0)
.method(getter_method!(get_month), "getMonth", 0) .method(getter_method!(get_full_year), "getFullYear", 0)
.method(getter_method!(get_seconds), "getSeconds", 0) .method(getter_method!(get_hours), "getHours", 0)
.method(getter_method!(get_time), "getTime", 0) .method(getter_method!(get_milliseconds), "getMilliseconds", 0)
.method(getter_method!(get_year), "getYear", 0) .method(getter_method!(get_minutes), "getMinutes", 0)
.method(Self::get_timezone_offset, "getTimezoneOffset", 0) .method(getter_method!(get_month), "getMonth", 0)
.method(getter_method!(get_utc_date), "getUTCDate", 0) .method(getter_method!(get_seconds), "getSeconds", 0)
.method(getter_method!(get_utc_day), "getUTCDay", 0) .method(getter_method!(get_time), "getTime", 0)
.method(getter_method!(get_utc_full_year), "getUTCFullYear", 0) .method(getter_method!(get_year), "getYear", 0)
.method(getter_method!(get_utc_hours), "getUTCHours", 0) .method(Self::get_timezone_offset, "getTimezoneOffset", 0)
.method( .method(getter_method!(get_utc_date), "getUTCDate", 0)
getter_method!(get_utc_milliseconds), .method(getter_method!(get_utc_day), "getUTCDay", 0)
"getUTCMilliseconds", .method(getter_method!(get_utc_full_year), "getUTCFullYear", 0)
0, .method(getter_method!(get_utc_hours), "getUTCHours", 0)
) .method(
.method(getter_method!(get_utc_minutes), "getUTCMinutes", 0) getter_method!(get_utc_milliseconds),
.method(getter_method!(get_utc_month), "getUTCMonth", 0) "getUTCMilliseconds",
.method(getter_method!(get_utc_seconds), "getUTCSeconds", 0) 0,
.method(Self::set_date, "setDate", 1) )
.method(Self::set_full_year, "setFullYear", 3) .method(getter_method!(get_utc_minutes), "getUTCMinutes", 0)
.method(Self::set_hours, "setHours", 4) .method(getter_method!(get_utc_month), "getUTCMonth", 0)
.method(Self::set_milliseconds, "setMilliseconds", 1) .method(getter_method!(get_utc_seconds), "getUTCSeconds", 0)
.method(Self::set_minutes, "setMinutes", 3) .method(Self::set_date, "setDate", 1)
.method(Self::set_month, "setMonth", 2) .method(Self::set_full_year, "setFullYear", 3)
.method(Self::set_seconds, "setSeconds", 2) .method(Self::set_hours, "setHours", 4)
.method(Self::set_year, "setYear", 1) .method(Self::set_milliseconds, "setMilliseconds", 1)
.method(Self::set_time, "setTime", 1) .method(Self::set_minutes, "setMinutes", 3)
.method(Self::set_utc_date, "setUTCDate", 1) .method(Self::set_month, "setMonth", 2)
.method(Self::set_utc_full_year, "setUTCFullYear", 3) .method(Self::set_seconds, "setSeconds", 2)
.method(Self::set_utc_hours, "setUTCHours", 4) .method(Self::set_year, "setYear", 1)
.method(Self::set_utc_milliseconds, "setUTCMilliseconds", 1) .method(Self::set_time, "setTime", 1)
.method(Self::set_utc_minutes, "setUTCMinutes", 3) .method(Self::set_utc_date, "setUTCDate", 1)
.method(Self::set_utc_month, "setUTCMonth", 2) .method(Self::set_utc_full_year, "setUTCFullYear", 3)
.method(Self::set_utc_seconds, "setUTCSeconds", 2) .method(Self::set_utc_hours, "setUTCHours", 4)
.method(Self::to_date_string, "toDateString", 0) .method(Self::set_utc_milliseconds, "setUTCMilliseconds", 1)
.method(getter_method!(to_gmt_string), "toGMTString", 0) .method(Self::set_utc_minutes, "setUTCMinutes", 3)
.method(Self::to_iso_string, "toISOString", 0) .method(Self::set_utc_month, "setUTCMonth", 2)
.method(Self::to_json, "toJSON", 1) .method(Self::set_utc_seconds, "setUTCSeconds", 2)
// Locale strings .method(Self::to_date_string, "toDateString", 0)
.method(Self::to_string, "toString", 0) .method(getter_method!(to_gmt_string), "toGMTString", 0)
.method(Self::to_time_string, "toTimeString", 0) .method(Self::to_iso_string, "toISOString", 0)
.method(getter_method!(to_utc_string), "toUTCString", 0) .method(Self::to_json, "toJSON", 1)
.method(getter_method!(value_of), "valueOf", 0) // Locale strings
.method( .method(Self::to_string, "toString", 0)
Self::to_primitive, .method(Self::to_time_string, "toTimeString", 0)
(WellKnownSymbols::to_primitive(), "[Symbol.toPrimitive]"), .method(getter_method!(to_utc_string), "toUTCString", 0)
1, .method(getter_method!(value_of), "valueOf", 0)
) .method(
.static_method(Self::now, "now", 0) Self::to_primitive,
.static_method(Self::parse, "parse", 1) (WellKnownSymbols::to_primitive(), "[Symbol.toPrimitive]"),
.static_method(Self::utc, "UTC", 7) 1,
.build() )
.conv::<JsValue>() .static_method(Self::now, "now", 0)
.pipe(Some) .static_method(Self::parse, "parse", 1)
.static_method(Self::utc, "UTC", 7)
.build()
.conv::<JsValue>()
.pipe(Some)
} }
} }
@ -337,7 +341,7 @@ impl Date {
Ok(Self::make_date_string()) Ok(Self::make_date_string())
} else { } else {
let prototype = let prototype =
get_prototype_from_constructor(new_target, StandardConstructors::object, context)?; get_prototype_from_constructor(new_target, StandardConstructors::date, context)?;
Ok(if args.is_empty() { Ok(if args.is_empty() {
Self::make_date_now(prototype) Self::make_date_now(prototype)
} else if args.len() == 1 { } else if args.len() == 1 {

7
boa_engine/src/context/intrinsics.rs
Unescape View File

@ -74,6 +74,7 @@ impl StandardConstructor {
pub struct StandardConstructors { pub struct StandardConstructors {
object: StandardConstructor, object: StandardConstructor,
proxy: StandardConstructor, proxy: StandardConstructor,
date: StandardConstructor,
function: StandardConstructor, function: StandardConstructor,
generator: StandardConstructor, generator: StandardConstructor,
generator_function: StandardConstructor, generator_function: StandardConstructor,
@ -116,6 +117,7 @@ impl Default for StandardConstructors {
let result = Self { let result = Self {
object: StandardConstructor::default(), object: StandardConstructor::default(),
proxy: StandardConstructor::default(), proxy: StandardConstructor::default(),
date: StandardConstructor::default(),
function: StandardConstructor::default(), function: StandardConstructor::default(),
generator: StandardConstructor::default(), generator: StandardConstructor::default(),
generator_function: StandardConstructor::default(), generator_function: StandardConstructor::default(),
@ -191,6 +193,11 @@ impl StandardConstructors {
&self.proxy &self.proxy
} }
#[inline]
pub fn date(&self) -> &StandardConstructor {
&self.date
}
#[inline] #[inline]
pub fn function(&self) -> &StandardConstructor { pub fn function(&self) -> &StandardConstructor {
&self.function &self.function

Write Preview
Loading…
Cancel
Save