Browse Source

[Bug-8067][LogServer] fix improper use of StringBuilder (#8365)

fix code format and fix spelling errors
3.0.0/version-upgrade
弘树丶 3 years ago committed by GitHub
parent
commit
b9406d356c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 11
      dolphinscheduler-log-server/src/main/java/org/apache/dolphinscheduler/server/log/LoggerRequestProcessor.java

11
dolphinscheduler-log-server/src/main/java/org/apache/dolphinscheduler/server/log/LoggerRequestProcessor.java

@ -70,9 +70,7 @@ public class LoggerRequestProcessor implements NettyRequestProcessor {
public void process(Channel channel, Command command) { public void process(Channel channel, Command command) {
logger.info("received command : {}", command); logger.info("received command : {}", command);
/** //request task log command type
* reuqest task log command type
*/
final CommandType commandType = command.getType(); final CommandType commandType = command.getType();
switch (commandType) { switch (commandType) {
case GET_LOG_BYTES_REQUEST: case GET_LOG_BYTES_REQUEST:
@ -96,7 +94,7 @@ public class LoggerRequestProcessor implements NettyRequestProcessor {
rollViewLogRequest.getSkipLineNum(), rollViewLogRequest.getLimit()); rollViewLogRequest.getSkipLineNum(), rollViewLogRequest.getLimit());
StringBuilder builder = new StringBuilder(); StringBuilder builder = new StringBuilder();
for (String line : lines) { for (String line : lines) {
builder.append(line + "\r\n"); builder.append(line).append("\r\n");
} }
RollViewLogResponseCommand rollViewLogRequestResponse = new RollViewLogResponseCommand(builder.toString()); RollViewLogResponseCommand rollViewLogRequestResponse = new RollViewLogResponseCommand(builder.toString());
channel.writeAndFlush(rollViewLogRequestResponse.convert2Command(command.getOpaque())); channel.writeAndFlush(rollViewLogRequestResponse.convert2Command(command.getOpaque()));
@ -108,7 +106,7 @@ public class LoggerRequestProcessor implements NettyRequestProcessor {
String taskLogPath = removeTaskLogRequest.getPath(); String taskLogPath = removeTaskLogRequest.getPath();
File taskLogFile = new File(taskLogPath); File taskLogFile = new File(taskLogPath);
Boolean status = true; boolean status = true;
try { try {
if (taskLogFile.exists()) { if (taskLogFile.exists()) {
status = taskLogFile.delete(); status = taskLogFile.delete();
@ -130,11 +128,10 @@ public class LoggerRequestProcessor implements NettyRequestProcessor {
} }
/** /**
* get files content bytesfor down load file * get files content bytes for download file
* *
* @param filePath file path * @param filePath file path
* @return byte array of file * @return byte array of file
* @throws Exception exception
*/ */
private byte[] getFileContentBytes(String filePath) { private byte[] getFileContentBytes(String filePath) {
try (InputStream in = new FileInputStream(filePath); try (InputStream in = new FileInputStream(filePath);

Loading…
Cancel
Save