Browse Source

[Improvement][API] add PageInfo UT (#15622)

Signed-off-by: Gallardot <gallardot@apache.org>
Co-authored-by: xiangzihao <460888207@qq.com>
dev_wenjun_refactorMaster
Gallardot 9 months ago committed by GitHub
parent
commit
b278df1311
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java
  2. 48
      dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/PageInfoTest.java

2
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java

@ -80,7 +80,7 @@ public class PageInfo<T> {
public Integer getTotalPage() { public Integer getTotalPage() {
if (pageSize == null || pageSize == 0) { if (pageSize == null || pageSize == 0) {
pageSize = 7; pageSize = 10;
} }
this.totalPage = this.totalPage =
(this.total % this.pageSize) == 0 (this.total % this.pageSize) == 0

48
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/PageInfoTest.java

@ -0,0 +1,48 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.api.utils;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
public class PageInfoTest {
@Test
public void testGetTotalPageWhenTotalAndPageSizeArePositive() {
PageInfo<Object> pageInfo = new PageInfo<>();
pageInfo.setTotal(100);
pageInfo.setPageSize(20);
Assertions.assertEquals(5, pageInfo.getTotalPage());
}
@Test
public void testGetTotalPageWhenTotalIsZero() {
PageInfo<Object> pageInfo = new PageInfo<>();
pageInfo.setTotal(0);
pageInfo.setPageSize(20);
Assertions.assertEquals(1, pageInfo.getTotalPage());
}
@Test
public void testGetTotalPageWhenPageSizeIsZero() {
PageInfo<Object> pageInfo = new PageInfo<>();
pageInfo.setTotal(101);
pageInfo.setPageSize(0);
Assertions.assertEquals(11, pageInfo.getTotalPage());
}
}
Loading…
Cancel
Save