[Improvement][common] Add UnsupportedOperationException for utils construct (#3381)

* [Improvement][common] Add UnsupportedOperationException for utils construct * Fix checkstyle
4 years ago · ac4ed94061
25 changed files with 1313 additions and 1204 deletions
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
@ -14,6 +14,7 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common;

 import org.apache.dolphinscheduler.common.enums.ExecutionStatus;
@ -27,7 +28,7 @@ import java.util.regex.Pattern;
 public final class Constants {

    private Constants() {
-        throw new IllegalStateException("Constants class");
+        throw new UnsupportedOperationException("Construct Constants");
    }

    /**
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/CollectionUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/CollectionUtils.java
@ -14,13 +14,19 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

 import org.apache.commons.beanutils.BeanMap;
-import org.apache.commons.lang.StringUtils;
-
-import java.util.*;

+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;

 /**
 * Provides utility methods and decorators for {@link Collection} instances.
@ -37,8 +43,9 @@ import java.util.*;
 public class CollectionUtils {

    private CollectionUtils() {
-        throw new IllegalStateException("CollectionUtils class");
+        throw new UnsupportedOperationException("Construct CollectionUtils");
    }
+
    /**
     * Returns a new {@link Collection} containing <i>a</i> minus a subset of
     * <i>b</i>.  Only the elements of <i>b</i> that satisfy the predicate
@ -112,7 +119,6 @@ public class CollectionUtils {
        return map;
    }

-
    /**
     * Helper class to easily access cardinality properties of two collections.
     *
@ -137,8 +143,8 @@ public class CollectionUtils {
         * @param b the second collection
         */
        public CardinalityHelper(final Iterable<? extends O> a, final Iterable<? extends O> b) {
-            cardinalityA = CollectionUtils.<O>getCardinalityMap(a);
-            cardinalityB = CollectionUtils.<O>getCardinalityMap(b);
+            cardinalityA = CollectionUtils.getCardinalityMap(a);
+            cardinalityB = CollectionUtils.getCardinalityMap(b);
        }

        /**
@ -239,9 +245,9 @@ public class CollectionUtils {
        return count;
    }

-
    /**
     * Removes certain attributes of each object in the list
+     *
     * @param originList origin list
     * @param exclusionSet exclusion set
     * @param <T> T
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/CommonUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/CommonUtils.java
@ -14,19 +14,22 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

-import org.apache.commons.codec.binary.Base64;
 import org.apache.dolphinscheduler.common.Constants;
 import org.apache.dolphinscheduler.common.enums.ResUploadType;
+
+import org.apache.commons.codec.binary.Base64;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.security.UserGroupInformation;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;

 import java.net.URL;
 import java.nio.charset.StandardCharsets;

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
 * common utils
 */
@ -36,7 +39,7 @@ public class CommonUtils {
    private static final Base64 BASE64 = new Base64();

    private CommonUtils() {
-    throw new IllegalStateException("CommonUtils class");
+        throw new UnsupportedOperationException("Construct CommonUtils");
    }

    /**
@ -59,17 +62,15 @@ public class CommonUtils {
    }

    /**
-   * 
     * @return is develop mode
     */
    public static boolean isDevelopMode() {
        return PropertyUtils.getBoolean(Constants.DEVELOPMENT_STATE, true);
    }

-
-
    /**
     * if upload resource is HDFS and kerberos startup is true , else false
+     *
     * @return true if upload resource is HDFS and kerberos startup
     */
    public static boolean getKerberosStartupState() {
@ -81,6 +82,7 @@ public class CommonUtils {

    /**
     * load kerberos configuration
+     *
     * @throws Exception errors
     */
    public static void loadKerberosConf() throws Exception {
@ -96,14 +98,16 @@ public class CommonUtils {

    /**
     * encode password
-   * @param password
-   * @return
     */
    public static String encodePassword(String password) {
-    if(StringUtils.isEmpty(password)){return StringUtils.EMPTY; }
+        if (StringUtils.isEmpty(password)) {
+            return StringUtils.EMPTY;
+        }
        //if encryption is not turned on, return directly
        boolean encryptionEnable = PropertyUtils.getBoolean(Constants.DATASOURCE_ENCRYPTION_ENABLE, false);
-    if ( !encryptionEnable){ return password; }
+        if (!encryptionEnable) {
+            return password;
+        }

        // Using Base64 + salt to process password
        String salt = PropertyUtils.getString(Constants.DATASOURCE_ENCRYPTION_SALT, Constants.DATASOURCE_ENCRYPTION_SALT_DEFAULT);
@ -113,15 +117,17 @@ public class CommonUtils {

    /**
     * decode password
-   * @param password
-   * @return
     */
    public static String decodePassword(String password) {
-    if(StringUtils.isEmpty(password)){return StringUtils.EMPTY ; }
+        if (StringUtils.isEmpty(password)) {
+            return StringUtils.EMPTY;
+        }

        //if encryption is not turned on, return directly
        boolean encryptionEnable = PropertyUtils.getBoolean(Constants.DATASOURCE_ENCRYPTION_ENABLE, false);
-    if ( !encryptionEnable){ return password; }
+        if (!encryptionEnable) {
+            return password;
+        }

        // Using Base64 + salt to process password
        String salt = PropertyUtils.getString(Constants.DATASOURCE_ENCRYPTION_SALT, Constants.DATASOURCE_ENCRYPTION_SALT_DEFAULT);
@ -133,5 +139,4 @@ public class CommonUtils {
        return new String(BASE64.decode(passwordWithSalt.substring(salt.length())), StandardCharsets.UTF_8);
    }

-
 }
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ConnectionUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ConnectionUtils.java
@ -14,10 +14,12 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

 import java.util.Arrays;
 import java.util.Objects;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

@ -26,11 +28,12 @@ public class ConnectionUtils {
    public static final Logger logger = LoggerFactory.getLogger(ConnectionUtils.class);

    private ConnectionUtils() {
-    throw new IllegalStateException("ConnectionUtils class");
+        throw new UnsupportedOperationException("Construct ConnectionUtils");
    }

    /**
     * release resource
+     *
     * @param resources resources
     */
    public static void releaseResource(AutoCloseable... resources) {
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/DateUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/DateUtils.java
@ -36,6 +36,10 @@ public class DateUtils {

    private static final Logger logger = LoggerFactory.getLogger(DateUtils.class);

+    private DateUtils() {
+        throw new UnsupportedOperationException("Construct DateUtils");
+    }
+
    /**
     * date to local datetime
     *
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/DependentUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/DependentUtils.java
@ -20,8 +20,6 @@ import org.apache.dolphinscheduler.common.enums.DependResult;
 import org.apache.dolphinscheduler.common.enums.DependentRelation;
 import org.apache.dolphinscheduler.common.model.DateInterval;
 import org.apache.dolphinscheduler.common.utils.dependent.DependentDateUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;

 import java.util.ArrayList;
 import java.util.Date;
@ -29,7 +27,9 @@ import java.util.List;

 public class DependentUtils {

-    private static final Logger logger = LoggerFactory.getLogger(DependentUtils.class);
+    private DependentUtils() {
+        throw new UnsupportedOperationException("Construct DependentUtils");
+    }

    public static DependResult getDependResultForRelation(DependentRelation relation,
                                                          List<DependResult> dependResultList) {
@ -40,7 +40,8 @@ public class DependentUtils {
            case AND:
                if (dependResultList.contains(DependResult.FAILED)) {
                    dependResult = DependResult.FAILED;
-                } if(dependResultList.contains(DependResult.WAITING)){
+                }
+                if (dependResultList.contains(DependResult.WAITING)) {
                    dependResult = DependResult.WAITING;
                }
                break;
@ -62,6 +63,7 @@ public class DependentUtils {

    /**
     * get date interval list by business date and date value.
+     *
     * @param businessDate business date
     * @param dateValue date value
     * @return date interval list by business date and date value.
@ -144,5 +146,4 @@ public class DependentUtils {
        return result;
    }

-
 }
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/EncryptionUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/EncryptionUtils.java
@ -14,6 +14,7 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

 import org.apache.commons.codec.digest.DigestUtils;
@ -23,9 +24,11 @@ import org.apache.commons.codec.digest.DigestUtils;
 */
 public class EncryptionUtils {

+    private EncryptionUtils() {
+        throw new UnsupportedOperationException("Construct EncryptionUtils");
+    }

    /**
-     * 
     * @param rawStr raw string
     * @return md5(rawStr)
     */
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/EnumUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/EnumUtils.java
@ -14,12 +14,15 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
-package org.apache.dolphinscheduler.common.utils;
-

+package org.apache.dolphinscheduler.common.utils;

 public class EnumUtils {

+    private EnumUtils() {
+        throw new UnsupportedOperationException("Construct EnumUtils");
+    }
+
    public static <E extends Enum<E>> E getEnum(final Class<E> enumClass, final String enumName) {
        if (enumName == null) {
            return null;
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java
@ -14,6 +14,7 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

 import static org.apache.dolphinscheduler.common.Constants.DATA_BASEDIR_PATH;
@ -21,6 +22,9 @@ import static org.apache.dolphinscheduler.common.Constants.RESOURCE_VIEW_SUFFIXS
 import static org.apache.dolphinscheduler.common.Constants.RESOURCE_VIEW_SUFFIXS_DEFAULT_VALUE;
 import static org.apache.dolphinscheduler.common.Constants.YYYYMMDDHHMMSS;

+import org.apache.commons.io.Charsets;
+import org.apache.commons.io.IOUtils;
+
 import java.io.BufferedReader;
 import java.io.BufferedWriter;
 import java.io.ByteArrayOutputStream;
@ -36,9 +40,6 @@ import java.nio.charset.Charset;
 import java.nio.charset.UnsupportedCharsetException;
 import java.util.Optional;

-import org.apache.commons.io.Charsets;
-import org.apache.commons.io.IOUtils;
-import org.apache.commons.lang.StringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

@ -46,12 +47,17 @@ import org.slf4j.LoggerFactory;
 * file utils
 */
 public class FileUtils {
+
    public static final Logger logger = LoggerFactory.getLogger(FileUtils.class);

    public static final String DATA_BASEDIR = PropertyUtils.getString(DATA_BASEDIR_PATH, "/tmp/dolphinscheduler");

    public static final ThreadLocal<Logger> taskLoggerThreadLocal = new ThreadLocal<>();

+    private FileUtils() {
+        throw new UnsupportedOperationException("Construct FileUtils");
+    }
+
    /**
     * get file suffix
     *
@ -106,6 +112,7 @@ public class FileUtils {

    /**
     * directory of process execution
+     *
     * @param projectId project id
     * @param processDefineId process definition id
     * @param processInstanceId process instance id
@ -125,6 +132,7 @@ public class FileUtils {

    /**
     * directory of process instances
+     *
     * @param projectId project id
     * @param processDefineId process definition id
     * @param processInstanceId process instance id
@ -150,6 +158,7 @@ public class FileUtils {

    /**
     * create directory and user
+     *
     * @param execLocalPath execute local path
     * @param userName user name
     * @throws IOException errors
@ -190,7 +199,6 @@ public class FileUtils {
        OSUtils.taskLoggerThreadLocal.remove();
    }

-
    /**
     * write content to file ,if parent path not exists, it will do one's utmost to mkdir
     *
@ -231,7 +239,7 @@ public class FileUtils {

    /**
     * Writes a String to a file creating the file if it does not exist.
-     *
+     * <p>
     * NOTE: As from v1.3, the parent directories of the file will be created
     * if they do not exist.
     *
@ -248,7 +256,7 @@ public class FileUtils {

    /**
     * Writes a String to a file creating the file if it does not exist.
-     *
+     * <p>
     * NOTE: As from v1.3, the parent directories of the file will be created
     * if they do not exist.
     *
@ -293,8 +301,7 @@ public class FileUtils {
     * @param append if {@code true}, then the String will be added to the
     * end of the file rather than overwriting
     * @throws IOException in case of an I/O error
-     * @throws UnsupportedCharsetException
-     *             thrown instead of {@link UnsupportedEncodingException} in version 2.2 if the encoding is not
+     * @throws UnsupportedCharsetException thrown instead of {@link UnsupportedEncodingException} in version 2.2 if the encoding is not
     * supported by the VM
     * @since 2.1
     */
@ -390,9 +397,9 @@ public class FileUtils {
        return new FileOutputStream(file, append);
    }

-
    /**
     * deletes a directory recursively
+     *
     * @param dir directory
     * @throws IOException in case deletion is unsuccessful
     */
@ -420,6 +427,7 @@ public class FileUtils {

    /**
     * Gets all the parent subdirectories of the parentDir directory
+     *
     * @param parentDir parent dir
     * @return all dirs
     */
@ -438,6 +446,7 @@ public class FileUtils {

    /**
     * Get Content
+     *
     * @param inputStream input stream
     * @return string of input stream
     */
@ -457,5 +466,4 @@ public class FileUtils {
        }
    }

-
 }
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HttpUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HttpUtils.java
@ -14,9 +14,11 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

 import org.apache.dolphinscheduler.common.Constants;
+
 import org.apache.http.HttpEntity;
 import org.apache.http.client.config.AuthSchemes;
 import org.apache.http.client.config.CookieSpecs;
@ -30,31 +32,32 @@ import org.apache.http.conn.socket.PlainConnectionSocketFactory;
 import org.apache.http.conn.ssl.NoopHostnameVerifier;
 import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
 import org.apache.http.impl.client.CloseableHttpClient;
-import org.apache.http.impl.client.DefaultHttpClient;
 import org.apache.http.impl.client.HttpClients;
 import org.apache.http.impl.conn.PoolingHttpClientConnectionManager;
 import org.apache.http.util.EntityUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;

-import javax.net.ssl.SSLContext;
-import javax.net.ssl.TrustManager;
-import javax.net.ssl.X509TrustManager;
 import java.io.IOException;
 import java.security.KeyManagementException;
 import java.security.NoSuchAlgorithmException;
 import java.security.cert.X509Certificate;
 import java.util.Arrays;
+
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.X509TrustManager;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
 * http utils
 */
 public class HttpUtils {

-
    public static final Logger logger = LoggerFactory.getLogger(HttpUtils.class);

    private HttpUtils() {
-
+        throw new UnsupportedOperationException("Construct HttpUtils");
    }

    public static CloseableHttpClient getInstance() {
@ -117,10 +120,9 @@ public class HttpUtils {

    }

-
-
    /**
     * get http request content
+     *
     * @param url url
     * @return http get request response content
     */
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/IOUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/IOUtils.java
@ -1,4 +1,3 @@
-
 /*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
@ -18,12 +17,15 @@

 package org.apache.dolphinscheduler.common.utils;

-
 import java.io.Closeable;
 import java.io.IOException;

 public class IOUtils {

+    private IOUtils() {
+        throw new UnsupportedOperationException("Construct IOUtils");
+    }
+
    public static void closeQuietly(Closeable closeable) {
        if (closeable != null) {
            try {
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/IpUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/IpUtils.java
@ -14,14 +14,18 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
-package org.apache.dolphinscheduler.common.utils;

+package org.apache.dolphinscheduler.common.utils;

 /**
 * http utils
 */
 public class IpUtils {

+    private IpUtils() {
+        throw new UnsupportedOperationException("Construct IpUtils");
+    }
+
    public static final String DOT = ".";

    /**
@ -38,6 +42,7 @@ public class IpUtils {

    /**
     * long to ip
+     *
     * @param ipLong the long number converted from IP
     * @return String
     */
@ -49,11 +54,10 @@ public class IpUtils {
        ipNumbers[2] = ipLong >> 8 & tmp;
        ipNumbers[3] = ipLong & tmp;

-    String sb = ipNumbers[0] + DOT +
-            ipNumbers[1] + DOT +
-            ipNumbers[2] + DOT +
-            ipNumbers[3];
-    return sb;
+        return ipNumbers[0] + DOT
+                + ipNumbers[1] + DOT
+                + ipNumbers[2] + DOT
+                + ipNumbers[3];
    }

 }
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
@ -14,25 +14,39 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

+import static com.fasterxml.jackson.databind.DeserializationFeature.ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT;
+import static com.fasterxml.jackson.databind.DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES;
+import static com.fasterxml.jackson.databind.DeserializationFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL;
+import static com.fasterxml.jackson.databind.MapperFeature.REQUIRE_SETTERS_FOR_GETTERS;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.TimeZone;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.core.type.TypeReference;
-import com.fasterxml.jackson.databind.*;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.JsonDeserializer;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.JsonSerializer;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.ObjectWriter;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.fasterxml.jackson.databind.node.TextNode;
 import com.fasterxml.jackson.databind.type.CollectionType;
-import org.apache.commons.lang.StringUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.io.IOException;
-import java.util.*;
-
-import static com.fasterxml.jackson.databind.DeserializationFeature.*;
-import static com.fasterxml.jackson.databind.MapperFeature.REQUIRE_SETTERS_FOR_GETTERS;

 /**
 * json utils
@ -49,13 +63,12 @@ public class JSONUtils {
            .configure(ACCEPT_EMPTY_ARRAY_AS_NULL_OBJECT, true)
            .configure(READ_UNKNOWN_ENUM_VALUES_AS_NULL, true)
            .configure(REQUIRE_SETTERS_FOR_GETTERS, true)
-            .setTimeZone(TimeZone.getDefault())
-            ;
+            .setTimeZone(TimeZone.getDefault());

    private JSONUtils() {
+        throw new UnsupportedOperationException("Construct JSONUtils");
    }

-
    public static ArrayNode createArrayNode() {
        return objectMapper.createArrayNode();
    }
@ -137,7 +150,6 @@ public class JSONUtils {
        return Collections.emptyList();
    }

-
    /**
     * check json object valid
     *
@ -160,7 +172,6 @@ public class JSONUtils {
        return false;
    }

-
    /**
     * Method for finding a JSON Object field with specified name in this
     * node or its child nodes, and returning value it has.
@ -180,7 +191,6 @@ public class JSONUtils {
        return node.toString();
    }

-
    /**
     * json to map
     * <p>
@ -195,7 +205,8 @@ public class JSONUtils {
        }

        try {
-            return objectMapper.readValue(json, new TypeReference<Map<String, String>>() {});
+            return objectMapper.readValue(json, new TypeReference<Map<String, String>>() {
+            });
        } catch (Exception e) {
            logger.error("json to map exception!", e);
        }
@ -258,7 +269,6 @@ public class JSONUtils {
        }
    }

-
    /**
     * json serializer
     */
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/LoggerUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/LoggerUtils.java
@ -14,15 +14,17 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

+import org.apache.dolphinscheduler.common.Constants;
+
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;

-import org.apache.dolphinscheduler.common.Constants;
 import org.slf4j.Logger;

 /**
@ -30,6 +32,10 @@ import org.slf4j.Logger;
 */
 public class LoggerUtils {

+    private LoggerUtils() {
+        throw new UnsupportedOperationException("Construct LoggerUtils");
+    }
+
    /**
     * rules for extracting application ID
     */
@ -70,10 +76,10 @@ public class LoggerUtils {
                taskId);
    }

-
    /**
     * processing log
     * get yarn application id list
+     *
     * @param log log content
     * @param logger logger
     * @return app id list
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
@ -14,27 +14,36 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import static org.apache.dolphinscheduler.common.Constants.DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE;
+
+import static java.util.Collections.emptyList;

 import java.io.IOException;
-import java.net.*;
-import java.util.*;
+import java.net.Inet6Address;
+import java.net.InetAddress;
+import java.net.NetworkInterface;
+import java.net.SocketException;
+import java.net.UnknownHostException;
+import java.util.Enumeration;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
 import java.util.regex.Pattern;

-import static java.util.Collections.emptyList;
-import static org.apache.dolphinscheduler.common.Constants.DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;

 /**
 * NetUtils
 */
 public class NetUtils {

-
    private NetUtils() {
-        throw new IllegalStateException("Utility class");
+        throw new UnsupportedOperationException("Construct NetUtils");
    }

    private static Logger logger = LoggerFactory.getLogger(NetUtils.class);
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java
@ -14,8 +14,14 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.common.shell.ShellExecutor;
+
+import org.apache.commons.configuration.Configuration;
+
 import java.io.BufferedReader;
 import java.io.FileInputStream;
 import java.io.IOException;
@ -32,9 +38,6 @@ import java.util.Optional;
 import java.util.StringTokenizer;
 import java.util.regex.Pattern;

-import org.apache.commons.configuration.Configuration;
-import org.apache.dolphinscheduler.common.Constants;
-import org.apache.dolphinscheduler.common.shell.ShellExecutor;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

@ -45,7 +48,6 @@ import oshi.hardware.HardwareAbstractionLayer;

 /**
 * os utils
- *
 */
 public class OSUtils {

@ -64,7 +66,9 @@ public class OSUtils {

    private static HardwareAbstractionLayer hal = SI.getHardware();

-  private OSUtils() {}
+    private OSUtils() {
+        throw new UnsupportedOperationException("Construct OSUtils");
+    }

    /**
     * Initialization regularization, solve the problem of pre-compilation performance,
@ -72,10 +76,10 @@ public class OSUtils {
     */
    private static final Pattern PATTERN = Pattern.compile("\\s+");

-
    /**
     * get memory usage
     * Keep 2 decimal
+     *
     * @return percent %
     */
    public static double memoryUsage() {
@ -87,11 +91,11 @@ public class OSUtils {
        return Double.parseDouble(df.format(memoryUsage));
    }

-
    /**
     * get available physical memory size
-   *
+     * <p>
     * Keep 2 decimal
+     *
     * @return available Physical Memory Size, unit: G
     */
    public static double availablePhysicalMemorySize() {
@ -106,8 +110,9 @@ public class OSUtils {

    /**
     * get total physical memory size
-   *
+     * <p>
     * Keep 2 decimal
+     *
     * @return available Physical Memory Size, unit: G
     */
    public static double totalMemorySize() {
@ -119,7 +124,6 @@ public class OSUtils {
        return Double.parseDouble(df.format(availablePhysicalMemorySize));
    }

-
    /**
     * load average
     *
@ -194,6 +198,7 @@ public class OSUtils {

    /**
     * get user list from mac
+     *
     * @return user list
     */
    private static List<String> getUserListFromMac() throws IOException {
@ -207,8 +212,8 @@ public class OSUtils {

    /**
     * get user list from windows
+     *
     * @return user list
-   * @throws IOException
     */
    private static List<String> getUserListFromWindows() throws IOException {
        String result = exeCmd("net user");
@ -247,6 +252,7 @@ public class OSUtils {

    /**
     * create user
+     *
     * @param userName user name
     * @return true if creation was successful, otherwise false
     */
@ -277,6 +283,7 @@ public class OSUtils {

    /**
     * create linux user
+     *
     * @param userName user name
     * @param userGroup user group
     * @throws IOException in case of an I/O error
@ -295,6 +302,7 @@ public class OSUtils {

    /**
     * create mac user (Supports Mac OSX 10.10+)
+     *
     * @param userName user name
     * @param userGroup user group
     * @throws IOException in case of an I/O error
@ -323,6 +331,7 @@ public class OSUtils {

    /**
     * create windows user
+     *
     * @param userName user name
     * @param userGroup user group
     * @throws IOException in case of an I/O error
@ -347,6 +356,7 @@ public class OSUtils {

    /**
     * get system group information
+     *
     * @return system group info
     * @throws IOException errors
     */
@ -390,6 +400,7 @@ public class OSUtils {

    /**
     * Execute the shell
+     *
     * @param command command
     * @return result of execute the shell
     * @throws IOException errors
@ -400,6 +411,7 @@ public class OSUtils {

    /**
     * get process id
+     *
     * @return process id
     */
    public static int getProcessID() {
@ -409,15 +421,16 @@ public class OSUtils {

    /**
     * whether is macOS
+     *
     * @return true if mac
     */
    public static boolean isMacOS() {
        return getOSName().startsWith("Mac");
    }

-
    /**
     * whether is windows
+     *
     * @return true if windows
     */
    public static boolean isWindows() {
@ -426,6 +439,7 @@ public class OSUtils {

    /**
     * get current OS name
+     *
     * @return current OS name
     */
    public static String getOSName() {
@ -434,6 +448,7 @@ public class OSUtils {

    /**
     * check memory and cpu usage
+     *
     * @param systemCpuLoad systemCpuLoad
     * @param systemReservedMemory systemReservedMemory
     * @return check memory and cpu usage
@ -454,6 +469,7 @@ public class OSUtils {

    /**
     * check memory and cpu usage
+     *
     * @param conf conf
     * @param isMaster is master
     * @return check memory and cpu usage
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ParameterUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ParameterUtils.java
@ -14,10 +14,9 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

-import org.apache.commons.lang.StringUtils;
-import org.apache.commons.lang.time.DateUtils;
 import org.apache.dolphinscheduler.common.Constants;
 import org.apache.dolphinscheduler.common.enums.CommandType;
 import org.apache.dolphinscheduler.common.enums.DataType;
@ -25,12 +24,17 @@ import org.apache.dolphinscheduler.common.process.Property;
 import org.apache.dolphinscheduler.common.utils.placeholder.BusinessTimeUtils;
 import org.apache.dolphinscheduler.common.utils.placeholder.PlaceholderUtils;
 import org.apache.dolphinscheduler.common.utils.placeholder.TimePlaceholderUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;

 import java.sql.PreparedStatement;
-import java.text.ParseException;
-import java.util.*;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;

 /**
 * parameter parse utils
@ -39,6 +43,10 @@ public class ParameterUtils {

    private static final Logger logger = LoggerFactory.getLogger(ParameterUtils.class);

+    private ParameterUtils() {
+        throw new UnsupportedOperationException("Construct ParameterUtils");
+    }
+
    /**
     * convert parameters place holders
     *
@ -57,11 +65,7 @@ public class ParameterUtils {
        Date cronTime = null;

        if (StringUtils.isNotEmpty(cronTimeStr)) {
-      try {
-        cronTime = DateUtils.parseDate(cronTimeStr, new String[]{Constants.PARAMETER_FORMAT_TIME});
-      } catch (ParseException e) {
-        logger.error("parse {} exception", cronTimeStr, e);
-      }
+            cronTime = DateUtils.parse(cronTimeStr, Constants.PARAMETER_FORMAT_TIME);
        } else {
            cronTime = new Date();
        }
@ -94,12 +98,8 @@ public class ParameterUtils {
        Date cronTime = null;

        if (StringUtils.isNotEmpty(cronTimeStr)) {
-      try {
-        cronTime = DateUtils.parseDate(cronTimeStr, new String[]{Constants.PARAMETER_FORMAT_TIME});
+            cronTime = DateUtils.parse(cronTimeStr, Constants.PARAMETER_FORMAT_TIME);

-      } catch (ParseException e) {
-        logger.error(String.format("parse %s exception", cronTimeStr), e);
-      }
        } else {
            cronTime = new Date();
        }
@ -115,9 +115,9 @@ public class ParameterUtils {
        return parameterString;
    }

-
    /**
     * set in parameter
+     *
     * @param index index
     * @param stmt preparedstatement
     * @param dataType data type
@ -198,9 +198,9 @@ public class ParameterUtils {
        return JSONUtils.toJsonString(globalParamList);
    }

-
    /**
     * handle escapes
+     *
     * @param inputString input string
     * @return string filter escapes
     */
@ -212,12 +212,8 @@ public class ParameterUtils {
        return inputString;
    }

-
    /**
     * $[yyyyMMdd] replace schedule time
-   * @param text
-   * @param scheduleTime
-   * @return
     */
    public static String replaceScheduleTime(String text, Date scheduleTime) {
        Map<String, Property> paramsMap = new HashMap<>();
@ -236,9 +232,9 @@ public class ParameterUtils {
        return text;
    }

-
    /**
     * format convert
+     *
     * @param paramsMap params map
     * @return Map of converted
     * see org.apache.dolphinscheduler.server.utils.ParamUtils.convert
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/Preconditions.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/Preconditions.java
@ -14,16 +14,17 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
-package org.apache.dolphinscheduler.common.utils;

+package org.apache.dolphinscheduler.common.utils;

 /**
 * utility methods for validating input
- *
 */
 public final class Preconditions {

-    private Preconditions() {}
+    private Preconditions() {
+        throw new UnsupportedOperationException("Construct Preconditions");
+    }

    /**
     * if obj is null will throw NPE
@ -41,6 +42,7 @@ public final class Preconditions {

    /**
     * if obj is null will throw NullPointerException with error message
+     *
     * @param obj obj
     * @param errorMsg error message
     * @param <T> T
@ -53,13 +55,11 @@ public final class Preconditions {
        return obj;
    }

-
    /**
     * if condition is false will throw an IllegalArgumentException with the given message
     *
     * @param condition condition
     * @param errorMsg error message
-     *
     * @throws IllegalArgumentException Thrown, if the condition is violated.
     */
    public static void checkArgument(boolean condition, Object errorMsg) {
@ -68,5 +68,4 @@ public final class Preconditions {
        }
    }

-
 }
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtils.java
@ -14,13 +14,15 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

+import static org.apache.dolphinscheduler.common.Constants.COMMON_PROPERTIES_PATH;
+
 import org.apache.dolphinscheduler.common.Constants;
 import org.apache.dolphinscheduler.common.enums.ResUploadType;
+
 import org.apache.commons.io.IOUtils;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;

 import java.io.IOException;
 import java.io.InputStream;
@ -28,7 +30,8 @@ import java.util.HashMap;
 import java.util.Map;
 import java.util.Properties;

-import static org.apache.dolphinscheduler.common.Constants.COMMON_PROPERTIES_PATH;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;

 /**
 * property utils
@ -44,7 +47,7 @@ public class PropertyUtils {
    private static final Properties properties = new Properties();

    private PropertyUtils() {
-        throw new IllegalStateException("PropertyUtils class");
+        throw new UnsupportedOperationException("Construct PropertyUtils");
    }

    static {
@ -68,7 +71,6 @@ public class PropertyUtils {
    }

    /**
-     *
     * @return judge whether resource upload startup
     */
    public static Boolean getResUploadStartupState() {
@ -120,7 +122,6 @@ public class PropertyUtils {
    }

    /**
-     *
     * @param key key
     * @param defaultValue default value
     * @return property value
@ -172,6 +173,7 @@ public class PropertyUtils {

    /**
     * get property long value
+     *
     * @param key key
     * @param defaultVal default value
     * @return property value
@ -182,7 +184,6 @@ public class PropertyUtils {
    }

    /**
-     *
     * @param key key
     * @return property value
     */
@ -191,7 +192,6 @@ public class PropertyUtils {
    }

    /**
-     *
     * @param key key
     * @param defaultVal default value
     * @return property value
@ -201,9 +201,9 @@ public class PropertyUtils {
        return val == null ? defaultVal : Double.parseDouble(val);
    }

-
    /**
     * get array
+     *
     * @param key property name
     * @param splitStr separator
     * @return property value through array
@ -223,7 +223,6 @@ public class PropertyUtils {
    }

    /**
-     *
     * @param key key
     * @param type type
     * @param defaultValue default value
@ -238,6 +237,7 @@ public class PropertyUtils {

    /**
     * get all properties with specified prefix, like: fs.
+     *
     * @param prefix prefix to search
     * @return all properties with specified prefix
     */
@ -253,8 +253,6 @@ public class PropertyUtils {

    /**
     *
-     * @param key
-     * @param value
     */
    public static void setValue(String key, String value) {
        properties.setProperty(key, value);
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/RetryerUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/RetryerUtils.java
@ -17,15 +17,21 @@

 package org.apache.dolphinscheduler.common.utils;

-import com.github.rholder.retry.*;
 import org.apache.dolphinscheduler.common.Constants;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;

 import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeUnit;

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.github.rholder.retry.RetryException;
+import com.github.rholder.retry.Retryer;
+import com.github.rholder.retry.RetryerBuilder;
+import com.github.rholder.retry.StopStrategies;
+import com.github.rholder.retry.WaitStrategies;
+
 /**
 * The Retryer util.
 */
@ -35,7 +41,7 @@ public class RetryerUtils {
    private static Retryer<Boolean> defaultRetryerResultNoCheck;

    private RetryerUtils() {
-
+        throw new UnsupportedOperationException("Construct RetryerUtils");
    }

    private static Retryer<Boolean> getDefaultRetryerResultNoCheck() {
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/SchemaUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/SchemaUtils.java
@ -14,10 +14,8 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
-package org.apache.dolphinscheduler.common.utils;

-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+package org.apache.dolphinscheduler.common.utils;

 import java.io.File;
 import java.io.FileInputStream;
@ -29,17 +27,24 @@ import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
 * Metadata related common classes
- *
 */
 public class SchemaUtils {

    private static final Logger logger = LoggerFactory.getLogger(SchemaUtils.class);
    private static Pattern p = Pattern.compile("\\s*|\t|\r|\n");

+    private SchemaUtils() {
+        throw new UnsupportedOperationException("Construct SchemaUtils");
+    }
+
    /**
     * Gets upgradable schemas for all upgrade directories
+     *
     * @return all schema list
     */
    @SuppressWarnings("unchecked")
@ -84,6 +89,7 @@ public class SchemaUtils {

    /**
     * Determine whether schemaVersion is higher than version
+     *
     * @param schemaVersion schema version
     * @param version version
     * @return Determine whether schemaVersion is higher than version
@ -110,22 +116,24 @@ public class SchemaUtils {

    /**
     * Gets the current software version number of the system
+     *
     * @return current software version
     */
    public static String getSoftVersion() {
-		String soft_version;
+        String softVersion;
        try {
-			soft_version = FileUtils.readFile2Str(new FileInputStream(new File("sql/soft_version")));
-			soft_version = replaceBlank(soft_version);
+            softVersion = FileUtils.readFile2Str(new FileInputStream(new File("sql/soft_version")));
+            softVersion = replaceBlank(softVersion);
        } catch (FileNotFoundException e) {
            logger.error(e.getMessage(), e);
            throw new RuntimeException("Failed to get the product version description file. The file could not be found", e);
        }
-		return soft_version;
+        return softVersion;
    }

    /**
     * Strips the string of space carriage returns and tabs
+     *
     * @param str string
     * @return string removed blank
     */
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/SensitiveLogUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/SensitiveLogUtils.java
@ -14,9 +14,9 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

-import org.apache.commons.lang.StringUtils;
 import org.apache.dolphinscheduler.common.Constants;

 /**
@ -24,6 +24,10 @@ import org.apache.dolphinscheduler.common.Constants;
 */
 public class SensitiveLogUtils {

+    private SensitiveLogUtils() {
+        throw new UnsupportedOperationException("Construct SensitiveLogUtils");
+    }
+
    /**
     * @param dataSourcePwd data source password
     * @return String
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/StreamUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/StreamUtils.java
@ -14,6 +14,7 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

 import java.util.Iterator;
@ -22,7 +23,9 @@ import java.util.stream.StreamSupport;

 public class StreamUtils {

-    private StreamUtils() { }
+    private StreamUtils() {
+        throw new UnsupportedOperationException("Construct StreamUtils");
+    }

    public static <T> Stream<T> asStream(Iterator<T> sourceIterator) {
        return asStream(sourceIterator, false);
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/StringUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/StringUtils.java
@ -14,11 +14,17 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

 public class StringUtils {
+
    public static final String EMPTY = "";

+    private StringUtils() {
+        throw new UnsupportedOperationException("Construct StringUtils");
+    }
+
    public static boolean isEmpty(final CharSequence cs) {
        return cs == null || cs.length() == 0;
    }
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/TaskParametersUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/TaskParametersUtils.java
@ -14,13 +14,14 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
 package org.apache.dolphinscheduler.common.utils;

 import org.apache.dolphinscheduler.common.enums.TaskType;
 import org.apache.dolphinscheduler.common.task.AbstractParameters;
 import org.apache.dolphinscheduler.common.task.conditions.ConditionsParameters;
-import org.apache.dolphinscheduler.common.task.dependent.DependentParameters;
 import org.apache.dolphinscheduler.common.task.datax.DataxParameters;
+import org.apache.dolphinscheduler.common.task.dependent.DependentParameters;
 import org.apache.dolphinscheduler.common.task.flink.FlinkParameters;
 import org.apache.dolphinscheduler.common.task.http.HttpParameters;
 import org.apache.dolphinscheduler.common.task.mr.MapreduceParameters;
@ -31,10 +32,10 @@ import org.apache.dolphinscheduler.common.task.spark.SparkParameters;
 import org.apache.dolphinscheduler.common.task.sql.SqlParameters;
 import org.apache.dolphinscheduler.common.task.sqoop.SqoopParameters;
 import org.apache.dolphinscheduler.common.task.subprocess.SubProcessParameters;
+
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

-
 /**
 * task parameters utils
 */
@ -42,8 +43,13 @@ public class TaskParametersUtils {

    private static Logger logger = LoggerFactory.getLogger(TaskParametersUtils.class);

+    private TaskParametersUtils() {
+        throw new UnsupportedOperationException("Construct TaskParametersUtils");
+    }
+
    /**
     * get task parameters
+     *
     * @param taskType task type
     * @param parameter parameter
     * @return task parameters