Browse Source

Update PULL_REQUEST_TEMPLATE.md (#5022)

When commented out, even if the PR creator forgets to remove the tips, they will not appear in the PR when it is submitted.
pull/3/MERGE
fredster33 4 years ago committed by GitHub
parent
commit
9a3ae48396
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 20
      .github/PULL_REQUEST_TEMPLATE.md

20
.github/PULL_REQUEST_TEMPLATE.md

@ -1,19 +1,18 @@
## *Tips* <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)* ## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log ## Brief change log
*(for example:)* <!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml* - *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request ## Verify this pull request
*(Please pick either of the following options)* <!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage. This pull request is code cleanup without any test coverage.
@ -25,8 +24,7 @@ This pull request is already covered by existing tests, such as *(please describ
This change added tests and can be verified as follows: This change added tests and can be verified as follows:
*(example:)* <!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.* - *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.* - *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* - *Manually verified the change by testing locally.* -->

Loading…
Cancel
Save