Browse Source

Adapting partial code(file name start with I) to the sonar cloud rule (#2155)

pull/2/head
gabry.wu 5 years ago committed by GitHub
parent
commit
93aa160698
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 19
      dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/IOUtils.java
  2. 5
      dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/IpUtils.java
  3. 6
      dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/IpUtilsTest.java

19
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/IOUtils.java

@ -19,26 +19,17 @@
package org.apache.dolphinscheduler.common.utils; package org.apache.dolphinscheduler.common.utils;
import java.io.Closeable;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
public class IOUtils { public class IOUtils {
public static void closeQuietly(InputStream fis){ public static void closeQuietly(Closeable closeable){
if(fis != null){ if(closeable != null){
try { try {
fis.close(); closeable.close();
} catch (IOException ignore) {
}
}
}
public static void closeQuietly(InputStreamReader reader){
if(reader != null){
try {
reader.close();
} catch (IOException ignore) { } catch (IOException ignore) {
// nothing need to do
} }
} }
} }

5
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/IpUtils.java

@ -17,16 +17,11 @@
package org.apache.dolphinscheduler.common.utils; package org.apache.dolphinscheduler.common.utils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/** /**
* http utils * http utils
*/ */
public class IpUtils { public class IpUtils {
private static final Logger logger = LoggerFactory.getLogger(IpUtils.class);
public static final String DOT = "."; public static final String DOT = ".";
/** /**

6
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/IpUtilsTest.java

@ -29,13 +29,13 @@ public class IpUtilsTest {
long longNumber = IpUtils.ipToLong(ip); long longNumber = IpUtils.ipToLong(ip);
long longNumber2 = IpUtils.ipToLong(ip2); long longNumber2 = IpUtils.ipToLong(ip2);
System.out.println(longNumber); System.out.println(longNumber);
Assert.assertEquals(longNumber, 3232263681L); Assert.assertEquals(3232263681L, longNumber);
Assert.assertEquals(longNumber2, 0L); Assert.assertEquals(0L, longNumber2);
String ip3 = "255.255.255.255"; String ip3 = "255.255.255.255";
long longNumber3 = IpUtils.ipToLong(ip3); long longNumber3 = IpUtils.ipToLong(ip3);
System.out.println(longNumber3); System.out.println(longNumber3);
Assert.assertEquals(longNumber3, 4294967295L); Assert.assertEquals(4294967295L, longNumber3);
} }

Loading…
Cancel
Save