[fix-4472][DataSource] Hive JDBC partial permission parameter concatenation JDBC URL error (#4473)

* Solve the problem of parameter splicing of permission part in Hive JDBC URL.

* update code style.

* add test check in pom.xml.

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HiveConfUtils.java

@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+/**
+ * hive conf utils
+ */
+public class HiveConfUtils {
+
+    private HiveConfUtils() {
+        throw new UnsupportedOperationException("Construct HiveConfUtils");
+    }
+
+    private static class HiveConfHandler {
+        private static HiveConf singleton;
+
+        private static Map<String,Object> hiveConfVars;
+
+        static {
+            singleton = new HiveConf();
+            hiveConfVars = new HashMap<>();
+            Arrays.stream(ConfVars.values()).forEach(confVar -> hiveConfVars.put(confVar.varname,confVar));
+        }
+    }
+
+    /**
+     * get HiveConf instance
+     * @return HiveConf hiveConf
+     */
+    public static HiveConf getInstance() {
+        return HiveConfHandler.singleton;
+    }
+
+    /**
+     * get hive conf vars
+     * @return
+     */
+    public static Map<String,Object> getHiveConfVars() {
+        return HiveConfHandler.hiveConfVars;
+    }
+
+    /**
+     * Determine if it belongs to a hive conf property
+     * @param conf config
+     * @return boolean result
+     */
+    public static boolean isHiveConfVar(String conf) {
+        // the default hive conf var name
+        String confKey = conf.split("=")[0];
+        Map<String, Object> hiveConfVars = HiveConfUtils.getHiveConfVars();
+        if (hiveConfVars.get(confKey) != null) {
+            return true;
+        }
+
+        // the security authorization hive conf var name
+        HiveConf hiveConf = HiveConfUtils.getInstance();
+        String hiveAuthorizationSqlStdAuthConfigWhitelist = hiveConf.getVar(HiveConf.ConfVars.HIVE_AUTHORIZATION_SQL_STD_AUTH_CONFIG_WHITELIST);
+        Pattern modWhiteListPattern = Pattern.compile(hiveAuthorizationSqlStdAuthConfigWhitelist);
+        Matcher matcher = modWhiteListPattern.matcher(confKey);
+        return matcher.matches();
+    }
+
+}

dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/HiveConfUtilsTest.java

@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * hive conf utils test
+ */
+public class HiveConfUtilsTest {
+
+    /**
+     * test is hive conf var
+     */
+    @Test
+    public void testIsHiveConfVar() {
+
+        String conf = "hive.exec.script.wrapper=123";
+        boolean hiveConfVar = HiveConfUtils.isHiveConfVar(conf);
+        Assert.assertTrue(hiveConfVar);
+
+        conf = "hive.test.v1=v1";
+        hiveConfVar = HiveConfUtils.isHiveConfVar(conf);
+        Assert.assertFalse(hiveConfVar);
+
+        conf = "tez.queue.name=tezQueue";
+        hiveConfVar = HiveConfUtils.isHiveConfVar(conf);
+        Assert.assertTrue(hiveConfVar);
+
+    }
+}

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/HiveDataSource.java

@@ -20,14 +20,10 @@ package org.apache.dolphinscheduler.dao.datasource;
 import org.apache.dolphinscheduler.common.Constants;
 import org.apache.dolphinscheduler.common.enums.DbType;
 import org.apache.dolphinscheduler.common.utils.CommonUtils;
+import org.apache.dolphinscheduler.common.utils.HiveConfUtils;
 import org.apache.dolphinscheduler.common.utils.StringUtils;
 
-import org.apache.hadoop.hive.conf.HiveConf.ConfVars;
-
 import java.sql.Connection;
-import java.util.Set;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
 
 /**
  * data source of hive
@@ -73,12 +69,8 @@ public class HiveDataSource extends BaseDataSource {
 
         String[] otherArray = otherParams.split(";", -1);
 
-        // get the default hive conf var name
-        Set<String> hiveConfSet = Stream.of(ConfVars.values()).map(confVars -> confVars.varname)
-            .collect(Collectors.toSet());
-
         for (String conf : otherArray) {
-            if (hiveConfSet.contains(conf.split("=")[0])) {
+            if (HiveConfUtils.isHiveConfVar(conf)) {
                 hiveConfListSb.append(conf).append(";");
             } else {
                 sessionVarListSb.append(conf).append(";");
@@ -107,4 +99,5 @@ public class HiveDataSource extends BaseDataSource {
         CommonUtils.loadKerberosConf();
         return super.getConnection();
     }
+
 }

dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/datasource/HiveDataSourceTest.java

@@ -25,61 +25,65 @@ import org.junit.Test;
  */
 public class HiveDataSourceTest {
 
-  @Test
+    @Test
-  public void testfilterOther() {
+    public void testFilterOther() {
-    BaseDataSource hiveDataSource = new HiveDataSource();
+        BaseDataSource hiveDataSource = new HiveDataSource();
 
-    // not contain hive_site_conf
+        // not contain hive_site_conf
-    String other = hiveDataSource.filterOther("charset=UTF-8");
+        String other = hiveDataSource.filterOther("charset=UTF-8");
-    Assert.assertEquals("charset=UTF-8", other);
+        Assert.assertEquals("charset=UTF-8", other);
 
-    // not contain
+        // not contain
-    other = hiveDataSource.filterOther("");
+        other = hiveDataSource.filterOther("");
-    Assert.assertEquals("", other);
+        Assert.assertEquals("", other);
 
-    // only contain hive_site_conf
+        // only contain hive_site_conf
-    other = hiveDataSource.filterOther("hive.mapred.mode=strict");
+        other = hiveDataSource.filterOther("hive.mapred.mode=strict");
-    Assert.assertEquals("?hive.mapred.mode=strict", other);
+        Assert.assertEquals("?hive.mapred.mode=strict", other);
 
-    // contain hive_site_conf at the first
+        // contain hive_site_conf at the first
-    other = hiveDataSource.filterOther("hive.mapred.mode=strict;charset=UTF-8");
+        other = hiveDataSource.filterOther("hive.mapred.mode=strict;charset=UTF-8");
-    Assert.assertEquals("charset=UTF-8?hive.mapred.mode=strict", other);
+        Assert.assertEquals("charset=UTF-8?hive.mapred.mode=strict", other);
 
-    // contain hive_site_conf in the middle
+        // contain hive_site_conf in the middle
-    other = hiveDataSource.filterOther("charset=UTF-8;hive.mapred.mode=strict;foo=bar");
+        other = hiveDataSource.filterOther("charset=UTF-8;hive.mapred.mode=strict;foo=bar");
-    Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict", other);
+        Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict", other);
 
-    // contain hive_site_conf at the end
+        // contain hive_site_conf at the end
-    other = hiveDataSource.filterOther("charset=UTF-8;foo=bar;hive.mapred.mode=strict");
+        other = hiveDataSource.filterOther("charset=UTF-8;foo=bar;hive.mapred.mode=strict");
-    Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict", other);
+        Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict", other);
 
-    // contain multi hive_site_conf
+        // contain multi hive_site_conf
-    other = hiveDataSource.filterOther("charset=UTF-8;foo=bar;hive.mapred.mode=strict;hive.exec.parallel=true");
+        other = hiveDataSource.filterOther("charset=UTF-8;foo=bar;hive.mapred.mode=strict;hive.exec.parallel=true");
-    Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict;hive.exec.parallel=true", other);
+        Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict;hive.exec.parallel=true", other);
-  }
 
-  @Test
+        // the security authorization hive conf var
-  public void testGetHiveJdbcUrlOther() {
+        other = hiveDataSource.filterOther("tez.queue.name=tezTest");
+        Assert.assertEquals("?tez.queue.name=tezTest", other);
 
-    BaseDataSource hiveDataSource = new HiveDataSource();
+    }
-    hiveDataSource.setAddress("jdbc:hive2://127.0.0.1:10000");
-    hiveDataSource.setDatabase("test");
-    hiveDataSource.setPassword("123456");
-    hiveDataSource.setUser("test");
-    Assert.assertEquals("jdbc:hive2://127.0.0.1:10000/test", hiveDataSource.getJdbcUrl());
 
-    hiveDataSource.setOther("charset=UTF-8;hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2");
+    @Test
+    public void testGetHiveJdbcUrlOther() {
 
-    Assert.assertEquals(
+        BaseDataSource hiveDataSource = new HiveDataSource();
-        "jdbc:hive2://127.0.0.1:10000/test;charset=UTF-8?hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2",
+        hiveDataSource.setAddress("jdbc:hive2://127.0.0.1:10000");
-        hiveDataSource.getJdbcUrl());
+        hiveDataSource.setDatabase("test");
+        hiveDataSource.setPassword("123456");
+        hiveDataSource.setUser("test");
+        Assert.assertEquals("jdbc:hive2://127.0.0.1:10000/test", hiveDataSource.getJdbcUrl());
 
-    hiveDataSource.setOther("hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2");
+        hiveDataSource.setOther("charset=UTF-8;hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2");
 
-    Assert.assertEquals(
+        Assert.assertEquals(
-        "jdbc:hive2://127.0.0.1:10000/test;?hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2",
+                "jdbc:hive2://127.0.0.1:10000/test;charset=UTF-8?hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2",
-        hiveDataSource.getJdbcUrl());
+                hiveDataSource.getJdbcUrl());
 
-  }
+        hiveDataSource.setOther("hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2");
+        Assert.assertEquals(
+                "jdbc:hive2://127.0.0.1:10000/test;?hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2",
+                hiveDataSource.getJdbcUrl());
+
+    }
 
 }

pom.xml

@@ -790,6 +790,7 @@
                         <include>**/common/utils/HadoopUtilsTest.java</include>
                         <include>**/common/utils/HttpUtilsTest.java</include>
                         <include>**/common/utils/KerberosHttpClientTest.java</include>
+                        <include>**/common/utils/HiveConfUtilsTest.java</include>
                         <include>**/common/ConstantsTest.java</include>
                         <include>**/common/utils/HadoopUtils.java</include>
                         <include>**/common/utils/RetryerUtilsTest.java</include>