Browse Source

[Fix-4674][UI] create warning instance and click Submit , without validate the required parameters (#4767)

* fix wareningInstance create instance validate parameter.

* rerun e2e test.
pull/3/MERGE
zhuangchong 4 years ago committed by GitHub
parent
commit
5e193cf414
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      dolphinscheduler-ui/src/js/conf/home/pages/security/pages/warningInstance/_source/createWarningInstance.vue
  2. 1
      dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js
  3. 1
      dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js

8
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/warningInstance/_source/createWarningInstance.vue

@ -129,6 +129,8 @@
})
},
_submit () {
this.$f.validate((valid) => {
if (valid) {
this.$f.rule.forEach(item => {
item.title = item.name
})
@ -150,7 +152,13 @@
this.$message.error(e.msg || '')
this.$refs.popover.spinnerLoading = false
})
} else {
this.$message.warning(`${i18n.$t('Instance parameter exception')}`)
this.$refs.popover.spinnerLoading = false
}
})
},
close () {
this.$emit('close')
}

1
dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js

@ -222,6 +222,7 @@ export default {
'Alarm instance name': 'Alarm instance name',
'Select plugin': 'Select plugin',
'Please enter group name': 'Please enter group name',
'Instance parameter exception': 'Instance parameter exception',
'Group Type': 'Group Type',
'Alarm plugin instance': 'Alarm plugin instance',
Remarks: 'Remarks',

1
dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js

@ -222,6 +222,7 @@ export default {
'Alarm instance name': '告警实例名称',
'Select plugin': '选择插件',
'Please enter group name': '请输入组名称',
'Instance parameter exception': '实例参数异常',
'Group Type': '组类型',
'Alarm plugin instance': '告警插件实例',
Remarks: '备注',

Loading…
Cancel
Save