Browse Source

Fix SonarCloud bug “Resources should be closed” (#1667)

#1666 Fix SonarCloud bug “Resources should be closed”
pull/2/head
Jave-Chen 5 years ago committed by dailidong
parent
commit
4b027fbf02
  1. 8
      dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ZooKeeperState.java

8
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ZooKeeperState.java

@ -55,7 +55,7 @@ public class ZooKeeperState {
public void getZookeeperInfo() { public void getZookeeperInfo() {
String content = cmd("srvr"); String content = cmd("srvr");
if (StringUtils.isNotBlank(content)) { if (StringUtils.isNotBlank(content)) {
Scanner scannerForStat = new Scanner(content); try (Scanner scannerForStat = new Scanner(content)) {
while (scannerForStat.hasNext()) { while (scannerForStat.hasNext()) {
String line = scannerForStat.nextLine(); String line = scannerForStat.nextLine();
if (line.startsWith("Latency min/avg/max:")) { if (line.startsWith("Latency min/avg/max:")) {
@ -77,19 +77,19 @@ public class ZooKeeperState {
nodeCount = Integer.parseInt(getStringValueFromLine(line)); nodeCount = Integer.parseInt(getStringValueFromLine(line));
} }
} }
scannerForStat.close(); }
} }
String wchsText = cmd("wchs"); String wchsText = cmd("wchs");
if (StringUtils.isNotBlank(wchsText)) { if (StringUtils.isNotBlank(wchsText)) {
Scanner scannerForWchs = new Scanner(wchsText); try (Scanner scannerForWchs = new Scanner(wchsText)) {
while (scannerForWchs.hasNext()) { while (scannerForWchs.hasNext()) {
String line = scannerForWchs.nextLine(); String line = scannerForWchs.nextLine();
if (line.startsWith("Total watches:")) { if (line.startsWith("Total watches:")) {
watches = Integer.parseInt(getStringValueFromLine(line)); watches = Integer.parseInt(getStringValueFromLine(line));
} }
} }
scannerForWchs.close(); }
} }
String consText = cmd("cons"); String consText = cmd("cons");

Loading…
Cancel
Save