Browse Source

Fix unchecked type conversions

2.0.7-release
lyxell 3 years ago
parent
commit
0206a0e9f1
  1. 2
      dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/graph/DAG.java
  2. 2
      dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/ResourceProcessDefinitionUtilsTest.java
  3. 2
      dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/executor/NettyExecutorManager.java
  4. 6
      dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/MasterExecThreadTest.java

2
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/graph/DAG.java

@ -435,7 +435,7 @@ public class DAG<Node, NodeInfo, EdgeInfo> {
final Map<Node, EdgeInfo> neighborEdges = edges.get(node); final Map<Node, EdgeInfo> neighborEdges = edges.get(node);
if (neighborEdges == null) { if (neighborEdges == null) {
return Collections.EMPTY_MAP.keySet(); return Collections.emptySet();
} }
return neighborEdges.keySet(); return neighborEdges.keySet();

2
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/ResourceProcessDefinitionUtilsTest.java

@ -31,7 +31,7 @@ public class ResourceProcessDefinitionUtilsTest {
@Test @Test
public void getResourceProcessDefinitionMapTest(){ public void getResourceProcessDefinitionMapTest(){
List<Map<String,Object>> mapList = new ArrayList<>(); List<Map<String,Object>> mapList = new ArrayList<>();
Map<String,Object> map = new HashMap(); Map<String,Object> map = new HashMap<>();
map.put("code",1L); map.put("code",1L);
map.put("resource_ids","1,2,3"); map.put("resource_ids","1,2,3");
mapList.add(map); mapList.add(map);

2
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/executor/NettyExecutorManager.java

@ -178,7 +178,7 @@ public class NettyExecutorManager extends AbstractExecutorManager<Boolean>{
* @return nodes * @return nodes
*/ */
private Set<String> getAllNodes(ExecutionContext context){ private Set<String> getAllNodes(ExecutionContext context){
Set<String> nodes = Collections.EMPTY_SET; Set<String> nodes = Collections.emptySet();
/** /**
* executor type * executor type
*/ */

6
dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/MasterExecThreadTest.java

@ -101,8 +101,8 @@ public class MasterExecThreadTest {
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_END_DATE, "2020-01-20 23:00:00"); cmdParam.put(CMDPARAM_COMPLEMENT_DATA_END_DATE, "2020-01-20 23:00:00");
Mockito.when(processInstance.getCommandParam()).thenReturn(JSONUtils.toJsonString(cmdParam)); Mockito.when(processInstance.getCommandParam()).thenReturn(JSONUtils.toJsonString(cmdParam));
ProcessDefinition processDefinition = new ProcessDefinition(); ProcessDefinition processDefinition = new ProcessDefinition();
processDefinition.setGlobalParamMap(Collections.EMPTY_MAP); processDefinition.setGlobalParamMap(Collections.emptyMap());
processDefinition.setGlobalParamList(Collections.EMPTY_LIST); processDefinition.setGlobalParamList(Collections.emptyList());
Mockito.when(processInstance.getProcessDefinition()).thenReturn(processDefinition); Mockito.when(processInstance.getProcessDefinition()).thenReturn(processDefinition);
masterExecThread = PowerMockito.spy(new MasterExecThread(processInstance, processService, null, null, config)); masterExecThread = PowerMockito.spy(new MasterExecThread(processInstance, processService, null, null, config));
@ -256,7 +256,7 @@ public class MasterExecThreadTest {
} }
private List<Schedule> zeroSchedulerList() { private List<Schedule> zeroSchedulerList() {
return Collections.EMPTY_LIST; return Collections.emptyList();
} }
private List<Schedule> oneSchedulerList() { private List<Schedule> oneSchedulerList() {

Loading…
Cancel
Save