代码规范

designer/src/com/fr/design/mainframe/ElementCasePaneDelegate.java

@@ -45,12 +45,23 @@ public class ElementCasePaneDelegate extends ElementCasePane<WorkSheet> {
     public ElementCasePaneDelegate(WorkSheet sheet) {
         super(sheet);
         this.addSelectionChangeListener(new SelectionListener() {
-
             @Override
             public void selectionChanged(SelectionEvent e) {
                 if (!isEditable()) {
                     return;
                 }
+                doOnSelectionChanged();
+            }
+        });
+        this.addTargetModifiedListener(new TargetModifiedListener() {
+            @Override
+            public void targetModified(TargetModifiedEvent e) {
+                CellElementPropertyPane.getInstance().populate(ElementCasePaneDelegate.this);
+            }
+        });
+    }
+
+    private void doOnSelectionChanged() {
         //在编辑权限，所以要更新权限编辑面板
         if (BaseUtils.isAuthorityEditing()) {
             AuthorityPropertyPane authorityPropertyPane = new AuthorityPropertyPane(ElementCasePaneDelegate.this);
@@ -91,14 +102,6 @@ public class ElementCasePaneDelegate extends ElementCasePane<WorkSheet> {
             EastRegionContainerPane.getInstance().removeParameterPane();
         }
     }
-        });
-        this.addTargetModifiedListener(new TargetModifiedListener() {
-            @Override
-            public void targetModified(TargetModifiedEvent e) {
-                CellElementPropertyPane.getInstance().populate(ElementCasePaneDelegate.this);
-            }
-        });
-    }
 
     @Override
     protected boolean supportRepeatedHeaderFooter() {
@@ -126,6 +129,7 @@ public class ElementCasePaneDelegate extends ElementCasePane<WorkSheet> {
      *
      * @return 不是必须在可见范围.
      */
+    @Override
     public boolean mustInVisibleRange() {
         return false;
     }

designer/src/com/fr/design/write/submit/SmartInsertDBManipulationPane.java

@@ -8,9 +8,7 @@ import java.awt.event.ActionEvent;
 
 import javax.swing.BorderFactory;
 import javax.swing.JDialog;
-import javax.swing.JLayeredPane;
 import javax.swing.JPanel;
-import javax.swing.JRootPane;
 import javax.swing.JTable;
 import javax.swing.SwingUtilities;
 import javax.swing.table.DefaultTableCellRenderer;
@@ -43,12 +41,15 @@ import com.fr.grid.selection.FloatSelection;
 import com.fr.grid.selection.Selection;
 import com.fr.stable.ColumnRow;
 import com.fr.stable.ColumnRowGroup;
+import com.fr.stable.StringUtils;
 import com.fr.write.DMLConfigJob;
 
 public class SmartInsertDBManipulationPane extends DBManipulationPane {
 	private static final Selection NO_SELECTION = new CellSelection(-1, -1, -1, -1);
 	private ElementCasePane ePane;
 	private static int CELL_GROUP_LIMIT = 6;
+    private static int TOP_PADDING = 30;
+    private static int LEFT_COLUMN_MAX_WIDTH = 40;
 
 	public SmartInsertDBManipulationPane(ElementCasePane ePane) {
 		super(ValueEditorPaneFactory.extendedCellGroupEditors());
@@ -57,6 +58,10 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 
     public SmartInsertDBManipulationPane() {
         super(ValueEditorPaneFactory.extendedCellGroupEditors());
+		init();
+    }
+
+	private void init() {
 		JTemplate jTemplate = DesignerContext.getDesignerFrame().getSelectedJTemplate();
 		this.ePane = ((JWorkBook) jTemplate).getEditingElementCasePane();
 	}
@@ -123,7 +128,7 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 				}
 			};
 			bPane.setLayout(FRGUIPaneFactory.createBorderLayout());
-			bPane.setBorder(BorderFactory.createEmptyBorder(30, 0, 0, 0));
+			bPane.setBorder(BorderFactory.createEmptyBorder(TOP_PADDING, 0, 0, 0));
 			final UIBasicSpinner columnSpinner = new UIBasicSpinner();
 			final UIBasicSpinner rowSpinner = new UIBasicSpinner();
 			Component[][] coms = new Component[][] { { new UILabel(Inter.getLocText("RWA-Row_Offset")), rowSpinner },{ new UILabel(Inter.getLocText("RWA-Column_Offset")), columnSpinner } };
@@ -289,11 +294,6 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 		}
 	}
 
-	private boolean possibleParentContainer(Container p) {
-		return p instanceof Dialog || p instanceof BasicPane ||
-				p instanceof JPanel || p instanceof JRootPane || p instanceof JLayeredPane;
-	}
-
 	private class SmartJTablePane4DB extends SmartJTablePane {
 
 		// 是否是单元格组
@@ -329,7 +329,7 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 			 * set Width
 			 */
 			TableColumn column0 = table.getColumnModel().getColumn(0);
-			column0.setMaxWidth(40);
+			column0.setMaxWidth(LEFT_COLUMN_MAX_WIDTH);
 			/*
 			 * 设置Column 1的Renderer
 			 */
@@ -410,7 +410,7 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 				// 要考虑多选的情况 要结合之前的看看 可能是增加 也可能需要减少
 				ColumnRowGroup add = new ColumnRowGroup();
 				int removeCount = 0;
-				if (oriCellSelection != null && sameStartPoint(cellselection, oriCellSelection)) {
+				if (oriCellSelection != null && isSameStartPoint(cellselection, oriCellSelection)) {
                     removeCount = dealDragSelection(add, cellselection);
 				} else if (cellselection.getSelectedType() == CellSelection.CHOOSE_ROW || cellselection.getSelectedType() == CellSelection.CHOOSE_COLUMN) {
                     dealSelectColRow(add, cellselection);
@@ -441,7 +441,7 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 				return newValue;
 			}
 
-			private boolean sameStartPoint(CellSelection cs1, CellSelection cs2) {
+			private boolean isSameStartPoint(CellSelection cs1, CellSelection cs2) {
 				return cs1.getColumn() == cs2.getColumn() && cs1.getRow() == cs2.getRow();
 			}
 
@@ -479,6 +479,7 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 		private SmartJTablePaneAction a = new AbstractSmartJTablePaneAction(this, SmartInsertDBManipulationPane.this) {
 			@Override
 			public void doOk() {
+                // 遗留代码
 			}
 
 			@Override
@@ -507,7 +508,7 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 					if (((ColumnValue)value).obj != null) {
 						this.setText(((ColumnValue)value).obj.toString());
 					} else {
-						this.setText("");
+						this.setText(StringUtils.EMPTY);
 					}
 				}
 
@@ -535,12 +536,12 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 					Object cv = ((ColumnValue) value).obj;
 					if (cv instanceof ColumnRowGroup && ((ColumnRowGroup)cv).getSize() >= CELL_GROUP_LIMIT) {
 						text.setText("[" + Inter.getLocText(new String[]{"Has_Selected", "Classifier-Ge", "Cell"},
-								new String[]{((ColumnRowGroup)cv).getSize()+"", ""}) + "]");
+								new String[]{((ColumnRowGroup)cv).getSize()+StringUtils.EMPTY, StringUtils.EMPTY}) + "]");
 						tip = cv.toString() + " " + tip;
 					} else if (cv != null) {
 						text.setText(cv.toString());
 					} else {
-						text.setText("");
+						text.setText(StringUtils.EMPTY);
 					}
 				}
 
@@ -568,12 +569,12 @@ public class SmartInsertDBManipulationPane extends DBManipulationPane {
 					Object cv = ((ColumnValue) value).obj;
 					if (cv instanceof ColumnRowGroup && ((ColumnRowGroup)cv).getSize() >= CELL_GROUP_LIMIT) {
 						this.setText("[" + Inter.getLocText(new String[]{"Has_Selected", "Classifier-Ge", "Cell"},
-								new String[]{((ColumnRowGroup)cv).getSize()+"", ""}) + "]");
+								new String[]{((ColumnRowGroup)cv).getSize()+StringUtils.EMPTY, StringUtils.EMPTY}) + "]");
 						tip = cv.toString() + " " + tip;
 					} else if (cv != null) {
 						this.setText(cv.toString());
 					} else {
-						this.setText("");
+						this.setText(StringUtils.EMPTY);
 					}
 				}
 

designer/src/com/fr/poly/creator/ECBlockPane.java

@@ -119,7 +119,7 @@ public class ECBlockPane extends PolyElementCasePane {
 
     // 插入菜单
     private MenuDef createInsertMenuDef() {
-        MenuDef menuDef = new MenuDef(Inter.getLocText("M-Insert"), 'I');
+        MenuDef menuDef = new MenuDef(Inter.getLocText("FR-Designer_M-Insert"), 'I');
         // 单元格菜单
         menuDef.addShortCut(DeprecatedActionManager.getCellMenu(this));
 

designer_base/src/com/fr/design/actions/ExitAuthorityEditAction.java

@@ -23,9 +23,10 @@ public class ExitAuthorityEditAction extends TemplateComponentAction {
 
 
 	public void prepare4Undo() {
-
+		// 遗留代码
 	}
 
+	@Override
 	public boolean executeActionReturnUndoRecordNeeded() {
 		TargetComponent tc = getEditingComponent();
 		if (tc == null) {