Merge pull request #50737 in DEC/fineui from master to feature/x

* commit '7b5a23e098ce98d134026d5726afe6edb8f5f9ee':
  ddd8fcf - DESIGN-4069 fix: 删除了 iconSize 属性，增加了按钮的 loading 状态
  DESIGN-4069 fix: 按钮增加闭包
  DESIGN-4069 【组件化】反馈-按钮

demo/js/base/button/demo.button.js

@@ -213,6 +213,35 @@ Demo.Button = BI.inherit(BI.Widget, {
                 },
                 height: 30
             }
+        }, {
+            el: {
+                type: "bi.button",
+                text: "图标在上面的按钮，而且可以自动撑开高度",
+                iconCls: "close-font",
+                iconGap: 24,
+                iconPosition: "top"
+            }
+        }, {
+            el: {
+                type: "bi.button",
+                text: "图标在下面的按钮",
+                iconCls: "close-font",
+                iconPosition: "bottom"
+            }
+        }, {
+            el: {
+                type: "bi.button",
+                text: "图标在左边的按钮",
+                iconCls: "close-font",
+                iconPosition: "left"
+            }
+        }, {
+            el: {
+                type: "bi.button",
+                text: "图标在右边的按钮",
+                iconCls: "close-font",
+                iconPosition: "right"
+            }
         }];
         // BI.each(items, function (i, item) {
         //     item.el.handler = function () {

src/base/single/button/buttons/button.js

@@ -1,4 +1,9 @@
-/**
+(function () {
+    function isVertical(position) {
+        return position === "top" || position === "bottom";
+    }
+
+    /**
      * 文字类型的按钮
      * @class BI.Button
      * @extends BI.BasicButton
@@ -6,21 +11,23 @@
      * @cfg {JSON} options 配置属性
      * @cfg {'common'/'success'/'warning'/'ignore'} [options.level='common'] 按钮类型，用不同颜色强调不同的场景
      */
-BI.Button = BI.inherit(BI.BasicButton, {
+    BI.Button = BI.inherit(BI.BasicButton, {
 
         _const: {
-        iconWidth: 18
+            iconWidth: 16
         },
 
         _defaultConfig: function (props) {
             var conf = BI.Button.superclass._defaultConfig.apply(this, arguments);
+
             return BI.extend(conf, {
                 baseCls: (conf.baseCls || "") + " bi-button" + ((BI.isIE() && BI.isIE9Below()) ? " hack" : ""),
                 attributes: {
                     tabIndex: 1
                 },
                 minWidth: (props.block === true || props.clear === true) ? 0 : 80,
-            height: 24,
+                // 44 = 垂直间距 6 + 边框 2 + 图标 16 + 图标和文字间隔 8 + 文字 12
+                height: isVertical(props.iconPosition) ? 44 + ((props.iconGap || 8) - 8) : 24,
                 shadow: props.clear !== true,
                 isShadowShowingOnSelected: true,
                 readonly: true,
@@ -29,6 +36,7 @@ BI.Button = BI.inherit(BI.BasicButton, {
                 block: false, // 是否块状显示，即不显示边框，没有最小宽度的限制
                 clear: false, // 是否去掉边框和背景
                 ghost: false, // 是否幽灵显示, 即正常状态无背景
+                loading: false, // 是否处于加载中
                 textAlign: "center",
                 whiteSpace: "nowrap",
                 textWidth: null,
@@ -38,21 +46,27 @@ BI.Button = BI.inherit(BI.BasicButton, {
                 tgap: 0,
                 bgap: 0,
                 lgap: 0,
-            rgap: 0
+                rgap: 0,
+                iconGap: 8,
+                iconPosition: "left"
             });
         },
 
         render: function () {
-        var o = this.options, self = this;
+            var o = this.options;
 
             // 由于button默认情况下有个边框，所以要主动算行高
             var lineHeight, textHeight = o.textHeight;
             if (BI.isNumber(o.height)) {
+                if (!isVertical(o.iconPosition)) {
                     if (o.clear || o.block) {
                         lineHeight = o.height;
                     } else {
                         lineHeight = o.height - 2;
                     }
+                } else {
+                    lineHeight = textHeight;
+                }
             }
             if (!textHeight) {
                 if (o.whiteSpace === "nowrap") {
@@ -65,9 +79,7 @@ BI.Button = BI.inherit(BI.BasicButton, {
                     cls: o.iconCls,
                     width: this._const.iconWidth,
                     height: lineHeight,
-                lineHeight: lineHeight,
+                    lineHeight: lineHeight
-                iconWidth: o.iconWidth,
-                iconHeight: o.iconHeight
                 });
                 this.text = BI.createWidget({
                     type: "bi.label",
@@ -77,15 +89,30 @@ BI.Button = BI.inherit(BI.BasicButton, {
                     height: lineHeight,
                     value: o.value
                 });
+                var layoutType = "bi.horizontal";
+                var gapContainer = {
+                    lgap: o.iconPosition === "left" && o.text ? o.iconGap : 0,
+                    rgap: o.iconPosition === "right" ? o.iconGap : 0,
+                    tgap: o.iconPosition === "top" ? o.iconGap : 0,
+                    bgap: o.iconPosition === "bottom" ? o.iconGap : 0
+                };
+                var items = [this.icon, BI.extend({el: this.text}, gapContainer)];
+                if (isVertical(o.iconPosition)) {
+                    layoutType = "bi.vertical";
+                }
+                if (o.iconPosition === "right" || o.iconPosition === "bottom") {
+                    items = [BI.extend({el: this.text}, gapContainer), this.icon];
+                }
                 BI.createWidget({
                     type: "bi.center_adapt",
                     element: this,
                     hgap: o.hgap,
                     vgap: o.vgap,
                     items: [{
-                    type: "bi.horizontal",
+                        type: layoutType,
-                    columnSize: ["", "fill"],
+                        horizontalAlign: "center",
-                    items: [this.icon, this.text]
+                        verticalAlign: "middle",
+                        items: items
                     }]
                 });
             } else {
@@ -116,6 +143,9 @@ BI.Button = BI.inherit(BI.BasicButton, {
             if (o.ghost === true) {
                 this.element.addClass("ghost");
             }
+            if (o.loading === true) {
+                this.element.addClass("loading");
+            }
             if (o.minWidth > 0) {
                 this.element.css({"min-width": o.minWidth / BI.pixRatio + BI.pixUnit});
             }
@@ -137,6 +167,14 @@ BI.Button = BI.inherit(BI.BasicButton, {
             }
         },
 
+        setLoading: function (loading) {
+            if(loading) {
+              this.element.addClass("loading");
+            } else {
+              this.element.removeClass("loading");
+            }
+        },
+
         setText: function (text) {
             BI.Button.superclass.setText.apply(this, arguments);
             this.text.setText(text);
@@ -164,6 +202,7 @@ BI.Button = BI.inherit(BI.BasicButton, {
         unHighLight: function () {
             this.text.unHighLight.apply(this.text, arguments);
         }
-});
+    });
-BI.shortcut("bi.button", BI.Button);
+    BI.shortcut("bi.button", BI.Button);
-BI.Button.EVENT_CHANGE = "EVENT_CHANGE";
+    BI.Button.EVENT_CHANGE = "EVENT_CHANGE";
+}());